Japanese translation replaced by Korean

[LuxuryCoop]

I uploaded a traslation(.po) file to Launchpad for Korean few weeks ago, but actually the file was imported in Japanese translation due to my mistake.
Then I had seen error messege that the import failed, so I think no problem was occoured.
However, I just knew there are successful some import.

Is it possible that Translation in Japanese revert to before version 14620? I can't repair the translation in Launchpad, and the faults is too many to revert one by one.
I'm sorry about my huge mistake.

[Don-vip]

Dirk, any idea?

[Don-vip]

It seems someone reuploaded the japanese translations already:
Uploaded by Yuki Shira on 2019-01-01 02:15:07 UTC

​https://bazaar.launchpad.net/~openstreetmap/josm/josm_trans/revision/2501#josm/ja.po

[stoecker]

"Yuki Shira" uploaded ja.po today at 02:15 UTC.

Sounds like a hotfix is necessary...

[Don-vip]

Translations look fine now, but all entries are marked "for review" with the korean translation being suggested. Is there a way to dismiss suggestions in batch? There's 4866 strings, too much to dismiss individually.

[Shirayuki]

I have dismissed all Korean translation suggestion with using Tampermonkey.

But there are 300+ Korean translations still remain and they should be removed.

Use this regular expression to find Korean characters: [가-힣]

[stoecker]

When you download the current ja.po, then you can replace the wrong strings with "" and upload again to remove them (or translate them instead :-).

You need a current downloaded file, as the header contains information about the launchpad time.

It's better, when one of you does this. For us Europeans it simply looks too similar...

[stoecker]

Downloading current file, copying the header lines into a pre-error-file and uploading again can do a "reset". But if there have been changes inbetween, they will be lost in this case.

Most important header is the "X-Launchpad-Export-Date".

Historic files can be found here: ​https://code.launchpad.net/~openstreetmap/josm/josm_trans

[Shirayuki]

At first, I replaced the wrong strings with "" and uploaded, but launchpad completely ignored empty strings :(

So we have replaced the remaining wrong strings manually.

I think you can release a hotfix.

[stoecker]

At first, I replaced the wrong strings with "" and uploaded, but launchpad completely ignored empty strings :(

Was the "X-Launchpad-Export-Date" after the error date? Otherwise Launchpad assumes you uploaded an old file and thus ignores changes which reverse the last modifications.

I think you can release a hotfix.

It needs a bit until the changes are in BZR for the i18n tools.

[Shirayuki]

As I did not know about "reset", I uploaded ja.po file with this header:

"X-Launchpad-Export-Date: 2019-01-01 00:25+0000\n"

I used Japanese translations in ja.po (revision 2480) which has this header:

"X-Launchpad-Export-Date: 2018-12-10 04:53+0000\n"

[Don-vip]

I will do an i18n update tomorrow to get latest changes from Launchpad. I'll let you check it to be sure the hotfix is correct before releasing it.

[Don-vip]

Dirk, we should update the i18n script to detect this kind of mistake early. In this case we had the opportunity to detect the error by checking the value of following lines:

• Korean translation for josm => Japanese translation for josm
• Language-Team : Korean <ko@…>\n => Language-Team : Japanese <tr@…>\n
• Language: ko\n => Language: ja\n

Probably checking the "Language" line is pretty straightforward.

[Don-vip]

In 14661/josm:

see #17162 - i18n update

[Don-vip]

@Shirayuki can you please check if Japanese translations are ok now?

[Shirayuki]

I have checked josm-snapshot-14663.jar and josm_josm-ja.po.
I have no problem with Japanese translations :)

But could you remove LuxuryCoop from Japanese translation contributors list? :P

[stoecker]

But could you remove LuxuryCoop from Japanese translation contributors list? :P

No. That's automatic...

Even if it was a bad contribution, it was one :-)

[Don-vip]

Replying to stoecker:

But could you remove LuxuryCoop from Japanese translation contributors list? :P

No. That's automatic...

Even if it was a bad contribution, it was one :-)

On the same topic you and I are also "contributors" of almost every language. It doesn't mean we speak 30+ languages, just that we fixed a lot of (technical) translation errors :)

[stoecker]

You don't speak. Shame on you. I thought you do. 😛

[Don-vip]

Sorry, I don't even know enough German to order something different from beer or sausages... :)

So. If this issue is fixed we can release an hotfix now.

@Simon, Gerd: as there has been a lot of changes since a few days, do you feel comfortable with promoting current JOSM as new tested version, or do you need a few days to stabilize any work in progress? Maybe we could wait to fix the keyboard issue #13160 first.

[GerdP]

I am still trying to find the first version that shows #13160. For me it is working fine with r10533. No other important work in progress.

[simon04]

@Don-vip: I tried to be careful. However, the commits r14628, r14653 might introduce unexpected behaviour in unforeseen cases (which we be detected not before releasing a new tested version), and I hope to not have introduced any regression in r14654. My other commits should be unproblematic.