Should not warn about unclosed way with natural=tree

[naoliv]

Have an unclosed way with natural=tree and validate it.
We can see 2 warnings:

• natural=tree on a way. Should be used on a node.
• Unclosed way - natural type tree

The first warning is right while the second not.

I am not really sure if this is the most correct solution but it solves the problem:

src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

@@ -135 +135 @@
     private static final UnclosedWaysCheck[] checks = {
         // CHECKSTYLE.OFF: SingleSpaceSeparator
         new UnclosedWaysCheck(1101, "natural",   marktr("natural type {0}"),
-                new HashSet<>(Arrays.asList("cave", "coastline", "cliff", "tree_row", "ridge", "valley", "arete", "gorge", "gully"))),
+                new HashSet<>(Arrays.asList("cave", "coastline", "cliff", "tree", "tree_row", "ridge", "valley", "arete", "gorge", "gully"))),
         new UnclosedWaysCheck(1102, "landuse",   marktr("landuse type {0}")),
         new UnclosedWaysCheck(1103, "amenities", marktr("amenities type {0}")),
         new UnclosedWaysCheck(1104, "sport",     marktr("sport type {0}"),

[anonymous]

I am not really sure if this is the most correct solution but it solves the problem:

It looks perfectly correct to me.

[GerdP]

Taginfo shows a lot more natural values that can be used on nodes. We have a mapcss rule that treats peak, saddle, volcano, and tree the same. So I think we must add those to avoid duplicate messages.

[naoliv]

With the new values (also sorted them):

src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

@@ -135 +135 @@
     private static final UnclosedWaysCheck[] checks = {
         // CHECKSTYLE.OFF: SingleSpaceSeparator
         new UnclosedWaysCheck(1101, "natural",   marktr("natural type {0}"),
-                new HashSet<>(Arrays.asList("cave", "coastline", "cliff", "tree_row", "ridge", "valley", "arete", "gorge", "gully"))),
+                new HashSet<>(Arrays.asList("arete", "cave", "cliff", "coastline", "gorge", "gully", "peak", "ridge", "saddle", "tree", "tree_row", "valley", "volcano"))),
         new UnclosedWaysCheck(1102, "landuse",   marktr("landuse type {0}")),
         new UnclosedWaysCheck(1103, "amenities", marktr("amenities type {0}")),
         new UnclosedWaysCheck(1104, "sport",     marktr("sport type {0}"),

[GerdP]

In 14559/josm:

fix #17108 avoid duplicate warning for unclosed ways which are also tested in geometry.mapcss rule "{0} on a way, should be a node"