Update plugins dialog should only appear when update changes something

[GerdP]

What steps will reproduce the problem?

1. Compile JOSM from updated svn repo
2. Start freshly compiled JOSM, press OK in the "update plugins?" popup
3. Wait until svn repo changes
4. update local copy and compile
5. Start freshly compiled JOSM

What is the expected result?

No "update plugins?" dialog unless one of the used plugins was changed between steps 2 and 5

What happens instead?

Dialog pops up and waits for user, pressing OK has no effect, pressing Cancel means the popup will show again next start.

Please provide any additional information below. Attach a screenshot if possible.

My understanding is that JOSM should be able to find out if any plugin was changed or the newer JOSM version allows to use a newer plugin before the popup is shown. If not, the popup is not needed.

Build-Date:2018-12-12 11:04:39
Revision:14554
Is-Local-Build:true

Identification: JOSM/1.5 (14554 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 582 MB / 3641 MB (173 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:59200, -ea, -Dfile.encoding=UTF-8]

Plugins:
+ OpeningHoursEditor (34535)
+ apache-commons (34506)
+ austriaaddresshelper (57)
+ buildings_tools (34724)
+ continuosDownload (82)
+ contourmerge (v0.1.3)
+ download_along (34503)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34506)
+ jts (34524)
+ merge-overlap (34664)
+ o5m (34405)
+ opendata (34698)
+ pbf (34576)
+ poly (34546)
+ reverter (34552)
+ undelete (34568)
+ utilsplugin2 (34770)

Map paint styles:
- https://pasharm.github.io/New_basic_style_for_JOSM/New_basic_style.mapcss
+ f:\dwnload\temp\New_basic_style.mapcss

Last errors/warnings:
- W: Update plugins - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: No configuration settings found.  Using hardcoded default values for all pools.

[stoecker]

Are you sure that you recompile did not increase main version above the previous main version requirement, so that a new plugin was available?

[GerdP]

Not sure what you mean. Did you read my additional informaton?

[stoecker]

In step 4 you recompile JOSM. This increases the JOSM version and it is possible that a previous plugin change which you could not use before becomes usable and thus triggers an JOSM plugin update request.

This no plugin change between 2 and 5 is necessary. The increase in JOSM version is enough.

[GerdP]

That is understood. My goal is to suppress the dialog when the update has no effect. Not sure what is needed to compute that information, but I think it would be faster compared to a user dialog waiting for input and computing it afterwards?

[stoecker]

Replying to GerdP:

That is understood. My goal is to suppress the dialog when the update has no effect. Not sure what is needed to compute that information, but I think it would be faster compared to a user dialog waiting for input and computing it afterwards?

That dialog should only come, when a newer plugin is available. So that suppression is already there. If not, find the reason, there may be strange version numbers or something else responsible for an update request you don't like.

[GerdP]

OK. I'll try to find out why it doesn't work for me.

[GerdP]

I think it cannot work as you describe. PluginHandler.checkAndConfirmPluginUpdate() compares the value pluginmanager.version that was stored in preferences. If that value is smaller than the current version the popup is shown. This all happens before the remote list is processed.
Maybe you have set the "remember my decision" flag?

[GerdP]

I tried to fix this but the code is quite complex, so it seems I have to live with this dialog :-(