slippy map in the download dialogue should not default to the non-standard imagery provider "Mapnik"

[aseerel4c26]

The slippy map in the download dialogue defaults to a imagery named "Mapnik" which is not listed in the default imagery provider list. It still works and downloads the standard tiles from osm.org.

This should default to the standard imagery provider "OpenStreetMap Carto (Standard)". Advantages:

1. bandwidth savings if the user uses the "OpenStreetMap Carto (Standard)" as background layer AND uses the download dialogue.
2. no ghost "Mapnik" entry in the Cache contents tab - it may be not obvious where this entry stems from since "Mapnik" is no imagery provider.

Or is there any reason to stick with the old "Mapnik"? I guess it is just a left-over from the standard imagery name (before it was renamed to Carto).

Tested with deleted config and cache directory.
Identification: JOSM/1.5 (14460 en_GB) Linux Linux
Java version: 10.0.2+13, Oracle Corporation, OpenJDK 64-Bit Server VM

[aseerel4c26]

Mapnik entry in selection menu

[Don-vip]

In 14495/josm:

fix #17054 - prefer JOSM imagery entry "OpenStreetMap Carto (Standard)" over jmapviewer tile source "Mapnik"

[aseerel4c26]

Thanks, perfect! :-) Tested with v14500 and fresh config: both "Advantages" work. "Mapnik" only comes back if I delete "OpenStreetMap Carto (Standard)" from my tiles list.

[Klumbumbus]

I added oldid, maybe that helps to clean up old remaining mapnik entries. https://josm.openstreetmap.de/wiki/Maps/Worldwide?action=diff&version=41

[stoecker]

Wont help. I think jmapviewer defaults simply should be updated...

[Don-vip]

that's unrelated, I didn't even know we had an entry with id "MAPNIK" before. The "Mapnik" entry des not come from Maps, it's a Java class that comes from JMapViewer.

[stoecker]

Updated defaults in [o34765].

[Don-vip]

Build is broken

[Don-vip]

Fixed in [o34766].