JMockit : Cannot execute JUnit test MultipolygonTest from Eclipse

[GerdP]

When I try to execute MultipolygonTestTest in Eclipse I see the dump below. What do I have to do to make this work again?

MultipolygonTestTest
org.openstreetmap.josm.data.validation.tests.MultipolygonTestTest
testTicket10469(org.openstreetmap.josm.data.validation.tests.MultipolygonTestTest)
java.lang.ExceptionInInitializerError
	at org.openstreetmap.josm.testutils.JOSMTestRules.before(JOSMTestRules.java:543)
	at org.openstreetmap.josm.testutils.JOSMTestRules$CreateJosmEnvironment.evaluate(JOSMTestRules.java:640)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
Caused by: java.lang.IllegalStateException: JMockit didn't get initialized; please check the -javaagent JVM initialization parameter was used
	at mockit.internal.startup.Startup.verifyInitialization(Startup.java:91)
	at mockit.MockUp.<clinit>(MockUp.java:56)

	... 19 more

[Don-vip]

It's very cumbersome right now because JMockit requires adding VM argument -javaagent:<your directory>/josm/core/test/lib/jmockit-1.43.jar on the command line

[Don-vip]

@ris can we make a change so this is only needed for tests really using JMockit? It shouldn't be needed for 90% of tests, like MultipolygonTestTest in this case.

[michael2402]

We should add a new test rules setting for this - but this will only work on a per-class basis.

When we switch to Junit Jupiter, we can write an extension and add the @ExtendWith() only to the test methods that use it.

[GerdP]

Replying to Don-vip:

It's very cumbersome right now because JMockit requires adding VM argument -javaagent:<your directory>/josm/core/test/lib/jmockit-1.43.jar on the command line

OK, that did the trick. Just a hint: This is not needed to run e.g. RelationCheckerTest.

[ris]

can we make a change so this is only needed for tests really using JMockit?

That's a very good question - the answer is I don't know. I don't know a lot about eclipse and how it runs individual tests...

[Don-vip]

This is not really specific to Eclipse, you may have the issue with all IDEs I think, as I don't see how they could guess we need to add the JMockit agent. How do you run unit tests while developing them?

[ris]

I'm a text-editor-and-a-terminal kinda guy. If I want to run a subset or just a particular test I really just change the glob pattern in <batchtest><fileset> ... and re-run.

[michael2402]

In #8269 there is a gradle build script.

Once we switch to gradle, you can simply use --tests=..pattern..

For Eclipse, you can use a new JVM configuration for your project. You can use the same Java home directory but you add the agent arguments to the default arguments. Since the tests in your project are then run using that JVM, you always have the agent even if you just re-run a single test.