WMS Layer selection - layer titles are overwritted by Attribution titles

[anonymous]

What steps will reproduce the problem?

1. Open the WMS map "INEGI Digital Map of Mexico" - see screenshot 1
2. You will see a lot of layers title "INEGI" instead of their actual layer name - see screenshot 2

What is the expected result?

To see the layername, "Datos del relieve" (which is okay), or Hipsográfico (which is not okay)

What happens instead?

• layer name "Datos del relieve" is displayed, because the <ATTRIBUTION> element is missing in the WMS file
• layer name "Hipsográfico" is not displayed, instead it's title of the <ATTRIBUTION> element is displayed = "INEGI"

for details of the xml element see below.
The full xml file is available here:

• v5 ​https://gaia.inegi.org.mx/NLB/mdm5.wms?Request=GetCapabilities&Version=1.1.1&Service=WMS
• v6 ​https://gaia.inegi.org.mx/NLB/tunnel/wms/wms61?Request=GetCapabilities&Version=1.1.1&Service=WMS

Please provide any additional information below. Attach a screenshot if possible.

<Layer>

<!-- WARNING: The layer name 'Datos del relieve' might contain spaces or invalid characters or may start with a number. This could lead to potential problems. -->
<Name>Datos del relieve</Name>
<Title>Datos del relieve</Title>
<Abstract>Datos del relieve</Abstract>
<Style>

<Name>default</Name>
<Title>default</Title>

</Style>
<Layer queryable="0" opaque="0" cascaded="1">

<Name>c00</Name>

<Title>Hipsográfico</Title> <---- DISPLAYED INCORRECTLY

<Abstract></Abstract>
<KeywordList>

<Keyword></Keyword>

</KeywordList>
<SRS>EPSG:4326</SRS>
<LatLonBoundingBox minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />
<BoundingBox SRS="EPSG:4326"

minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />

<Attribution>
<Title>INEGI</Title> <--- BECause of Attribution title

<OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="http://www.inegi.org.mx/"/>
<LogoURL width="20" height="20">

<Format>image/jpg</Format>
<OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://mapserver.inegi.org.mx/images/logoINEGI.JPG"/>

</LogoURL>

</Attribution>
<DataURL>

<Format>text/html</Format>
<OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://mapserver.inegi.org.mx/geografia/espanol/normatividad/metadatos/gateway.cfm"/>

</DataURL>
<ScaleHint min="299.341709057782" max="0" />
<!-- WARNING: Only MINSCALEDENOM and no MAXSCALEDENOM specified in the mapfile. A default value of 0 has been returned for the Max ScaleHint but this is probably not what you want. -->

</Layer>
<Layer queryable="0" opaque="0" cascaded="1">

<Name>b54</Name>

<Title>Hipsográfico escala de grises</Title> <---- displayed correctly

<SRS>EPSG:4326</SRS>
<LatLonBoundingBox minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />
<BoundingBox SRS="EPSG:4326"

minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />

<ScaleHint min="9.97805696859274" max="4989028.48429637" />

</Layer> <--- Layer is CLOSED without , attribution element

</Layer>
<Layer>

<Name>T1M</Name>
<Title>T1m</Title>
<Abstract>T1M</Abstract>
<Style>

<Name>default</Name>
<Title>default</Title>

</Style>
<Layer queryable="1" opaque="0" cascaded="0">

<Name>c104</Name>
<Title>Mares_País Extranjero</Title>
<Abstract></Abstract>
<KeywordList>

<Keyword></Keyword>

</KeywordList>
<SRS>EPSG:4326</SRS>
<LatLonBoundingBox minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />
<BoundingBox SRS="EPSG:4326"

minx="-119.993" miny="9.404" maxx="-85.1237" maxy="37.8468" />

<Attribution>

<Title>INEGI</Title>
<OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="http://www.inegi.org.mx/"/>
<LogoURL width="20" height="20">

<Format>image/jpg</Format>
<OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://mapserver.inegi.org.mx/images/logoINEGI.JPG"/>

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-28 22:27:31 +0100 (Sun, 28 Oct 2018)
Build-Date:2018-10-28 21:33:32
Revision:14382
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14382 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1803 (17134)
Memory Usage: 788 MB / 1820 MB (416 MB allocated, but free)
Java version: 1.8.0_161-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080

Plugins:
+ InfoMode (34523)
+ Mapillary (v1.5.17)
+ MicrosoftStreetside
+ OpenStreetCam (167)
+ OpeningHoursEditor (34535)
+ PicLayer (34544)
+ RoadSigns (34553)
+ apache-commons (34506)
+ apache-http (34632)
+ buildings_tools (34572)
+ editgpx (34506)
+ ejml (34389)
+ fieldpapers (v0.5.0)
+ geotools (34513)
+ jaxb (34506)
+ jna (34633)
+ jts (34524)
+ opendata (34698)
+ openjfx
+ photo_geotagging (34576)
+ photoadjust (34684)
+ tag2link (34690)
+ tageditor (34560)
+ terracer (34584)
+ turnlanes-tagging (272)
+ turnrestrictions (34643)
+ utilsplugin2 (34506)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1

Last errors/warnings:
- W: Plugin openjfx benötigt Java Version 11. Die derzeitige Java Version ist 8. Du musst Java updaten, um dieses Plugin zu verwenden.
- E: Fehler - <html>Die Erweiterung MicrosoftStreetside benötigt zusätzlich die folgende Erweiterung:<ul><li>javafx</li></ul></html>
- W: No configuration settings found.  Using hardcoded default values for all pools.

[wiktorn]

In 14411/josm:

Skip unkown tags in WMS Getcapabilities

In Layer definition, if there is any other tag than ones that are interpreted,
move to the end of the tag, as it may be complex tag and affect further parsing.

Closes: #16940