Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16891 closed enhancement (fixed)

[Patch] Define custom browser on Windows

Reported by: iman Owned by: simon04
Priority: normal Milestone: 18.11
Component: Core Version: latest
Keywords: default internet browser windows Cc:

Description

Hi, can we set another default browser to open links? I use Firefox portable and would like to open links using it instead of default browser of Windows.

Attachments (2)

16891.patch (2.8 KB ) - added by simon04 6 years ago.
16891v2.patch (5.2 KB ) - added by simon04 6 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 by Klumbumbus, 6 years ago

Type: taskenhancement

comment:2 by Don-vip, 6 years ago

It should be possible to set portable firefox as default browser, see https://superuser.com/questions/287313/which-registry-keys-need-to-be-edited-to-change-the-default-browser

Can you please test?

comment:3 by Don-vip, 6 years ago

Owner: changed from team to iman
Status: newneedinfo

comment:4 by anonymous, 6 years ago

Not the original poster, but:
The need to set registry keys does defeat the "portable" aspect. I know many people are using portable apps "stationary", but JOSM and portable browser both can work truly portable, you can get java portable as well. For me, setting the path in JOSM directly is something I would love to see as well.

in reply to:  4 comment:5 by iman, 6 years ago

Replying to Don-vip:

It should be possible to set portable firefox as default browser

Thanks, I think it's possible, but it's not the problem. This PC is shared by others and I don't want they use my browser, or, by using their browser my history be easily accesible by them.

Replying to anonymous:

For me, setting the path in JOSM directly is something I would love to see as well.

This is exactly what I would love to do, too.

comment:6 by simon04, 6 years ago

Presumably you're using Windows? For Linux configurability, see #5108.

For Windows we could similarly implement an advanced setting browser.windows. If this preference is set, the specified program is launched in favour of the default.

comment:7 by iman, 6 years ago

Yes, I'm on Windows.
It's great if you implement that.

comment:8 by Don-vip, 6 years ago

Keywords: windows added
Summary: default internet browserDefine custom browser on Windows

comment:9 by simon04, 6 years ago

Owner: changed from iman to team
Status: needinfonew

by simon04, 6 years ago

Attachment: 16891.patch added

comment:10 by simon04, 6 years ago

Milestone: 18.11
Owner: changed from team to simon04
Summary: Define custom browser on Windows[Patch] Define custom browser on Windows

comment:11 by Don-vip, 6 years ago

I guess we can include it in 18.10 (no i18n strings).
Some remarks:

  • the if could be simplified to if PlatformManager.getPlatform() != null
  • we don't use star imports (import java.awt.*;)

by simon04, 6 years ago

Attachment: 16891v2.patch added

comment:12 by simon04, 6 years ago

I think we can simplify the code further, see attachment:16891v2.patch, but let's keep that for 18.11 to avoid introducing bugs in the last minute :).

comment:13 by simon04, 6 years ago

Resolution: fixed
Status: newclosed

In 14389/josm:

fix #16891 - Allow to override default web browser on Windows

Set the advanced preference key browser.windows to the browser executable.

comment:14 by Klumbumbus, 6 years ago

Any idea where this could be documented in the wiki for end users? Else I fear this feature will be used by only 1 person forever as nobody else knows about this preference key.

comment:15 by Don-vip, 6 years ago

Here: Help/Action/Help

EDIT: woops no, messed up things

Last edited 6 years ago by Don-vip (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.