Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16845 closed enhancement (fixed)

[PATCH] ChooseTrackVisibilityActionTest: fix for non-headless mode by properly mocking dialogs

Reported by: ris Owned by: team
Priority: minor Milestone: 18.10
Component: Unit tests Version:
Keywords: headless Cc:

Description

This one is a very lightly asserted test - there are a lot of opportunities here to use the ExtendedDialogMocker.act() method to do some more involved things with the options available in this dialog.

Based against r14336

​https://github.com/openstreetmap/josm/pull/42

Attachments (1)

v1-0001-ChooseTrackVisibilityActionTest-fix-for-non-headl.patch​ (6.0 KB ) - added by ris 6 years ago.

Download all attachments as: .zip

Change History (5)

by ris, 6 years ago

Attachment: v1-0001-ChooseTrackVisibilityActionTest-fix-for-non-headl.patch​ added

comment:1 by Don-vip, 6 years ago

Milestone: → 18.10

comment:2 by Don-vip, 6 years ago

I love bananas, but why do we need them in GpxLayerTest?

EDIT: wrote too fast, understood :)

Last edited 6 years ago by Don-vip (previous) (diff)

comment:3 by Don-vip, 6 years ago

Resolution: → fixed
Status: new → closed

In 14337/josm:

fix #16845 - ChooseTrackVisibilityActionTest: fix for non-headless mode by properly mocking dialogs (patch by ris)

comment:4 by ris, 6 years ago

Because it allowed us to test the string formatting of the dialog box title. Without a name for the layer I was otherwise asserting for the dialog title "Set track visibility for " which felt a bit silly.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.