Nested svg elements are displayed wrongly

[AdVerburg]

What steps will reproduce the problem?

1. Configure paint style ​​http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
2. Load this node into JOSM: node 4236434683
3. Look at the rendered icon.

What is the expected result?

an image with the two elements visible

What happens instead?

the image components are displayed stacked together.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-01 23:59:36 +0200 (Mon, 01 Oct 2018)
Revision:14289
Build-Date:2018-10-01 22:08:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14289 en_GB) Linux openSUSE Tumbleweed
Memory Usage: 487 MB / 1974 MB (200 MB allocated, but free)
Java version: 11+28-suse-1.1-x8664, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: java-11-openjdk:x86_64-11.0.0.0
Dataset consistency test: No problems found

Plugins:
+ Mapillary (v1.5.17)
+ OpeningHoursEditor (34535)
+ PicLayer (34544)
+ SeaChart (34237)
+ SeaMapEditor (34589)
+ apache-commons (34506)
+ apache-http (34632)
+ ejml (34389)
+ geojson (87)
+ geotools (34513)
+ graphview (34576)
+ jna (34633)
+ jts (34524)
+ measurement (34529)
+ opendata (34675)
+ reverter (34552)
+ turnrestrictions (34643)
+ utilsplugin2 (34506)

Tagging presets:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Presets_Hafen.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenSeaMap_bridge&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ <josm.pref>/Beacons.xml
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip

Map paint styles:
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT1_MapCSS.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip

Validator rules:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- W: Unkown setting type: integer
- W: Unkown setting type: integer
- W: Unkown setting type: integer
- W: No configuration settings found.  Using hardcoded default values for all pools.

This traffic_sign is just an example, the problem is with all combined traffic_signs.
A frequent used system of one pole with multiple signs attached.
With a single sign there is no display problem.
In LibreOffice-Draw, Firefox, Brave etc. the image is displayed correctly.

[AdVerburg]

screenshot traffic_sign=NL:C03,OB54

[AdVerburg]

file in the cache, (how JOSM the traffic_sign, in miniature, is supposed to display

[Don-vip]

Indeed svgSalamander output is:

[Don-vip]

In 14328/josm:

see #14319, see #16838 - update to svgSalamander 1.1.2

[Don-vip]

In 14331/josm:

see #14319, see #16838 - fix regressions introduced in svgSalamander 1.1.2

see ​https://github.com/blackears/svgSalamander/issues/29

[Don-vip]

Display is still broken with svgSalamander 1.1.2 (patched)

[Don-vip]

​https://github.com/blackears/svgSalamander/issues/31 created

[Don-vip]

In 14333/josm:

fix #16838 - render nested svg elements properly

see ​https://github.com/blackears/svgSalamander/issues/31

[michael2402]

Do we have a list of changes we applied to svgSalamander that are not in the original version (their master and their 1.1.2)?

[Don-vip]

There is not, I send patches upstream every time.

[Don-vip]

In 14334/josm:

see #14319, see #16838 - svgSalamander fix for CVE-2017-5617 was incomplete

See ​https://github.com/blackears/svgSalamander/issues/11

[AdVerburg]

Thanks, I'm very pleased.

[Don-vip]

In 14361/josm:

see #14319, see #16838 - fix another NPE / regression from svgSalamander 1.1.2 (causing unit test failure in DXF plugin)

see ​https://github.com/blackears/svgSalamander/pull/34