power=switchgear preset not displayed

[anonymous]

If you tag something with eg. ​osmwiki:Tag:power=terminal no description is shown about the object, like <icon> Man Made/Power/*.

[anonymous]

Please revise other power tags as well. Another example, switchgear. It already has an icon, I see it in tag adding window's history and in the editor.
I assumed if something has an icon (significant enough to have), it'll have a preset. Am I wrong?

BTW somehow the power=terminal preset appeared with translation.

[Klumbumbus]

Both terminal and switchgear are part of the internal presets.
attachment:terminal.png​
I don't understand what is missing.
(The only minor mistake I just noticed is the switchgear is rendered on nodes instead of on areas. That should be fixed.)

[Don-vip]

Please describe what you want.

[anonymous]

Klumbumbus, you have right. It has some kind of preset, but not what I meant to. I don't exactly know the terms you use for the different parts of the application but I try my best to explain.

I attached two pictures, hope it helps to understand the point.

As far as I know, this panel called "Tags" which was the original title of the issue, because it's an issue, not an enhancement.

Note that the red bordered clickable "preset" was not there at the moment of the report. It just appeared as I mentioned in comment:3.

[anonymous]

generator not displaying at all. The catenary_mast preset only appears if the tag is on a node (it should be on a node according to the OSM wiki). I'm not sure it's a bug with catenary_mast, but with generator definitely, it is.

Replying to Klumbumbus:

(The only minor mistake I just noticed is the switchgear is rendered on nodes instead of on areas. That should be fixed.)

This confused me because it gave me the impression it's the right type (node) otherwise the icons disappear on areas.

Also if I add the tag from the Presets>Man Made>Power>Terminal to a way, JOSM will warn me The preset Terminal cannot be applied since the selection is unsuitable. But on Tags panel I can add the terminal tag for any type of object, JOSM not checking anything. This is maybe another issue, but I'm trying to sum up everything which led me to this report.

In short:

1. JOSM not always checking known tags applicability before tagging
2. The rendering not always right

And after these, no further info provided on the UI, see

[Klumbumbus]

In 14299/josm:

fix #16792 - fix rendering of power=switchgear from node to area, add a warning; allow mulitipolygon for power=switchgear, generator:source=hydro and generator:source=tidal in presets

[Klumbumbus]

Replying to anonym:

generator not displaying at all.

As there are seperate presets for each generator:source you need to set this tag to get the links in the Tags/Membership dialog.

The catenary_mast preset only appears if the tag is on a node (it should be on a node according to the OSM wiki).

This sentence doesn't make sense.

Also if I add the tag from the Presets>Man Made>Power>Terminal to a way, JOSM will warn me The preset Terminal cannot be applied since the selection is unsuitable. But on Tags panel I can add the terminal tag for any type of object, JOSM not checking anything.

The presets help to use the right tags on the right objects but they don't offer every single rare tag. So in manual editing you can tachnically add all tags you want on all objects. This is the wanted behavior. (Running the validator helps to find the most common tagging mistakes.)

[anonymous]

Replying to Klumbumbus:

As there are seperate presets for each generator:source you need to set this tag to get the links in the Tags/Membership dialog.

This behaviour is a bit confusing (for me, at least) but okay.

This sentence doesn't make sense.

Yep, I couldn't edit after submitting the comment (maybe I should register). Sorry about that.

The presets help to use the right tags on the right objects but they don't offer every single rare tag. So in manual editing you can tachnically add all tags you want on all objects. This is the wanted behavior. (Running the validator helps to find the most common tagging mistakes.)

The idea behind it - why repair something after the action when you could do it before? You could say, OSM evolves this way. Users introduce new tags or use the old ones on new (until then not recommended) types of objects.
But then there are the presets, where you can only add tags for specified objects. Or this is like the presets is for the beginners and the built-in checks help them to make fewer mistakes, then the Tags/Membership dialogue is for more advanced users?

[Klumbumbus]

Replying to anonym:

Replying to Klumbumbus:

As there are seperate presets for each generator:source you need to set this tag to get the links in the Tags/Membership dialog.

This behaviour is a bit confusing (for me, at least) but okay.

Every power=generator should have the generator:source=* tag too. If you use one of the 17 generator presets, both tags are set automatically and everything is fine. If you manually set power=generator only, none of the 17 presets can be linked as it is unclear which one should be linked.

[anonymous]

Replying to Klumbumbus:

Every power=generator should have the generator:source=* tag too. If you use one of the 17 generator presets, both tags are set automatically and everything is fine. If you manually set power=generator only, none of the 17 presets can be linked as it is unclear which one should be linked.

That's right. Why is there rendered icon when generator:source is not added to the object (actually node)? When I mentioned the behaviour, I thought about this.