[PATCH] small fix for landuse + building warning

[naoliv]

With an object having landuse + building we see a warning saying suspicious tag combination - landuse together with landuse

Changing the order fixes this:

data/validator/combinations.mapcss

@@ -359 +359 @@
 way[highway][barrier],
 *[highway][waterway][waterway!=dam][waterway!=weir],
 way[highway][natural][natural!=ridge],
-*[landuse][landuse!=retail][building] {
+*[building][landuse][landuse!=retail] {
   throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
   group: tr("suspicious tag combination");
   assertNoMatch: "node highway=street_lamp natural=birds_nest";
@@ -522 +522 @@
   assertNoMatch: "way highway=primary lanes=3 oneway=-1";
   assertNoMatch: "way highway=primary lanes=4";
   assertMatch: "way highway=primary lanes=3";
-}
- No newline at end of file
+}

[Klumbumbus]

Argh. I fall into this trap again and again...

[Klumbumbus]

In 14275/josm:

fix #16783, see #16157 - fix validator warning message (modified patch by naoliv)

[naoliv]

On my first version I did use the tags in the same order that you committed.
But then I thought that it was visually better to group the similar tags side-by-side :-)

[Klumbumbus]

I don't know if the validator already works this way but if not then maybe on day it will skip the rule as soon as it finds the first non matching selector. This way the validation could be faster.
As landuse appears less often than building in the osm database I choose this order for best ("hypothetical") performance...

[stoecker]

You also can use 2.key (or not?).

[Klumbumbus]

Yes but there are 4 rules grouped together and this wouldn't fit to the other 3.

[anonymous]

@Klumbumbus If you mentioned validator speed... what about these tickets? #4626, #13805