#16682 closed enhancement (fixed)
New plugin features to support JavaFX 11
| Reported by: | Don-vip | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 18.09 |
| Component: | Core | Version: | |
| Keywords: | plugin javafx java11 | Cc: | stoecker |
Description (last modified by )
With the removal of JavaFX in Java 11 (#16047), the following features won't work anymore by default:
- core: MP3 support
- plugin StreetSide
- plugin matsim
I don't want to include openjfx directly in JOSM core just for MP3 support. A better way could be to include it in a plugin on which streetside and matsim plugin can depend.
Problems to resolve:
- JavaFX is based on native libraries, the plugin must install only those for the current platform. If I remember correctly the JOGL plugin does already something like this.
the plugin classes will have to be made available to JOSM core classloader for MP3 support => a new plugin property must be added for this (=> The packageCore-Export?)org.openstreetmap.josm.io.audio.fxwill have to move to this new plugin- the plugin will include OpenJFX 11. As we still need to support Java 8, the plugin must not be loaded on Java <= 10, for compatibility reasons => a new plugin property must be added for this (
Minimum-Java-Version?)
Attachments (0)
Change History (14)
follow-up: 3 comment:1 by , 6 years ago
comment:3 by , 6 years ago
Replying to stoecker:
the plugin classes will have to be made available to JOSM core classloader for MP3 support => a new plugin property must be added for this (Core-Export?)
Why can't the plugin provide the related functionality instead of providing required base classes (like the input file support)? That approach sounds strange.
Yes, it's a simpler, safer and more elegant solution. Thanks.
comment:4 by , 6 years ago
| Description: | modified (diff) |
|---|
comment:8 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
openjfx plugin released in [o34624]. Needs JOSM r14234. This is the biggest JOSM plugin ever made (85 Mb!)
comment:9 by , 6 years ago
PR for matsim plugin: https://github.com/matsim-org/josm-matsim-plugin/pull/97
Why can't the plugin provide the related functionality instead of providing required base classes (like the input file support)? That approach sounds strange.