#16320 closed enhancement (fixed)
increase contrast of delete icon
Reported by: | aceman | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 18.06 |
Component: | Core | Version: | latest |
Keywords: | contrast icon | Cc: |
Description
In the relation editor dialog the delete icons (all of them: delete relation, delete tag, delete relation member) have changed their appearance recently. They are grey trashcan, but there is no difference when the button is enabled and when disabled. The icon looks like permanently disabled, even when it isn't.
This could be related to some GTK changes in Linux. I'm on GTK 3.22.30
Attachments (3)
Change History (23)
comment:1 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
comment:2 by , 7 years ago
Added the screenshot. It shows a state where all the 3 icons are enabled (mousehover on them shows tooltips and the button outline) and can be clicked on. But the grey appearance looks like they are disabled. There is no color difference between enabled and disabled state. For other icons, the difference is very visible.
comment:3 by , 7 years ago
It appears very clear the buttons are enabled. Can you please post also a screenshot where they're disabled so I can compare?
comment:4 by , 7 years ago
The other buttons are fine. I talk only about the "delete" (trash can) icon. I say that its enabled appearance is so gray as it almost looks as if disabled. Screenshot incoming.
by , 7 years ago
Attachment: | bug-JOSM-relation-delete-disabled.png added |
---|
screenshot of disabled icon
comment:5 by , 7 years ago
I mean if the trash can icon could get any more colors or contrast so that it can immediately be seen if it is enabled or not.
comment:6 by , 7 years ago
Keywords: | contrast icon added |
---|---|
Summary: | delete icon in relation editor looks permanently disabled on Linux → increase contrast of delete icon |
Type: | defect → enhancement |
OK. For me this is not a problem, I can easily spot the difference. Patched version of svg icon is welcome.
comment:7 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | needinfo → new |
by , 7 years ago
Attachment: | delete.svg added |
---|
comment:11 by , 7 years ago
Milestone: | → 18.05 |
---|
comment:12 by , 7 years ago
Milestone: | 18.05 → 18.06 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Apparently the icon is not displayed correctly within JOSM.
comment:13 by , 7 years ago
It seems this svg code is not supported by JOSM or removed by the svg optimizer:
<filter style="color-interpolation-filters:sRGB;" inkscape:label="Lightness-Contrast" id="filter4720"> <feColorMatrix values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0" id="feColorMatrix4718" result="fbSourceGraphic" /> <feColorMatrix result="fbSourceGraphicAlpha" in="fbSourceGraphic" values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0" id="feColorMatrix924" /> <feColorMatrix id="feColorMatrix926" values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0" in="fbSourceGraphic" /> </filter> <filter style="color-interpolation-filters:sRGB;" inkscape:label="Lightness-Contrast" id="filter4724"> <feColorMatrix values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0" id="feColorMatrix4722" result="fbSourceGraphic" /> <feColorMatrix result="fbSourceGraphicAlpha" in="fbSourceGraphic" values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0" id="feColorMatrix928" /> <feColorMatrix id="feColorMatrix930" values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0" in="fbSourceGraphic" /> </filter>
comment:15 by , 7 years ago
I won't have time to dig into this problem, and the author does not really maintain the library... Can you change the colors without filters?
Changed in r13837. Can you please attach a screenshot? The difference is clear on Windows.