autofix for almost square check for buildings is suboptimal

[Klumbumbus]

What steps will reproduce the problem?

1. validate attachment:6_node_building.osm​
2. click autofix
3. repeat the above steps 24 times until the validator is finally happy

Even for simple 4 node buildings up to 4 consecutive validation steps are required. (attachment:4_node_building.osm​)

The reason is that always only one node is moved. While this makes sense in some cases, more often this creates a new almost rectangular angle. Also it is always only one angle per building flagged by the validator.

The goal should be that after the autofix on a building this warning doesn't appear again and all almost rectangular angles are fixed.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-05-09 21:51:30 +0200 (Wed, 09 May 2018)
Build-Date:2018-05-10 01:33:33
Revision:13722
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13722 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1709 (16299)
Memory Usage: 1315 MB / 3641 MB (890 MB allocated, but free)
Java version: 1.8.0_171-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest-mehr-RAM.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=1024m,4096m, -Djnlpx.splashport=57455, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

[Klumbumbus]

Another case to consider: validate the left building in attachment:connected_buildings.osm​. After some corrections in the lower left corner (which are fine) the validater starts moving nodes which are used by the other building too making the other building non rectangular.

[Don-vip]

This test becomes too complex. I think I'll restrict it to isolated buildings (report nodes used by only one way).

[Don-vip]

In 13738/josm:

see #16280 - downgrade test to information level until autofix works correctly

[Don-vip]

@marxin: making the autofix work correctly will require significant work and I don't have time for this, can you please see if you find a solution that:

• flags all buildings angles at once in a single warning occurrence
• provide an autofix that makes the "almost" square angles square but does not touch the other angles

If we have that the test can be set at warning level but otherwise it causes too much distraction.

[Don-vip]

Ticket #16286 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #16332 has been marked as a duplicate of this ticket.