Modify ↓

Opened 16 years ago

Closed 16 years ago

#1624 closed enhancement (fixed)

[PATCH] use consistent line endings in GpxWriter

Reported by: h-a-l-9000@… Owned by: framm
Priority: trivial Milestone:
Component: Core Version:
Keywords: Cc:

Description

When opening a gpx file written by GpxWriter with i.e. Windows Notepad the formatting is broken. The small patch makes them consistent.

Attachments (1)

gpxwriter_lineending.diff​ (653 bytes ) - added by h-a-l-9000@… 16 years ago.

Download all attachments as: .zip

Change History (5)

by h-a-l-9000@…, 16 years ago

Attachment: gpxwriter_lineending.diff​ added

comment:1 by Henry Loenwind, 16 years ago

Priority: minor → trivial
Summary: Patch: use consistent line endings in GpxWriter → [PATCH] use consistent line endings in GpxWriter
Type: defect → enhancement

comment:2 by anonymous, 16 years ago

this will save \r\n on windows and \n on Linux (different on MacOS)
It's the desired behaviour?
Should always write \n or write platform specific line-ending character?

in reply to:  2 comment:3 by h-a-l-9000@…, 16 years ago

Replying to anonymous:

this will save \r\n on windows and \n on Linux (different on MacOS)
It's the desired behaviour?
Should always write \n or write platform specific line-ending character?

Currently there are both println(...) and print("\n") used for writing the file. The patch is supposed to unify it.

The parsers shouldn't bother either way, it's just a cosmetic error in the rare case that a human opens such a file.

comment:4 by stoecker, 16 years ago

Resolution: → fixed
Status: new → closed

Fixed in r1164.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.