Bad validation & fixes around unisex toilets

[rorym]

The JOSM validator is incorrect for toilets w.r.t. unisex. ​Unisex toilet mean a toilet which is used/usable by all genders, not just male and female, i.e. one facility/room used by all genders.

• An amenity=toilets with the tags unisex=yes male=yes female=yes causes a validation error, with a suggested fix of removing the male and female tags. But if a toilet facility had 3 separate types of toilets (male, female, and unisex), then this "fix" would change the meaning to mean that there is only one type of toilet, the unisex one.

• An amenity=toilets with the tags unisex=yes male=yes and no female tag causes a validation error, or one with unisex=yes female=yes and no male tag.

There are some instances where "unisex" means "all genders are served together", like hairdressers, or clothes shops. But there are other where it means "there is no segregation", which is different from "there is a male thing and a female thing and they are separated". A unisex toilet is not the same as a male toilet and a female toilet.

I don't know of any toilets which has 3 kinds (or unisex and one other), but the world is big and trans rights are ever improving, so it might happen. But to mark things as errors, and "fix" the data by breaking the data is wrong. As I fix, I suggest removing the validation checks which look at the combination of male/female/unisex.

[Klumbumbus]

In 13102/josm:

see #13144, fix #15536 - limit male/female/unisex test to hairdressers