Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#15424 closed enhancement (fixed)

Imagery Offset Database > default windows install

Reported by: Violaine_Do Owned by: team
Priority: normal Milestone: 17.10
Component: Installer Windows Version:
Keywords: Cc: v_doutreleau@…, m_noblecourt@…

Description

As imagery sources grow, which are not always (almost never) positionned uniformly, and we more and more need to uniform contributions based on standard offset, especially during mapathons, could help to have this plugin installed by default...No?
(imagery offset database plugin : ​https://wiki.openstreetmap.org/wiki/Imagery_Offset_Database)

Attachments (1)

josm_iodb.png​ (19.7 KB ) - added by Don-vip 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Don-vip, 8 years ago

comment:2 by Don-vip, 8 years ago

Milestone: → 17.10

comment:3 by Don-vip, 8 years ago

Resolution: → fixed
Status: new → closed

In 12979/josm:

fix #15424 - include imagery_offset_database in default plugins embedded by Windows installer

comment:4 by Don-vip, 7 years ago

I messed up:

##################################################################
### create the josm-installer-13053.exe with makensis
!undef: "JOSM_SEC_IMAGERY_OFFSET_DB_PLUGIN" not defined!
Error in macro JOSM_MACRO_LANGSTRING_INSERT on macroline 2
Error in macro JOSM_MACRO_LANGUAGEFILE_END on macroline 16
Error in macro JOSM_MACRO_INCLUDE_LANGFILE on macroline 3
Error in script "josm.nsi" on line 102 -- aborting creation process

comment:5 by Don-vip, 7 years ago

In 13054/josm:

see #15424 - add missing NSIS macro

comment:6 by Don-vip, 7 years ago

In 13055/josm:

see #15424 - fix encoding (NSIS files are not UTF-8)

by Don-vip, 7 years ago

Attachment: josm_iodb.png​ added

comment:7 by Don-vip, 7 years ago

OK this looks good now:


comment:8 by Klumbumbus, 7 years ago

Did you forget to update TestedVersion?

comment:9 by Don-vip, 7 years ago

No, this is intentional. The two commits only concern the code producing this Windows installer and not JOSM itself. We can keep r13053 as promoted version (last JOSM core version).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.