transform gui icons to svg

[Klumbumbus]

Since we have an icon scaling on hidpi screens now (ticket:9995#comment:110) it would be nice to transform all icons to svg. Preset icons are already all svg (#13357)

Here are the current numbers: 60 svg icons and 270 png icons. This statistic excludes the folders images/presets, images/icons (only potlatch icons), our logo (which exists 6 times as png versions additionally to svg) and two special cases (lambert maps).

I think we could ask the osm community for help on this subject.

There are two possibilities:

• transform the 270 png to svg
• create a whole new icon set with an consistent look

For the second, there was already such an (not fully complete) dataset, see JOSM themes:

---

progress since creation of this ticket:

^{(numbers of svg icons not recorded between 09/2017 and 12/2019)}

---

end result on 2020-08-17:

In total:

• 1160 svg icons (821 presets/mappaint style + 339 GUI)
• 124 potlatch mappaint style png icons
• 6 png icons of the logo in different sizes

[Don-vip]

Replying to Klumbumbus:

For the second, there was already such an (not fully complete) dataset, see JOSM themes. Sadly the links and screenshoots in the forum are no longer available. Maybe we could recover them.

I remember very well. Felis was one of the finalists for the LogoContest and he almost won. It was really a hard thing to choose between the two final designs. I love what he did, too bad we can't have two logos :D

I just sent him an e-mail to let it know about this ticket.

[Felis Pimeja]

FYI, as long as Dropbox has changed sharing mechanics, theme files are now available at:

​https://drive.google.com/file/d/0BzTaubB85qV2cEFPcnA2UTBZbG8/view?usp=sharing

And I'm searching for the source files now.

[bastiK]

Our current icons are partly based on the ​Tango icon theme, which has an svg set. See also ​GNOME set (based on Tango) with icons for download, delete and others.

[bastiK]

Replying to Felis Pimeja:

FYI, as long as Dropbox has changed sharing mechanics, theme files are now available at:

​https://drive.google.com/file/d/0BzTaubB85qV2cEFPcnA2UTBZbG8/view?usp=sharing

And I'm searching for the source files now.

Wow, it's pretty good! I like the black-red color scheme.

[Don-vip]

See also new default theme for Gnome 3: ​https://git.gnome.org/browse/adwaita-icon-theme/

[stoecker]

The colorschemes like black-red do look good, but in my eyes they aren't good as the standard design. This should still be colorful (when possible with a bit more unified style :-).

[bastiK]

How to move forward?

I noticed that some of the vector icons don't scale well down to very small sizes:

Current download icon (24x24px):

Scalable image, rendered at 48x48 px:

Scalable image, rendered at 24x24 px

Just replacing the current download.png by download.svg would be nice for HiDPI users, but clearly is a loss in image quality for everyone else. My conclusion so far is that some scalable images are designed with a certain minimum size in mind and will just look bad when scaled below that limit. This affects some icons more than others, the undo/redo image scales fine for example.

Possible solutions:

• Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
• Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

[Don-vip]

Replying to bastiK:

Possible solutions:

• Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
• Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

[stoecker]

Replying to Don-vip:

Replying to bastiK:

Possible solutions:

• Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
• Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

• Change the icons, so that the vanishing elements (usually some sort of boundaries) are wider, so they don't vanish.

E.g. see point 7 here: ​​https://www.creativebloq.com/how-to/10-golden-rules-for-responsive-svgs

[bastiK]

Replying to stoecker:

Replying to Don-vip:

Replying to bastiK:

Possible solutions:

• Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
• Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

• Change the icons, so that the vanishing elements (usually some sort of boundaries) are wider, so they don't vanish.

E.g. see point 7 here: ​​https://www.creativebloq.com/how-to/10-golden-rules-for-responsive-svgs

This is more the job of a graphics designer that that of a programmer. Take the download icon posted above as an example: How can you modify the SVG without loss of quality in either the 24 px (top) or the 48 px rendering?

Anyway, if we implement option 2, it is still possible to improve the SVGs one by one, as suggested.

[stoecker]

This is more the job of a graphics designer that that of a programmer. Take the download icon posted above as an example: How can you modify the SVG without loss of quality in either the 24 px (top) or the 48 px rendering?

Anyway, if we implement option 2, it is still possible to improve the SVGs one by one, as suggested.

Sure.

But the option 2 means a workaround which again will live MANY years. I personally would rather accept slightly worse low-zoom icons than another workaround.

[stoecker]

P.S. We already had 24x24 menu icons. Maybe default simply should be 30x30 nowadays even for normal screens?

[floscher]

Proposal for SVG icons for the status line

[floscher]

Animated comparison between the statusline icons (current and proposed)

[floscher]

I propose to replace the icons in the statusline with SVG versions.
Below you see a comparison between the current icons (PNG, 18×18 pixels, scaled to 180×180), then how my proposed SVG icons look when converted to a 18×18 raster image scaled up to 180×180 pixels. And finally how the SVG icons look as 180×180 pixel image.

(https://josm.openstreetmap.de/attachment/ticket/15240/statusline-svg.patch is the corresponding patch)

[floscher]

Current appearance of the statusline icons

[floscher]

Proposed appearance of the statusline icons

[floscher]

Before:

After:

[stoecker]

In 13363/josm:

see #15240 replace statusline png icons with svg variants by floscher, set mime-types for many images

[stoecker]

No need to do such a impressive presentation. :) The new images and a before/after is enough. We plan to replace all PNG images anyway.

[Don-vip]

Nice! thank you :)

[Hb---]

References to the old PNG-files are still used in the wiki, please see https://josm.openstreetmap.de/wiki/Help/StatusBar
Wiki has been updated.

[bastiK]

In 13375/josm:

see #15240 - replace image for geoimage layer with svg version (from Tango icon project)

[stoecker]

In 13376/josm:

see #15240 - set proper mime-type

[Klumbumbus]

some icons replaced in #16159

[floscher]

Replacement for misc/black_x.png

[floscher]

Replacement for misc/green_check.png

[floscher]

Replacement for misc/green_check.png

[floscher]

Here are four more:

By the way: Can the icons dialogs/valid and misc/check_large also be replaced by the checkmark above or is there a need for three different green checkmarks?

[stoecker]

In 13613/josm:

see #15240 - new SVG icons

[stoecker]

I didn't replace misc/check_large. It is used in the upload dialog and I'd say it looks better there than the boxy green_check.

[Klumbumbus]

interim result: 246 png icons left :)

[stoecker]

Hmm, are sure that's right? The green check is svg and the large is missing and some icons are in two sizes and 3 blue checkmarks?

[stoecker]

BTW The WMS/TMS related icons are all ugly.

Better ones would be fine.

[Klumbumbus]

It seems you accidently moved the large green check to nodist instead of .

[Klumbumbus]

in the screenshot I scaled all icons to 24px. multiple icons appear when there are different sizes available, e.g.

should be unified when replayed by svg

[Klumbumbus]

Code of the screenshot. Can be used here in wiki with comment preview feature. (But takes a bit to load all images which is why I made the screenshot)

edit: code outdated and removed

[stoecker]

Replying to Klumbumbus:

It seems you accidently moved the large green check to nodist instead of .

Ooops. Can someone please fix this before next build?

[Klumbumbus]

could be a meme: JOSM user level expert: knows the difference between the upload icon and the upload selection icon

[Klumbumbus]

In 13615/josm:

see #15240 - fix moved icons

[Don-vip]

Replying to Klumbumbus:

could be a meme: JOSM user level expert: knows the difference between the upload icon and the upload selection icon

hahaha :D

[floscher]

Replacement for preferences/separator.png

[anonymous]

Replacement for data/closedway.png

[floscher]

Replacement for data/multipolygon.png

[floscher]

Replacement for data/node.png

[floscher]

Replacement for data/sequence.png

[floscher]

Replacement for data/way.png

[floscher]

Replacement for data/sequence.png

[floscher]

Replacement for aligncircle.png

[floscher]

Replacement for dialogs/taginfo.png

[floscher]

And some more:

The last one I changed, because the line around really should be the circle (I think), not the ways connecting the nodes. So I changed the color (if you want some other color, we could change it). And I made the points more irregular to emphasize that the nodes are not evenly distributed around a circle, but only moved to the closest point on a circle.

[stoecker]

Hmm. taginfo does still not look nice. It's the website favicon, but looks ugly. Adding the world logo from the website behind the ti?

[anonymous]

Replying to stoecker:

Hmm. taginfo does still not look nice. It's the website favicon, but looks ugly. Adding the world logo from the website behind the ti?

Don't know if that would work at this resolution (16x16). Probably has to be something simpler.

[Don-vip]

Maybe just frame it with something like

[stoecker]

Or let the t look a bit like a "tag"?

[stoecker]

​https://www.google.de/search?q=icon+tag
They all have a hole inside.
Or simply such a tag with an i or ti inside. When we have something better we'd need to ask Jochen if he likes it.

[Klumbumbus]

Or we pixel align the current taginfo icon a bit to make it look a bit sharper.

Regarding I agree that there should be a circle in the icon instead of a pentagon to better illustrate the align in circle action. However the irregular pattern destroys this illustration again a bit in my opinion. And if you select a way and hit O then the nodes are indeed evenly distributed. The thin light green is pretty hard to recognize on a light background too.

Currently Help/Action/AlignInCircle and Help/Action/CreateCircle use the same icon. While the align action works on single nodes too, the create action always creates a way, so probably the black way lines shouldn't be removed from the create action icon.

My suggestion (but I didn't test how it looks): a circle and even distributed nodes for both icons; for the create action the circle is black and for the align action grey or another color (but a bit darker than the light green).

[floscher]

New version for aligncircle.png

[floscher]

Here's my draft for an alternative TagInfo logo:

And another version of aligncircle: .

@Klumbumbus: Actually it depends on what you select if the nodes distribute equally around the circle: When selecting a way, they do. When selecting only the nodes, they do not distribute evenly around the circle. I thought they were always only jumping to their nearest position on the circle, but it seems to be more complicated.
Anyway, I now changed the icon to show evenly distributed nodes, also for aesthetic reasons. Also the color is now grey. I think a second version in black would be too much, especially because they are too similar… Not that in the end your joke about the download icons really becomes a meme 😉

[stoecker]

Replying to floscher:

Here's my draft for an alternative TagInfo logo:

I contacted Jochen and asked for his opinion.

[stoecker]

In 13630/josm:

see #15240 - new SVG icons made by floscher

[floscher]

Replacement for apply.png

[Klumbumbus]

(replacement for gray_check.png can be derived from the green and blue one too)

[floscher]

Replacement for misc/gray_check.png

[floscher]

You might consider renaming gray_check.svg to grey_check.svg. Next to it there is the file grey_x.png, which uses the other spelling.

[Hb---]

On Plugins the images /browser/trunk/images/misc/black_x.png and ../green_check.png are missing now.

They are placed by a script in the last column to indicate if a plugin needs a restart. The alt parameters for the images are localized. This script needs to be modified.

Replacing the former PNG images with their SVG counterparts will make the page display in the Help Browser worse, because that Browser can't properly resize images currently. Simple characters like ✓ and ✕ may give the same information.

[Klumbumbus]

Did someone fix this already? The icons are displayed fine for me. (I remember that i fixed wiki:JavaBugs and wiki:OldJavaBugs 5 weeks ago and I think that the Plugins page was already working fine a that point.)

Replying to Hb---:

Replacing the former PNG images with their SVG counterparts will make the page display in the Help Browser worse, because that Browser can't properly resize images currently.

That shouldn't be a problem anyway in this case as these two icons have a small base size and shouldn't be resized.

[stoecker]

Replying to Klumbumbus:

Did someone fix this already?

Yes.

[Don-vip]

In 13832/josm:

fix #5603, see #5256, see #15240 - add first/last buttons for geoimage dialog. Fixed shortcuts. Switch to SVG icons taken from ​https://commons.wikimedia.org/wiki/GNOME_Desktop_icons#Navigation

[Don-vip]

In 13837/josm:

see #15240 - convert more GNOME icons to SVG versions. Taken from ​https://commons.wikimedia.org/wiki/Category:GNOME_Desktop_icons

[Klumbumbus]

duplicate icons:

[Don-vip]

In 13844/josm:

see #15240 - remove duplicated icons

[Don-vip]

Replying to stoecker:

I contacted Jochen and asked for his opinion.

any news?

[Don-vip]

Another thing: the icon warnings scripts says bookmark.svg is not used, but it is:

        static ImageIcon getDefaultIcon() {
            return ImageProvider.get("dialogs", "bookmark", ImageSizes.SMALLICON);
        }

[stoecker]

TagInfo image from Jochen Topf

[stoecker]

Jochen sent me this image which he also uses (which is to large for our purpose), but didn't answer whether he likes or does not like the small icon.

I'd say we simply use floscher's icon in JOSM.

[stoecker]

In 13857/josm:

see #15240 - detect another type of ImageProvider calls for in image check script

[Don-vip]

It's nice but the contrast should be increased, it's hard to view the tag on grey background:

[floscher]

Updated TagInfo logo with more contrast

[floscher]

Preview of the context menu with TagInfo logo

[floscher]

Should now be better:

[Don-vip]

In 13860/josm:

see #15240 - use new taginfo icon (by floscher)

[Klumbumbus]

In 13862/josm:

see #15240 - new SVG icons made by floscher

[Klumbumbus]

In 13863/josm:

see #15240 - add svg mime type

[floscher]

Replacements for some icons in the directory images/cursor/modifier:

As well as these two in images/cursor:

[Don-vip]

In 13871/josm:

see #15240 - switch 12 cursor icons to SVG (by floscher)

[Klumbumbus]

Did you accidently not pixel align the red node symbols at these three icons?

[floscher]

Replying to Klumbumbus:

Did you accidently not pixel align the red node symbols at these three icons?

Yes, good catch, thank you! I corrected the icons. And I also made a small modification to the other select-modifiers, which shouldn't change the appearance in JOSM, but in some image viewing programs (e.g. Gimp) the dashed line should display correctly.

[Klumbumbus]

In 13874/josm:

see #15240 - update 9 SVG icons made by floscher, add svg mime type

[Don-vip]

@bastiK @michael2402 The test MapCSSRendererTest.testRender[area-fill-image] is both failing and slower on Jenkins since r13862, could you please have a look? Surprisingly the test is OK on my machine.

[Klumbumbus]

add progress chart to ticket description, little motivation ;)

[Don-vip]

@bastiK @michael2402

up? Is the test failing for you?

[Don-vip]

In 13904/josm:

see #15240 - drop png suffix in renderer unit tests

[Don-vip]

In 13909/josm:

see #15240 - update renderer unit test reference image

[floscher]

replacement for misc/close.png

[floscher]

replacement for combineway.png

[floscher]

replacement for misc/grey_x.png

[floscher]

replacement for joinnodeway.png

[floscher]

replacement for misc/minimized.png

[floscher]

replacement for misc/normal.png

[floscher]

replacement for misc/rectangle.png

[floscher]

replacement for reorder.png

[floscher]

a few more SVG icons:

before	after

[floscher]

replacement for downloadalongtrack.png

[floscher]

replacement for download_along_way.png

[Klumbumbus]

Where are grey_x, rectangle and reorder used in JOSM? I can't find them right now.

[floscher]

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/NotificationManager.java?rev=14153#L214

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/ImageMarker.java?rev=14153#L51

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java?rev=15333#L876

[floscher]

I'm currently looking at icons in https://josm.openstreetmap.de/browser/josm/trunk/images/cursor/modifier?rev=15558 and found that some of them have a white outline that is not completely opaque. But the icons are not really consistent on how opaque/transparent that white outline is. For example https://josm.openstreetmap.de/browser/josm/trunk/images/cursor/modifier/joinway.png?rev=15558 has opacity values 196, 204 and 231 (of 255) for different parts of the icon.

Should these white outlines have a bit of transparency? If yes how much?

[Klumbumbus]

I think transparency is probably not needed on these outlines. At least on stadard dpi screens I guess you don't see an difference between full white and such a slight transparency at all. Not sure about hi dpi screens.

[Klumbumbus]

In 15571/josm:

see #15240 - new SVG icons made by floscher

[Klumbumbus]

Thanks for the icons.

I couldn't figure out how to get an Image marker layer, so I hope this icon works fine ;)

[floscher]

some more SVG icons:

before	after
		cursor/modifier/addnode
		cursor/modifier/add_node_lock
		cursor/modifier/create_note
		cursor/modifier/joinnode
		cursor/modifier/joinway
		cursor/modifier/lock
		cursor/modifier/mode
		cursor/modifier/parallel
		cursor/modifier/parallel_add
		cursor/modifier/parallel_remove
		mapmode/addnote
		mapmode/addsegment
		markers/audio-tracer
		markers/Bridge
		markers/Crossing

[Klumbumbus]

In 15577/josm:

see #15240 - new SVG icons made by floscher

[Klumbumbus]

In 15578/josm:

see #15240 - new SVG icons from ​https://commons.wikimedia.org/wiki/File:Departements_LambertCC9Zones.svg and ​https://commons.wikimedia.org/wiki/File:Departements_Lambert4Zones.svg (CC0 licensed)

[Don-vip]

There's a new icon warning for Departements_Lambert4Zones.svg: Style starts with minus: -inkscape-font-specification:DejaVu Sans

[Klumbumbus]

In 15585/josm:

see #15240 - fix icon

[Stereo]

​https://www.sjjb.co.uk/mapicons/contactsheet has a lot of icons that we use in the potlatch2 theme - ​https://www.sjjb.co.uk/mapicons/svg/accommodation/alpinehut.svg could replace resources/images/icons/accommodation_alpinehut.n.16.png etc.

[Stereo]

​http://osm-icons.org/wiki/Icons has more of the same icons

[Klumbumbus]

This ticket is about the icons of the programm, not the mappaint style(s). (The JOSM default mappaint style is already full svg. I personally don't plan to invest time in the potlatch mappaint style.)

[tgertin]

Klumbumbus, in the JOSM wiki Introduction, the images do not work. Do you think you can get them to work? Thanks

[Klumbumbus]

Replying to tgertin:

Klumbumbus, in the JOSM wiki Introduction, the images do not work. Do you think you can get them to work? Thanks

Currently all icons in the wiki which refer to the josm source code are not displayed. It will be fixed soon. See #18845.

[Stereo]

Replying to Klumbumbus:

This ticket is about the icons of the programm, not the mappaint style(s). (The JOSM default mappaint style is already full svg. I personally don't plan to invest time in the potlatch mappaint style.)

I really like the Potlatch style. Should I open a separate ticket for it?

If I'd like to work on this, how should I submit my patch?

[stoecker]

In this case a zip file with the new images and a small shell script doing the necessary svn commands would probable be the best idea (old icons moved with "svn mv" to nodist directory).

[Klumbumbus]

Replying to Stereo:

Should I open a separate ticket for it?

Yes.

[Klumbumbus]

Anyone knows why some toggle dialogs have that scrollbar frame and some not? Most of the toggle dialogs are kind of lists which may be scrollable. Maybe we could unify this and drop the frame?
With frame are: Selection, Relations, Mini map, Command Stack, Authors, Relation Toolbox

[Klumbumbus]

Is there an easy way to find all references to an icon in the source code?

[skyper]

menu windows screenshot

[skyper]

Replying to Klumbumbus:

Anyone knows why some toggle dialogs have that scrollbar frame and some not?

Do not really understand, are you talking about the toggle dialog or the menu "Windows". What has your screenshot to do with your question ?

My menu looks a bit different:

[Klumbumbus]

I mean this "frame" around some icons:

[skyper]

Replying to Klumbumbus:

I mean this "frame" around some icons:

Thanks got it, you are talking about the icons in the windows menu.
+1 for removing but maybe we need new icons, e.g. I am not sure if the relation icon is the best for the relation list. Similar is true for the selection list.

[Klumbumbus]

Replying to skyper:

you are talking about the icons in the windows menu.

These are the same as in the toggle dialogs!?

[Stereo]

Replaces resources/images/dialogs/mappaint/pl2_small.png

[Stereo]

I've added a p2.svg as attachment that replaces resources/images/dialogs/mappaint/pl2_small.png

Original: 4 KB
SVG: 627 bytes

Hey, it's still something :)

[Klumbumbus]

In 16059/josm:

see #15240 - change Potlatch2 icon to svg, icon provided by Stereo

[Klumbumbus]

Replying to Stereo:

Hey, it's still something :)

Thanks! (I needed to adjust the svg code a bit as JOSM was not able to display it.)

[Stereo]

I haven't found an easy way of displaying all the images in one, like in the original ticket. In the end, I found this, which also adds the filename:

find . -not -path './nodist/*' -not -path '*/images/icons/*' -not -path '*/images/logo*' -not -path './test*' -not -path './native/linux/*' -name \*.png | cat - <(echo -ne "josm-all-png.PNG\0") | xargs montage -label '%f' -tile 6x

Edit: excluded nodist

[Stereo]

PNG files in the JOSM source tree on 2020-03-30

[Klumbumbus]

You can exclude the nodist folder.

[Stereo]

Original vector files

​https://commons.wikimedia.org/wiki/File:Process-stop.svg is resources/images/cancel.png ✔️

​https://commons.wikimedia.org/wiki/File:Document-save.svg is resources/images/save.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Document-save-as.svg is resources/images/save_as.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg is ./resources/images/dialogs/settings.png ✔️ icon removed

​https://commons.wikimedia.org/wiki/File:Dialog-error.svg is resources/images/data/error.png ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-emblem-web.svg is resources/images/help/internet.png ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-text-html.svg is resources/images/markers/web.png ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-document-save.svg is resources/images/download.png (and the source of many other download icons, as mentioned above) ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Gtk-refresh.svg is resources/images/restart.png (but ​https://commons.wikimedia.org/wiki/File:View-refresh-2.svg could also be used) ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg is ./resources/images/dialogs/zoom-best-fit.png (see zoom.png) ✔️

​https://commons.wikimedia.org/wiki/File:Mail-mark-junk-2.svg is both ./resources/images/purge.png and ./resources/images/data/purge.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg is resources/images/view-fullscreen.png (see below for fullscreen-revert) ✔️

Near matches

​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg is resources/images/view-fullscreen-revert.png with all the arrows turned 180 degrees. ✔️

​https://commons.wikimedia.org/wiki/File:Emblem-system.svg can replace resources/images/data/relation.png ✔️

​https://commons.wikimedia.org/wiki/File:System-software-update.svg can replace resources/images/updatedata.png ✔️

​https://commons.wikimedia.org/wiki/File:Text-x-generic_with_pencil.svg can replace resources/images/dialogs/edit.png . The original looks very gnome-ish, but I couldn't find the source. ✔️

​https://en.wikipedia.org/wiki/Java_(programming_language)#/media/File:Java_programming_language_logo.svg can replace resources/images/java.png ✔️

​https://commons.wikimedia.org/wiki/File:Document-open.svg can replace resources/images/open.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Emblem-notice.svg can replace resources/images/info.png ✔️

​https://github.com/GNOME/gimp/blob/mainline/icons/Color/24/gimp-tool-free-select.svg can replace resources/images/mapmode/rope.png ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg is probably the source for resources/images/mapmode/zoom.png - there is no empty magnifying glass in the gnome icons. Otherwise ​https://commons.wikimedia.org/wiki/File:System-search.svg can also be used. In that case, zoom-best-fit.png should be ​https://commons.wikimedia.org/wiki/File:View-zoom-fit.svg. ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-dialog-warning.svg can replace both resources/images/warning-small.png and resources/images/data/warning.png ✔️

​https://commons.wikimedia.org/wiki/File:Edit-find.svg can replace resources/images/dialogs/search.png ✔️ other one used

Improvements

​https://commons.wikimedia.org/wiki/File:Input-keyboard.svg looks a lot like resources/images/preferences/shortcuts.png but ​https://commons.wikimedia.org/wiki/File:Preferences-desktop-keyboard-shortcuts.svg would be a much nicer replacement ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop.svg can maybe replace resources/images/preference.png although it's not great, especially on low zoom. Maybe ​https://commons.wikimedia.org/wiki/File:Preferences-system.svg would be a better fit. ✔️ other icon used

resources/images/preferences/reset.png is ​https://commons.wikimedia.org/wiki/File:Gnome-go-jump.svg flipped, but ​https://commons.wikimedia.org/wiki/File:Edit-undo.svg could be a better one ✔️

resources/images/data/user.png is ​https://commons.wikimedia.org/wiki/File:Gnome-system-users.svg but ​https://commons.wikimedia.org/wiki/File:System-users-3.svg is nicer ✔️

​https://commons.wikimedia.org/wiki/File:Gnome-applications-utilities.svg (swiss army knife) or ​https://commons.wikimedia.org/wiki/File:Applications-development.svg (helmet) could replace resources/images/expert.png (Einstein) ✔️ other icon used

I like ​https://commons.wikimedia.org/wiki/File:Red_bug.svg to replace resources/images/bug.png license not compatible

Tango look uniformisation

​https://commons.wikimedia.org/wiki/File:Gnome-view-refresh.svg is resources/images/dialogs/refresh.png but ​https://commons.wikimedia.org/wiki/File:View-refresh.svg could be used to standardise on the Tango look ✔️

resources/images/preferences/advanced.png is ​https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg but ​https://commons.wikimedia.org/wiki/File:Document-properties.svg could be used to standardise on the Tango look ✔️

resources/images/preferences/display.png is ​https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop-wallpaper.svg but ​https://commons.wikimedia.org/wiki/File:Preferences-desktop-wallpaper.svg could be used to standardise on the Tango look ✔️

KDE Breeze icons

​https://commons.wikimedia.org/wiki/Breeze_icons has some beautiful ones, and they come in different sizes, which means we can make them look good even in smaller sizes. If you all like these, I'll create the other icons.

​https://github.com/KDE/breeze-icons/blob/master/icons/actions/22/selection-move-to-layer-below.svg can replace resources/images/dialogs/mergedown.png ✔️ other icon used

​https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-duplicate.svg can replace resources/images/dialogs/duplicatelayer.png ✔️ other icon used

​https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-bottom.svg could be adapted with a double-headed arrow to replace resources/images/dialogs/reorderlayers.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kstars_satellites.svg could replace resources/images/layer/gpx_small.png and be the base for all gpx-related icons: resources/images/exportgpx.png , resources/images/dialogs/geoimage/gpx2img.png and resources/images/converttogpx.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-redeyes.svg, ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-hint.svg and ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-visibility.svg could be adapted to replace all the eye icons: resources/images/misc/buttonshow.png , resources/images/dialogs/layerlist/eye-off.png , resources/images/dialogs/layerlist/eye-pressed.png , resources/images/misc/buttonhide.png , resources/images/dialogs/layerlist/eye-translucent.png , resources/images/dialogs/showhide.png and resources/images/dialogs/layerlist/eye.png . We could also use their layer icons - ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-layer-visible-on.svg and ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-layer-visible-off.svg ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-autocorrection.svg could replace resources/images/dialogs/fix.png - and be an UI improvement over the socket wrench ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Breezeicons-emblems-16-vcs-normal.svg can replace resources/images/dialogs/layerlist/active.png right away. I'm not sure when resources/images/dialogs/layerlist/active-pressed.png is ever shown, but I could easily create that. ✔️ other icon used

For filters, it has ​https://github.com/KDE/breeze-icons/blob/master/icons-dark/preferences/32/preferences-desktop-filter.svg ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kt-add-filters.svg ​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kt-remove-filters.svg. ✔️ other icon used

​https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/document-edit.svg can replace resources/images/dialogs/mappaint/pencil.png ✔️ other icon used

​https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-edit-select-lasso.svg could replace resources/images/cursor/modifier/rope.png ✔️ other icon used

​https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-raise.svg and ​https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-lower.svg could replace the up/down arrows in the Layers panel. ✔️ other icon used

resources/images/clock.png is only even used for Help > Show Status Report. I suggest replacing it with ​https://github.com/KDE/breeze-icons/blob/master/icons/actions/22/debug-run.svg ✔️ other icon used (--> clock is used also while icons in the mapview load (usually you don't see this), in the layerlist during an upload of osm data and in the correlate images with gpx dialog)

[Stereo]

Based off Tango's Applications-accessories, replacement for resources/images/mapmode/extrude/extrude.png

[Stereo]

Based of Gnome-document-save, replacement for resources/images/upload.png

[Stereo]

Based of Gnome-document-save (see Upload.svg) and JOSM's way-select.svg, improved replacement for resources/images/uploadselection.png

[Stereo]

Based off Overpass API logo but with thicker lines, improved replacement for resources/images/download-overpass.png

[Stereo]

The existing ./resources/images/mapmode/addnote.svg can replace ./resources/images/dialogs/notes/note_new.png

[Stereo]

The validation checkmark is actually there four times:

resources/images/preferences/validator.png ✔️
resources/images/layer/validator_small.png ✔️
resources/images/dialogs/validator.png ✔️
resources/images/data/imagery/qa.png ✔️

[Stereo]

The blue validation checkmark is easily one of the ugliest icons in JOSM, but also one of the most recognisable ones. I've vectorised an improved, flatter one.

[Stereo]

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/preferences/activate-down.png

[Stereo]

Same as activate_down but to replace ./resources/images/preferences/activate-right.png

[Stereo]

​https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/images/NoteMarker.svg could replace: ✔️

./resources/images/dialogs/notes/note_closed.png
./resources/images/dialogs/notes/note_open.png
./resources/images/dialogs/notes/note_comment.png
./resources/images/dialogs/notes/note_new.png
./resources/images/mapmode/addnote.svg

and be adapted for

./resources/images/note_search.png

[Stereo]

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallleft.png

[Stereo]

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallright.png

[Stereo]

Actually, I see that we already have arrows like that in the SVG sprite at the top! Well, whichever works best.

[skyper]

could be replaced with ​osmwiki:File:Tower_dome.svg as the first does not look nice in preset menu

[Klumbumbus]

Thanks a lot for this long list of replacements, Stereo! I'll have a look after the upcoming next JOSM stable release.

[Klumbumbus]

In 16250/josm:

• see #12575 - Add icon for craft=photographer (​https://publicdomainvectors.org/en/free-clipart/Amateur-photography-camera-icon--vector-clip-art/20468.html, modified, CC0 and PD licensed)
• see #15240 - Replace validator and user icons by svg (error, other and user self created, warning from ​https://publicdomainvectors.org/en/free-clipart/Warning-vector-symbol/78747.html, modified, all CC0 and PD licensed)

[Klumbumbus]

I had these validator icons sitting here already for a while. I compared with your suggestions (​https://commons.wikimedia.org/wiki/File:Gnome-dialog-warning.svg and ​https://commons.wikimedia.org/wiki/File:Dialog-error.svg) but these don't scale down well.

[Stereo]

The KDE Breeze ones usually scale down a lot better - maybe ​https://github.com/KDE/breeze-icons/blob/master/icons/emblems/16/emblem-error.svg and ​https://github.com/KDE/breeze-icons/blob/master/icons/emblems/16/emblem-warning.svg ?

[Klumbumbus]

In 16251/josm:

see #15240 - use nicer user icon (from ​https://commons.wikimedia.org/wiki/File:System-users-3.svg, removed strange script from file, CC0 and PD licensed)

[Klumbumbus]

@Dirk: Do we need some special additions in the contribution file for icons with licenses like ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg
And whats the license of the KDE Breeze icons?

[stoecker]

I fear icons which require individual attribution can't be used. If we use larger sets of icons where one attribution fits, our contributions file can be used.

[Klumbumbus]

I reworked the icon section in the contribution file. Please have a look if it is ok:

CONTRIBUTION

@@ -105 +105 @@
 
 ------------------------------------ ICONS ------------------------------------
 
-Most icons have been nicked from GNOME and the GIMP, both under GPL. 
-Some are originally LGPL but redistributed here under GPL. 
+Lots of icons are from GNOME Project https://www.gnome.org/ under GPL or LGPL, redistributed here under GPL.
 
+Some icons are from GIMP https://www.gimp.org/ under GPL or LGPL, redistributed here under GPL.
+
+Lots of icons are from https://openclipart.org/, https://publicdomainvectors.org/, The Tango Desktop Project, other sources or self created, all PD and CC0 licensed.
+
 Simple OpenStreetMap logo has been created by ScubbX (CC-SA 2.0) based on official
 logo used by the OpenStreetMap Foundation:
 https://wiki.openstreetmap.org/wiki/File:Logo_simple.svg
@@ -121 +124 @@
 - original filename: keyboard.png
 - original size: 128x128
 - modifications: icon was cropped, then resized
+
+See also the commit message of each icon for its source at https://josm.openstreetmap.de/browser/josm/trunk/resources/images.
+ No newline at end of file

[stoecker]

The last link shouldn't have a point at the end. Either remove it or add one more word behind :-). Also add the newline at the end. Otherwise it looks fine to me.

[Klumbumbus]

In 16351/josm:

see #15240 - Rework icon attribution section

[Klumbumbus]

Replying to Stereo:

Original vector files

...

These look blurry when scaled down to 16 or 24 px. Anyone knows a program/tool that pixel aligns svgs somehow? Doing this manually is lots of work.
I loaded the tango theme (where we use some pngs still) from ​https://web.archive.org/web/20150911230620/http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz and beside the svgs it includes png exports at 16, 22 and 32 px, which are nicely pixel aligned but I don't know if this was done manually too or with one of the included scripts.

Also a general question: For the gui icons we stay at the base size of 24px, do we? In the past (some years ago) the size in the menus was 24px too similar to the toolbar. Now that the menus display the icons at 16 px lots of them are blurry. (See e.g. the tools menu.)

[Klumbumbus]

In 16719/josm:

see #15240 - Replace cancel icon by svg, (icon from tango project ​https://commons.wikimedia.org/wiki/File:Process-stop.svg, modified, PD and CC0 licensed)

[Klumbumbus]

In 16720/josm:

see #15240 - Replace validator icon by svg, (icon by Stereo, PD and CC0 licensed)

[Klumbumbus]

In 16721/josm:

see #15240 - Replace activate-down and activate-right icon by svg (icon by Stereo, PD and CC0 licensed)

[Klumbumbus]

Thanks for the icons Stereo.
Yeah, we reached the turning point. 173 png vs. 173 svg gui icons right now, see graph in ticket desciption above \o/

[Stereo]

✅

[skyper]

Would it be a good idea to add the size 24 as default option to [[JOSMImage()]] or do we need to adjust all wiki pages where the icons are present?

[Klumbumbus]

In 16722/josm:

see #15240 - Resize one of the validator icons to avoid a lot wiki changes

[Klumbumbus]

In 16724/josm:

see #15240 - Replace some icons by svg

• useallleft and useallright derived from internal copyendleft and copyendright icons, PD and CC0 licensed
• download-overpass modified by Stereo, resized, original by Roland.olbricht without license in osm wiki ​https://wiki.openstreetmap.org/wiki/File:Overpass_API_logo.svg
• extrude derived from tango ​https://commons.wikimedia.org/wiki/File:Applications-accessories.svg, modified by Stereo and me, PD and CC0 licensed
• updatedata from tango ​https://commons.wikimedia.org/wiki/File:System-software-update.svg, resized, PD and CC0 licensed

see #10759 - Remove old unused icons

[Klumbumbus]

One regression, see #19446, already fixed. I hope there are no more plugins affected.

[Klumbumbus]

At least the plugins undelete and buildings_tools are affected too :(
Too bad Jenkins doesn't report it.
Can someone please give me a hint how to find all affected plugins and how to properly fix it, not like [o35496]?

[Klumbumbus]

Replying to Klumbumbus:

how to properly fix it, not like [o35496]?

I just figured out that simply deleting the extension seems to work fine too. Is that a good solution?

[stoecker]

Replying to Klumbumbus:

At least the plugins undelete and buildings_tools are affected too :(
Too bad Jenkins doesn't report it.
Can someone please give me a hint how to find all affected plugins and how to properly fix it, not like [o35496]?

grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"
or a bit reduced:
grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"|grep "cancel\.png"

I just figured out that simply deleting the extension seems to work fine too. Is that a good solution?

That's the right solution. Extension should only be specified in rare cases when for some reason the auto-choice is unwanted.

So in most cases (in Java code) the extension should simply be dropped everywhere.

[Klumbumbus]

So by simply removing the file extension I don't need to change plugin.main.version right?

[Klumbumbus]

Replying to stoecker:

grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"
or a bit reduced:
grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"|grep "cancel\.png"

Thx, that helped, I found:

areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:    protected static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
austriaaddresshelper\src\org\openstreetmap\josm\plugins\austriaaddresshelper\AddressTypeDialog.java:    protected static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
buildings_tools\src\org\openstreetmap\josm\plugins\buildings_tools\MyDialog.java:    private static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
DirectUpload\src\org\openstreetmap\josm\plugins\DirectUpload\UploadDataGui.java:        setButtonIcons(new String[] { "uploadtrace.png", "cancel.png" });
Dxf-Import\src\org\openstreetmap\josm\plugins\dxfimport\ImportDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});
ext_tools\src\ext_tools\preferences\EditToolDialog.java:        setButtonIcons("ok.png", "cancel.png");
FastDraw\src\org\openstreetmap\josm\plugins\fastdraw\FastDrawConfigDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});
importvec\src\org\openstreetmap\josm\plugins\importvec\ImportDialog.java:        setButtonIcons(new String[] { "ok.png", "cancel.png" });
photo_geotagging\src\org\openstreetmap\josm\plugins\photo_geotagging\GeotaggingAction.java:            .setButtonIcons(new String[] {"ok.png", "cancel.png"})
photo_geotagging\src\org\openstreetmap\josm\plugins\photo_geotagging\GeotaggingAction.java:                        .setButtonIcons(new String[] {"cancel.png", "ok.png", "dialogs/delete.png"})
roadsigns\src\org\openstreetmap\josm\plugins\roadsigns\RoadSignInputDialog.java:        setButtonIcons("ok.png", "cancel.png");
sds\src\org\openstreetmap\hot\sds\SdsDiskAccessAction.java:                dialog.setButtonIcons(new String[] {"save_as.png", "cancel.png"});
sds\src\org\openstreetmap\hot\sds\SdsDiskAccessAction.java:            dialog.setButtonIcons(new String[] {"save_as.png", "cancel.png"});
terracer\src\org\openstreetmap\josm\plugins\terracer\HouseNumberInputDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png" });
tracer2\src\org\openstreetmap\josm\plugins\tracer2\preferences\ServerParamDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});

(found with findstr /s /i cancel\.png *.java)

[stoecker]

Replying to Klumbumbus:

So by simply removing the file extension I don't need to change plugin.main.version right?

Yes. In the core that was done years ago for all icons.

[stoecker]

I removed all extensions in plugins for setButtonIcons() call. Now recompiling and publishing is needed.

[Klumbumbus]

Replying to stoecker:

I removed all extensions in plugins for setButtonIcons() call.

Thx.

Now recompiling and publishing is needed.

Are you on it yet or should I do it?

[stoecker]

Replying to Klumbumbus:

Replying to stoecker:

I removed all extensions in plugins for setButtonIcons() call.

Thx.

Now recompiling and publishing is needed.

Are you on it yet or should I do it?

I currently have no Java8 system ready (and compiling with 11 may cause trouble). If you do it that would be fine, so I must not search a place for compiling. Simply compile all plugins (e.g. "ant build" in main dir) and then in dist dir do ./getversions. That drops all files without version change. This way also all the pending i18n is updated :-) Afterwards check in all changed files jars.

[Klumbumbus]

fixed trac plugins in [o35502] (with ant clean dist in every plugin directory)
still todo:

• ​https://github.com/JOSM/austriaaddresshelper
• ​https://github.com/JOSM/areaselector

I don't know how the github releases work.

[josmTEACH]

hey there wizards! i randomly walked into a large .svg on a wiki page (/styles)https://josm.openstreetmap.de/wiki/Styles and somehow teleported here, so wanted to let you know it might affect other wiki pages too?

big props to all the efforts done through the years fellas

[Klumbumbus]

In 16728/josm:

see #15240 - fix icons size

[Klumbumbus]

Thx for reporting josmTEACH.

[skyper]

See #18562 for a problem with delete.svg

[stoecker]

Replying to skyper:

See #18562 for a problem with delete.svg

Should be fixed in the plugin, i.e. in #18562.

[stoecker]

Replying to Klumbumbus:

I don't know how the github releases work.

I could find out, but actually I don't want to. I don't want to care for multiple build systems.

I'd say we release core tomorrow.

Either the plugins get fixed by the maintainers of the plugins or disabled. I'd only handle them after a reimport into the SVN.

[Klumbumbus]

In 16797/josm:

see #15240 - Change some png icons to svg:

• dialogs/refresh ​https://commons.wikimedia.org/wiki/File:View-refresh.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• preferences/advanced ​https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg, from GNOME Project, LGPL licensed
• preferences/display ​https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop-wallpaper.svg, from GNOME Project, LGPL licensed
• preferences/reset ​https://commons.wikimedia.org/wiki/File:Edit-undo.svg, from The Tango Desktop Project, PD and CC0 licensed
• preferences/shortcuts ​https://commons.wikimedia.org/wiki/File:Preferences-desktop-keyboard-shortcuts.svg, from The Tango Desktop Project, PD and CC0 licensed
• view-fullscreen ​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg, resized, from The Tango Desktop Project, PD and CC0 licensed
• view-fullscreen-revert ​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• warning-small derived from internal data/warning icon, PD and CC0 licensed

[Klumbumbus]

Anyone knows where is used?

[GerdP]

MainApllication.askUpdateJava() uses it for a button:

            ed.setButtonIcons("ok", "java", "cancel").setCancelButton(3);

[Klumbumbus]

Thx.

[Klumbumbus]

In 16799/josm:

see #15240 - Change some png icons to svg:

• data/relation ​https://commons.wikimedia.org/wiki/File:Emblem-system.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/mappaint/pencil ​https://commons.wikimedia.org/wiki/File:Text-x-generic_with_pencil.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/search ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• dialogs/zoom-best-fit ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• mapmode/zoom ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• info ​https://commons.wikimedia.org/wiki/File:Emblem-notice.svg, from The Tango Desktop Project, PD and CC0 licensed
• java ​https://en.wikipedia.org/wiki/Java_(programming_language)#/media/File:Java_programming_language_logo.svg, modified, without license, fair use
• remove dialogs/settings, use preference instead

[Klumbumbus]

I removed dialogs/settings because the svg didn't scale down well, it was used only once twice in core and the "preference" icon is the better choice anyway.

One plugin adapted in [o35513:35514] and one pull request created ​https://github.com/JOSM/conflation/pull/14. (I hope there are no more external plugins.)

[Stereo]

I hadn't noticed that you were using my long comment as a to-do list, slowly but surely striking out every line. So cool :D

[skyper]

Jenkins reports two problems with icons now: https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/4915/warnings4Result/new/

[Klumbumbus]

Yeah, I already noticed. I'll fix it with the next batch.

[Klumbumbus]

In 16800/josm:

see #15240 - Change some png icons to svg:

• dialogs/duplicatelayer, dialogs/layerlist, dialogs/layerlist/active, dialogs/layerlist/active-pressed, dialogs/mergedown, dialogs/reorderlayers, all derived from internal dialogs/activate icon, PD and CC0 licensed
• help/internet ​https://commons.wikimedia.org/wiki/File:Gnome-emblem-web.svg, modified, from GNOME Project, LGPL licensed
• purge ​https://commons.wikimedia.org/wiki/File:Edit-clear.svg, resized, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/geoimage/deletefromdisk, derived from internal dialogs/delete icon, PD and CC0 licensed
• remove data/key, use dialogs/propertiesdialog instead (fits better, used in command stack panel only)
• small changes/fixes to existing icons

[Klumbumbus]

The purge icon was always hard to understand what that should mean. The svg version was worse even after trying to improve it. So I switched to the well known broom.

[Klumbumbus]

In 16806/josm:

see #15240 - Change some png icons to svg:

• cursor/modifier/zoom, self created, inspired by png icon, PD and CC0 licensed
• dialogs/conflict, self created, based on dialogs/next icon, inspired by ​https://commons.wikimedia.org/wiki/File:Merge-short_arrows_2.svg, PD and CC0 licensed
• markers/speech, self created, inspired by png icon, PD and CC0 licensed
• markers/web, ​https://commons.wikimedia.org/wiki/File:Gnome-text-html.svg, modified, from GNOME Project, LGPL licensed
• preferences/audio, ​https://commons.wikimedia.org/wiki/File:Audio-x-generic.svg, color changed, from The Tango Desktop Project, PD and CC0 licensed
• preferences/plugin, ​https://publicdomainvectors.org/en/free-clipart/Plugin-icon/59375.html, modified, PD and CC0 licensed
• preferences/remotecontrol, ​https://freesvg.org/tv-control-vector-image, modified, PD and CC0 licensed
• restart, ​https://commons.wikimedia.org/wiki/File:View-refresh-2.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• save, ​https://commons.wikimedia.org/wiki/File:Media-floppy.svg, from The Tango Desktop Project, PD and CC0 licensed
• save_as, ​https://commons.wikimedia.org/wiki/File:Media-floppy.svg, from The Tango Desktop Project, + star from new icon, PD and CC0 licensed

fix a missing file extension in nodist folder

add golf=path to ignorelist

[Klumbumbus]

Some icons did completely change, most recognizable ones are plugin, save, save_as and restart.

[Stereo]

It's cool to see the progress.

Some useful sources of vectors made for various sizes:

​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.20 which has our download icon
​https://ftp.gnome.org/pub/gnome/sources/gnome-icon-theme/2.91
​https://ftp.gnome.org/pub/gnome/sources/gnome-icon-theme/3.12 which has multiple sizes in vector. We could use drive-harddisk.svg to re-create our download icon.
​https://ftp.gnome.org/pub/gnome/sources/adwaita-icon-theme/3.37/ which also has cursors and some symbolic icons that could be used to lazily recreate note_comment, note_closed, note_new, note_open, arrowdown, add, pastetags and delete and rotate

And then ​http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz has the last release of the Tango icons, but they don't all scale well.

[stoecker]

A side note: I find the WMS/TMS icon and the Add icons for these with the plus really ugly. Something nicer would be fine...

[Klumbumbus]

I plan to use the green up and down arrow without the hard drive for up- and download. (This is also how the download icon looks usually today, e.g. in browsers). This then allows also to easier retrieve derive the other variants, which are:

[Stereo]

@stoecker I agree! And the sharpness/transparency/colorfulness/gamma/adjustimg icons too, which seem based on the same custom icon.

@Klumbumbus Great idea. Those icons will become a lot clearer without the hard drive; "upload selection" can show a selection, for example.

[Klumbumbus]

Replying to stoecker:

A side note: I find the WMS/TMS icon and the Add icons for these with the plus really ugly. Something nicer would be fine...

I have no idea so far how TMS, WMS and WMTS could be expressed as image (if not as text in the image). One solution could be to use the plain add icon for all three and use TMS, WMS and WMTS as button text!?

[Klumbumbus]

ToggleDialog.java automatically adds "dialogs/" to the iconName. Is it possible to overwrite this to use icons from other folders, e.g. data/user in UserListDialog.java?

[stoecker]

Replying to Klumbumbus:

Replying to stoecker:

A side note: I find the WMS/TMS icon and the Add icons for these with the plus really ugly. Something nicer would be fine...

I have no idea so far how TMS, WMS and WMTS could be expressed as image (if not as text in the image). One solution could be to use the plain add icon for all three and use TMS, WMS and WMTS as button text!?

Don't ask me. I've no idea or otherwise I'd have fixed this long ago.

[stoecker]

Replying to Klumbumbus:

ToggleDialog.java automatically adds "dialogs/" to the iconName. Is it possible to overwrite this to use icons from other folders, e.g. data/user in UserListDialog.java?

Rather copy an image than reuse it. Makes replacing them later easier.

[Stereo]

Do you like the wms/tms icons in qgis?

[Klumbumbus]

attachments to this ticket from Stereo:
p2 ✔️
Extrude ✔️
Upload
Upload-selection
overpass-api-small (1) ✔️
qa ✔️
activate-down ✔️
activate-right ✔️
useallleft ✔️
useallright ✔️

[Stereo]

Yeah, a lot of love went into that "Upload selection" icon :). Want me to redo them all without the disk?

[stoecker]

Replying to Stereo:

Do you like the wms/tms icons in qgis?

The world? Looks better than ours, but this still leaves the issue how to separate them.

Maybe we should ask the guys which are better with such things, e.g. the ones of LogoContest? A notice on StartupPage linking to this ticket (after the image in the description are refreshed for current state)?

Like: "we're in the final phase to get rid of PNG icons in JOSM and want to replace some ugly icons in the process. Please help us to find better graphics".

While reading and writing code is easy for me, graphics is not. For other people it's reversed, so we should ask these people :-) I can only judge the result.

[skyper]

@Stereo
You already wrote that the icon is uggly but in my eyes it got noticeable worse with the switch to vector graphic:

I miss the shade and the 3D look. Could this be improved?

@Klumbumbus
Why was the old icon complete deleted and not moved to nodist?

[Stereo]

I thought the 3D look and shadow looked early-2000s and old fashioned, so I deliberately flattened it. De gustibus non est disputandum, I guess!

[Klumbumbus]

Replying to skyper:

Why was the old icon complete deleted and not moved to nodist?

If the new icon is 99% identical I delete the old icon. If they differ I move the old to nodist.

If an icon was deleted it is not lost, but can be found relatively easy via the commit, e.g. r16720.

[Klumbumbus]

Replying to Stereo:

Yeah, a lot of love went into that "Upload selection" icon :). Want me to redo them all without the disk?

If you want you can do this. Please use ​https://commons.wikimedia.org/wiki/File:Go-down.svg and ​https://commons.wikimedia.org/wiki/File:Go-up.svg as base, maybe with a bit thicker outline (not ​https://commons.wikimedia.org/wiki/File:Gnome-go-down.svg because they have a different fill and we use them in blue for navigation buttons. The different fill seperates the navigation icons a bit from the up/download icons, aside from the color)
We don't need the uploadproperties icon, I'll remove it.

[Klumbumbus]

Replying to Stereo:

Do you like the wms/tms icons in qgis?

Do you mean this one? ​https://github.com/qgis/QGIS/blob/master/images/themes/default/mActionAddWmsLayer.svg

[Klumbumbus]

In 16807/josm:

see #15240 - Change some png icons to svg:

• mapmode/rope, ​https://github.com/GNOME/gimp/blob/master/icons/Color/24/gimp-tool-free-select.svg, from GNOME Project, GPL licensed
• cursor/modifier/rope, ​https://github.com/GNOME/gimp/blob/master/icons/Color/24/gimp-tool-free-select.svg, resized, from GNOME Project, GPL licensed
• dialogs/commandstack, derived from undo and redo, from GNOME Project, LGPL licensed
• dialogs/minimap, derived from data/imagery/map, PD and CC0 licensed
• dialogs/relationlist, derived from data/relation, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/userlist, derived from data/user, from The Tango Desktop Project, PD and CC0 licensed
• remove dialogs/moveup and dialogs/movedown, use dialogs/up and dialogs/down instead
• remove dialogs/uploadproperties, use preference instead
• improve a few icons

[Klumbumbus]

plugin adapted in [o35515:35516]

[Klumbumbus]

In 16808/josm:

see #15240 - unify icon size

[Stereo]

Replying to Klumbumbus:

Replying to Stereo:

Do you like the wms/tms icons in qgis?

Do you mean this one? ​https://github.com/qgis/QGIS/blob/master/images/themes/default/mActionAddWmsLayer.svg

Yeah and ​https://github.com/qgis/QGIS/blob/master/images/themes/default/mActionAddXyzLayer.svg for TMS.

For those unfamiliar with QGIS's interface, I've posted a screenshot at ​https://i.imgur.com/Ox92kiq.png. There would be benefits to having a common "language" for users.

[skyper]

Replying to Klumbumbus:

plugin adapted in [o35515:35516]

Seems conflation fell under the hood, see #19592.

[Klumbumbus]

In 16827/josm:

see #15240 - Change a lot png icons to svg:

• misc/statusreport, ​https://commons.wikimedia.org/wiki/File:Format-justify-fill.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/edit, ​https://commons.wikimedia.org/wiki/File:Format-justify-fill.svg, modiefied + dialogs/mappaint/pencil, from The Tango Desktop Project, PD and CC0 licensed
• clock, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.20/gnome-icon-theme-2.20.0.tar.bz2 /clock, modified, from GNOME Project, GPL licensed
• wayflip, derived from dialogs/reorderlayers, PD and CC0 licensed
• cursor/modifier/rectangle_move, cursor/modifier/rectangle_plus, cursor/modifier/rectangle_plussmall, derived from rectangle and png icon, PD and CC0 licensed
• cursor/hand, ​https://freesvg.org/hand-cursor-vector-illustration, modified, PD and CC0 licensed
• importaudio, dialogs/notes/note_comment, ​https://commons.wikimedia.org/wiki/File:Internet-talk-error.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/notes/note_closed, dialogs/notes/note_new, dialogs/notes/note_open, cursor/modifier/create_note, mapmode/addnote, ​https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/images/NoteMarker.svg, from openstreetmap-website, resized, GPL licensed
• note_search, derived from new dialogs/notes/note_open and dialogs/search, from GNOME Project, GPL licensed
• eye, dialogs/showhide, dialogs/layerlist/eye, dialogs/layerlist/eye-translucent, dialogs/layerlist/eye-off, dialogs/layerlist/visibility, misc/buttonhide, misc/buttonshow ​https://publicdomainvectors.org/en/free-clipart/Blue-eye-vector-drawing/72608.html, modified, PD and CC0 licensed
• dialogs/layerlist/offset, self created, PD and CC0 licensed
• misc/check_large, ​https://freesvg.org/1545571884, modified, +shadow from tango, PD and CC0 licensed
• misc/sticky, self created, PD and CC0 licensed
• addmarkers, dialogs/pin, layer/marker_small, ​https://publicdomainvectors.org/en/free-clipart/Pin-with-shadow/50158.html, modified, PD and CC0 licensed
• dialogs/sort, dialogs/sort_below, dialogs/reverse, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.20/gnome-icon-theme-2.20.0.tar.bz2 /view-sort, modified, from GNOME Project, GPL licensed
• dialogs/filter, ​https://freesvg.org/green-funnel, modified, PD and CC0 licensed
• dialogs/relation/roundedcorners, dialogs/relation/arrowup, dialogs/relation/arrowdown, self created, PD and CC0 licensed
• dialogs/geoimage/photo-marker, dialogs/geoimage/photo-marker-selected, self created, PD and CC0 licensed
• mapmode/playheaddrag, self created, derived from markers/audio-tracer, PD and CC0 licensed
• data/imagery/elevation, ​https://freesvg.org/1418161967, modified, PD and CC0 licensed
• expert, ​https://publicdomainvectors.org/en/free-clipart/Glowing-light-bulb/83473.html, modified, PD and CC0 licensed
• dialogs/select, self created, derived from png and old cursor/normal, PD and CC0 licensed
• dialogs/addrelation, derived from data/relation and dialogs/add, PD and CC0 licensed
• dialogs/history, self created + shadow from Tango, PD and CC0 licensed
• dialogs/add, pastetags, self created, derived from png, PD and CC0 licensed
• dialogs/fix, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.91/gnome-icon-theme-2.91.93.tar.bz2 /preferences-system, modified, from GNOME Project, GPL licensed
• dialogs/autoscale/conflict, derived from png and dialogs/conflict, PD and CC0 licensed
• dialogs/autoscale/data, derived from png and dialogs/search, from GNOME Project, LGPL licensed
• dialogs/autoscale/layer, derived from png and dialogs/layerlist, PD and CC0 licensed
• dialogs/autoscale/next, derived from png and redo, PD and CC0 licensed
• dialogs/autoscale/previous, derived from png and undo, PD and CC0 licensed
• dialogs/autoscale/problem, derived from png and data/warning, PD and CC0 licensed
• dialogs/autoscale/selection, derived from png and dialogs/select, PD and CC0 licensed
• zoomin and zoomout, self created, derived from png, PD and CC0 licensed
• colorchooser, self created, PD and CC0 licensed
• improve some icons
• use save instead of save_as icon in "File exists. Overwrite?" dialog because after you hit the button you can't edit the name anymore and no new file is created.

[Klumbumbus]

In 16828/josm:

• see #15240 - remove forgotten png in svg
• fix #19583 - remove unused icons

[Klumbumbus]

I changed the cursor image of the mapview because it looked bad as the rendering of the cursor icons is different from all other icons (there is an outer rendering with full black pixels). I can't attach a screenshot because I had no tool which captures the custom cursor. I hope the new image works fine on other environments too (e.g. Java > 8 and hidpi screen). If anyone has problems with the cursor please report.

[Klumbumbus]

In 16842/josm:

see #15240 - Change png icon to svg:

• duplicate, ​https://commons.wikimedia.org/wiki/File:Mail-reply-sender.svg and copy, modified, from GNOME Project, GPL licensed
• fix some icons

[Klumbumbus]

In 16851/josm:

see #15240 - Change some png icons to svg:

• closechangeset, derived from dialogs/changesetdialog and closechangeset in nodist, modified, PD and CC0 licensed
• cursor/modifier/delete_node, cursor/modifier/delete, cursor/modifier/delete_segment, cursor/modifier/delete_way_normal, cursor/modifier/delete_way_only, cursor/modifier/delete_way_node_only derived from png, PD and CC0 licensed
• open, openrecent, ​https://freesvg.org/blue-opened-folder, modified, PD and CC0 licensed
• movenodeontoway, derived from png and joinnodeway, PD and CC0 licensed
• mapmode/delete, derived from png and dialogs/delete, PD and CC0 licensed
• unglueways, derived from png and alignline, PD and CC0 licensed
• movenode, derived from png and movenodeontoway, PD and CC0 licensed
• mapmode/improvewayaccuracy, distribute, mapmode/extrude/dualalign, mapmode/node/autonode, simplify, derived from png, PD and CC0 licensed

[Klumbumbus]

In 16854/josm:

see #15240 - Change some png icons to svg:

• statusline/name, derived from dialogs/autoscale/selection, PD and CC0 licensed
• dialogs/relation/roundabout_left_tiny, dialogs/relation/roundabout_right_tiny, ​https://commons.wikimedia.org/wiki/File:Zeichen_215_-_Kreisverkehr,_StVO_2000.svg, resized and the right one mirrored, PD and CC0 licensed
• data/object, layer/osmdata_small, self created, PD and CC0 licensed
• markers/photo, derived from presets/shop/photo, PD and CC0 licensed
• cursor/scale, cursor/rotate, self created, PD and CC0 licensed
• cursor/modifier/move, derived from cursor/hand, PD and CC0 licensed
• dialogs/selectionlist, self created, PD and CC0 licensed
• dialogs/geoimage/togglegit, derived from dialogs/geoimage/photo-marker and new cursor/rotate, PD and CC0 licensed

• parts outside the mapview removed in data/imagery/osmbasedmap
• update contribution file
• update ignorelist

[Klumbumbus]

In 16868/josm:

see #15240 - Change some png icons to svg:

• layer/gpx_small, converttogpx, dialogs/geoimage/gpx2img, ​https://freesvg.org/map-pointer, modified, PD and CC0 licensed
• converttoosm, is layer/osmdata_small, PD and CC0 licensed
• exportgpx, derived from new layer/gpx_small and save_as, PD and CC0 licensed
• download, download_in_view, downloadprimitive, dialogs/downloadincomplete, ​https://commons.wikimedia.org/wiki/File:Go-down.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• upload, ​https://commons.wikimedia.org/wiki/File:Go-down.svg, and new download, modified, PD and CC0 licensed
• no_upload, derived from old svg and new upload, PD and CC0 licensed
• dialogs/autoscale/download, derived from dialogs/autoscale/layer and new download, PD and CC0 licensed
• download_new_layer, derived from dialogs/autoscale/layer, new and new download, PD and CC0 licensed
• openlocation, ​https://freesvg.org/link-symbol-vector-clip-art and new download, modified, PD and CC0 licensed
• uploadselection, derived from dialogs/selectionlist and new upload, PD and CC0 licensed
• relation/downloadincomplete, relation/downloadincompleteselected, derived from png, relation/selectmembers and new download, PD and CC0 licensed

• redye gpx marker icons
• use download in view icon in notes panel

[Klumbumbus]

In 16871/josm:

see #15240 - Change some png icons to svg:

• preferences/toolbar, derived from open, save and download, PD and CC0 licensed
• ok, derived from dialogs/previous, (original source ​https://commons.wikimedia.org/wiki/File:Gnome-go-previous.svg, from GNOME Project), LGPL licensed
• improve lock icon
• fix MOTD and unit test (?)

[Klumbumbus]

MOTD is still broken, r16871 didn't fix it. Could someone please have a look?

[stoecker]

In 16872/josm:

fix image display in MOTD, see #15240

[stoecker]

Following icons have CSS-information not supported by SVG salamander causing CSS parser not implemented yet. Can the CSS maybe simply be removed?

• resources/images/presets/emergency/aed.svg
• resources/images/presets/misc/angles.svg
• resources/images/presets/misc/information/audioguide.svg
• resources/images/presets/misc/information/board.svg
• resources/images/presets/misc/information/information.svg
• resources/images/presets/misc/information/map.svg
• resources/images/presets/misc/information/informationoffice.svg
• resources/images/preferences/remotecontrol.svg

[Klumbumbus]

In 16875/josm:

see #15240 - Change some png icons to svg:

• dialogs/layerlist/colorfulness, dialogs/layerlist/gamma, dialogs/layerlist/sharpness, dialogs/layerlist/transparency, self created, PD and CC0 licensed

• remove unsupported CSS style information from some icons (doesn't change the icons appearance)

[stoecker]

In 16876/josm:

see #15240 - detect CSS in icons checker

[stoecker]

In 16880/josm:

see #15240 - add missing since for new function

[simon04]

JOSM tested r16812 fails to show the download icon on StartupPage:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Revision:16812
Build-Date:2020-07-31 01:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16812 en) Linux Arch Linux
Memory Usage: 309 MB / 3844 MB (154 MB allocated, but free)
Java version: 11.0.8+10, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 3840x2160 (scaling 1.0x1.0)
Maximum Screen Size: 3840x2160
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
VM arguments: [-Djosm.home=<josm.pref>]

[skyper]

Replying to simon04:

JOSM tested r16812 fails to show the download icon on StartupPage:

That's what I feared but was uncertain to ask about. So #19668 is only fixed for latest.

[skyper]

How about changing the wiki page and using the old icon until the end of the month ?

[Klumbumbus]

Browsers don't display , and correctly (I tested Firefox, Opera and IE), not sure why. In JOSM it works fine. Fixed it. Will be part of next commit.

[simon04]

Replying to skyper:

How about changing the wiki page and using the old icon until the end of the month ?

Then JOSM latest will be affected (since it no longer bundles a download.png). What if we remove the icon from StartupPage completely?

[Klumbumbus]

Replying to simon04:

Then JOSM latest will be affected (since it no longer bundles a download.png).

It works atm for tested and latest as now it is an external icon, see #19668. Lets continue discussion for this topic there.

[stoecker]

Replying to simon04:

Then JOSM latest will be affected (since it no longer bundles a download.png).completely?

No. When I do changes they always add a bit sugar if possible. From now on the icon is replaced with the internal one independent from the fact whether it's SVG or PNG :-)

This does not help in this case, as the old JOSM can't do that yet and the PNG is in a different directory.

[Klumbumbus]

In 16888/josm:

see #15240 - Change some png icons to svg:

• bug, ​https://publicdomainvectors.org/en/free-clipart/Sad-yellow-face/51889.html, modified, PD and CC0 licensed
• preference, preference_small, derived from png, PD and CC0 licensed
• dialogs/mappaintpreference, derived from dialogs/mapstyle and new preference, PD and CC0 licensed
• preferences/map, ​https://freesvg.org/folded-map, resized, PD and CC0 licensed
• preference/connection, is help/internet, original ​https://commons.wikimedia.org/wiki/File:Gnome-emblem-web.svg, modified, from GNOME Project, LGPL licensed
• splitway, mapmode/move/move, self created based on internal svgs, PD and CC0 licensed

• improve icons: ok, dialogs/sort, dialogs/sort_below, dialogs/reverse, mergenodes, unglueways, combineway

[skyper]

Replying to Klumbumbus:

Browsers don't display , and correctly (I tested Firefox, Opera and IE), not sure why. In JOSM it works fine. Fixed it. Will be part of next commit.

Was no problem with Firefox on Linux.

[Stereo]

Nine remaining PNGs as of 2020-08-14

[Klumbumbus]

We basically just need one more icon representing "Imagery" in general and then we are done.

(I'm still in favor of converting the WMS, TMS and WMTS buttons to buttons with text. Then we can use the plain plus icon.)

Regarding the suggestion of the QGIS icon I don't like it so much as it is not good recognizable at 24 and 16 px:
Also we use the globe in a different version already for "internet" i.e. connection settings, when something is opened in the browser and the contact presets.

[Klumbumbus]

In 16895/josm:

see #15240 - Change some png icons to svg:

• imagery_menu, preferences/imagery, mapmode/adjustimg, self created, PD and CC0 licensed
• remove imagery_small, replaced by imagery_menu

• presets/misc/embankment-pattern, presets/misc/embankment-pattern-centered, derived from png, PD and CC0 licensed

• fix offset of embankment patterns, which led to unpredictable rendering

[simon04]

In 16897/josm:

see #15240 - Ignore GettingStartedTest.testImageReplacement

[Klumbumbus]

In 16899/josm:

see #15240 - Change some png icons to svg:

• dialogs/add_tms, dialogs/add_wms, dialogs/add_wmts, derived from dialogs/add and png, PD and CC0 licensed

[Klumbumbus]

First longterm ticket fixed 🥳

[Klumbumbus]

Current number of JOSM icons:

• 1160 svg icons (821 presets/mappaint style + 339 GUI)
• 124 potlatch mappaint style png icons
• 6 png icons of the logo in different sizes

[skyper]

Replying to Klumbumbus:

First longterm ticket fixed 🥳

Wow, you made it. Thanks for your effort.

[Stereo]

celebration.svg, congratulations.svg!

[Klumbumbus]

In 35521/osm:

see #15240 - Change png icon to svg, derived from josm core icons mapmode/delete and downloadprimitive, waste bin original from ​https://commons.wikimedia.org/wiki/File:Gnome-edit-delete.svg, from GNOME Project, LGPL licensed

[Klumbumbus]

For plugins the svgs should be manually cleaned with svg cleaner before commit right?

[stoecker]

Big thanks to Klumbumbus and all the contributors for that major improvement.

[stoecker]

Replying to Klumbumbus:

For plugins the svgs should be manually cleaned with svg cleaner before commit right?

That's probably the best solution, yes.

[skyper]

Ok, now, I can start updating the wiki as almost every screenshot needs an update.

[Klumbumbus]

You may wait a little bit more. I plan to change a few icons.

[simon04]

@Klumbumbus: impressive work, thank you! I really like the fresh and modern look of the icons.

Just a few remarks/ideas:

• Preference dialog: should we replace the internet icon with the computer icon. Seeing so many globes/maps makes it hard to interpret the glob as internet.
• Preference dialog: the checkmark is fine. Validation reminds me of a traffic light (green/yellow/red)…
• Preference dialog: I find the 3×3 square icon for imagery hard to associate (it could be anything). Usure what would be most obvious: a satellite (we do have imagery/photo as satellite), a camera, …?
• Map modes: I find the minimap icon somewhat coarse (in comparison with the other very fine and detailed icons) and hard to associate with a (mini)map
• Presets: most icons have a transparent background, except for route, some transport icons, some facility icons, the pipeline icon and a few others – is this intended?
• Could you think of an adequate icon for File → Work offline?

Thanks again for your great work!

[Klumbumbus]

Replying to simon04:

• Preference dialog: should we replace the internet icon with the computer icon. Seeing so many globes/maps makes it hard to interpret the glob as internet.

I think a cloud fits good for connection preferences. What do you think of this one (it is even derived from Tango)?

Then we have the globe only for when things are opened in "the internet" i.e. webbrowser. This is fine. If you picture google "internet icon" you get nearly only globes.

• Preference dialog: the checkmark is fine. Validation reminds me of a traffic light (green/yellow/red)…

The green of a traffic light doesn't fit our categories Error, Warning and Other. I would keep the check mark. Maybe make it a little bit brighter to see its details better. picture google "validation icon" gives mostly checkmarks.

• Preference dialog: I find the 3×3 square icon for imagery hard to associate (it could be anything). Usure what would be most obvious: a satellite (we do have imagery/photo as satellite), a camera, …?

I don't like things like a satellite or camera so much because we have a lot other sources e.g. maps or qa layers and the higher resolution imageries are usually taken from planes, not satellites. (Also the term "Imagery" for the menu is not ideal in my eyes, "Backgound" or similar would be better, but changing this would affect a lot of strings.) What they all have in common is that they are delivered in tiles and users see this because of the different loading times of the single tiles. So I hope it is not so hard to associate for most users. I also tried making an icon which is a combination of "layers" and "tiles" but couldn't get a satisfying result (see below). Another constraint is that the icon should work at 16px for the iagery menu.

• Map modes: I find the minimap icon somewhat coarse (in comparison with the other very fine and detailed icons) and hard to associate with a (mini)map

map modes? do you mean dialogs? I have no idea so far for an improvement. I think it is easy to associate with a map.

• Presets: most icons have a transparent background, except for route, some transport icons, some facility icons, the pipeline icon and a few others – is this intended?

Yes, for icons which would be only black. These would be invisible in the mapview if no background is added (wiki:/DevelopersGuide/DefaultPresets#NewIcons). In case of route and pipeline we can remove the white background as they are not used in the mapview. Other existing preset icons with a white background box which are used in the mapview too should be improved by turnig it into a white halo or finding a colourful icon.

• Could you think of an adequate icon for File → Work offline?

Could be the cloud struck through red.

[simon04]

Replying to Klumbumbus:

I think a cloud fits good for connection preferences. What do you think of this one (it is even derived from Tango)?

What about ​https://commons.wikimedia.org/wiki/File:Network-receive.svg or ​https://commons.wikimedia.org/wiki/File:Network-server.svg or ​https://commons.wikimedia.org/wiki/File:Network-workgroup.svg

I don't like things like a satellite or camera so much because we have a lot other sources e.g. maps or qa layers and the higher resolution imageries are usually taken from planes, not satellites. (Also the term "Imagery" for the menu is not ideal in my eyes, "Backgound" or similar would be better, but changing this would affect a lot of strings.) What they all have in common is that they are delivered in tiles and users see this because of the different loading times of the single tiles. So I hope it is not so hard to associate for most users. I also tried making an icon which is a combination of "layers" and "tiles" but couldn't get a satisfying result (see below). Another constraint is that the icon should work at 16px for the iagery menu.

When first seeing the new icon, I did not associate it with our imagery backgrounds. Maybe re-use our layers icon here? Or ​https://commons.wikimedia.org/wiki/File:Camera-photo.svg

• Could you think of an adequate icon for File → Work offline?

Could be the cloud struck through red.

What about ​https://commons.wikimedia.org/wiki/File:Network-offline.svg

[Klumbumbus]

Replying to simon04:

What about ​https://commons.wikimedia.org/wiki/File:Network-receive.svg or ​https://commons.wikimedia.org/wiki/File:Network-server.svg or ​https://commons.wikimedia.org/wiki/File:Network-workgroup.svg

What about ​https://commons.wikimedia.org/wiki/File:Network-offline.svg

The tango monitors really have a strange aspect ratio. I took the gnome version and adusted it a bit:

OK with that?

When first seeing the new icon, I did not associate it with our imagery backgrounds.

While it is helpful it is not absolutely required to know what an icon means at the first look. Once you connected the icon with its meaning you know what it means. And you see it often as it is in the preferences and often in the imagery menu. It's like young people don't know what the save icon represents but they know what it does. "Hey cool dad, you 3d-printed the save icon..."
I'm not against another icon but so far the current one is the best one imho, but I'm biased :)

Maybe re-use our layers icon here?

That would be confusing.

Or ​https://commons.wikimedia.org/wiki/File:Camera-photo.svg

We already use it for geoimage layers.

[Klumbumbus]

Replying to simon04:

@Klumbumbus: impressive work, thank you!

Thanks, no problem. Now we need someone who cares about the remaining hidpi issues :)

[Klumbumbus]

In 16929/josm:

see #15240 - Change/Add icons

• preferences/connection, ​https://commons.wikimedia.org/wiki/File:Gnome-network-idle.svg, from GNOME Project, LGPL licensed
• offline, ​https://commons.wikimedia.org/wiki/File:Gnome-network-offline.svg, modified, from GNOME Project, LGPL licensed
• presets/landmark/pipeline, presets/misc/pipeline_substation (remove white background)

[Klumbumbus]

In 16931/josm:

see #15240 - Change default icon of a mappaint style and icon of style settings, fix style settings icon size

[Klumbumbus]

In 16932/josm:

see #15240 - Make style settings icon sharper

[Klumbumbus]

In 16949/josm:

see #15240 - Remove wrongly used addsegment icon

[Klumbumbus]

In 35531/osm:

see #15240 - Add addsegment icon removed from josm core in r16949

[simon04]

In 16999/josm:

see #15240 - MapCSSRendererTest: update reference.png for area-fill-image and area-icon (since info.svg changed)

[Klumbumbus]

Dirk, could you please replace the image on /newticket with the following?

[stoecker]

Replying to Klumbumbus:

Dirk, could you please replace the image on /newticket with the following?

That's Help/Action/ReportBug/reportbug.png Can you replace it?

[simon04]

Can someone please revise or delete JOSM themes. Almost all links are dead.

[stoecker]

Replying to simon04:

Can someone please revise or delete JOSM themes. Almost all links are dead.

Done.

[Klumbumbus]

Replying to stoecker:

That's Help/Action/ReportBug/reportbug.png Can you replace it?

Done, but it's deformed.

[stoecker]

Replying to Klumbumbus:

Replying to stoecker:

That's Help/Action/ReportBug/reportbug.png Can you replace it?

Done, but it's deformed.

Fixed.

There was a bugreport_small.png with 53x361 pixel attached to wiki:/Help/Action/About which now is missing. It is linked from /newticket page as well.

Can you recreate/fix this?

[Klumbumbus]

I didn't delete it, at least not now. If, then it was years ago. Also I don't know what would be the content of the image. For what do we need it on the newticket page? I don't see a missing image there.

[stoecker]

Replying to Klumbumbus:

If, then it was years ago.

Very likely

Also I don't know what would be the content of the image. For what do we need it on the newticket page? I don't see a missing image there.

The text "bug report link in About dialog" actually should be an image.

I thus assume it showed an excerpt of the bug report link in About dialog :-)

Maybe the comment for the image should contain the fact that it is used in newticket or somebody will delete it again ;-)

[Klumbumbus]

Ah, now I see it.
However the text says "link" but it is a button and a screenshots of the three buttons of the about dialog is not so usefull imho and we don't need to describe a second way to create the bug report anyway. The way via Help menu is enough on the newticket page.
Therefore I suggest to remove the second image and remove the text "oder diesen Link im "Über JOSM..."-Fenster," in all languages.

[Klumbumbus]

Replying to stoecker:

Maybe the comment for the image should contain the fact that it is used in newticket or somebody will delete it again ;-)

Done for Help/Action/ReportBug/reportbug.png

[stoecker]

Replying to Klumbumbus:

Therefore I suggest to remove the second image and remove the text "oder diesen Link im "Über JOSM..."-Fenster," in all languages.

I removed the image, but kept the text.

[Klumbumbus]

Replying to Klumbumbus:

Replying to skyper:

Ok, now, I can start updating the wiki as almost every screenshot needs an update.

You may wait a little bit more. I plan to change a few icons.

I think I'm pretty much done now with core gui icon changes. (However #7548 maybe gets implemented.)

[skyper]

Replying to Klumbumbus:

Replying to Klumbumbus:

Replying to skyper:

Ok, now, I can start updating the wiki as almost every screenshot needs an update.

You may wait a little bit more. I plan to change a few icons.

I think I'm pretty much done now with core gui icon changes. (However #7548 maybe gets implemented.)

Thanks, now I need to find time and motivation to write a wiki content rather than patches or external presets and rules. I'll see, what I can do.