#15226 closed enhancement (fixed)
[PATCH] support for compiling without JavaFX
| Reported by: | ris | Owned by: | Don-vip |
|---|---|---|---|
| Priority: | normal | Milestone: | 17.09 |
| Component: | Core | Version: | latest |
| Keywords: | build ant javafx optional | Cc: |
Description
Some platforms don't always have JavaFX available (e.g. it doesn't come by default with openjdk 8 on linux) and some of us want to be able to develop from these platforms.
This is the patch that I'm using (against 12711 I think?) to allow me to do so.
Reasons people may not like it: ruins compile-time exception checking for the JavaFxMediaPlayer constructor call.
I'd appreciate it if someone could test this on a JavaFX platform as I don't *actually have* a JavaFX-enabled build platform available to me right now...
Attachments (1)
Change History (13)
by , 7 years ago
| Attachment: | josm-r12711-build-without-javafx.patch added |
|---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Linux (I'm actually building a Nix toolchain to support my plugin development, hence no openjfx package available)
comment:3 by , 7 years ago
| Summary: | PATCH: support for compiling without JavaFX → [PATCH] support for compiling without JavaFX |
|---|
comment:5 by , 7 years ago
Patch looks ok but efforts should really be made by those Linux distributions which do not provide openjfx. Debian provides it for years!
comment:6 by , 7 years ago
In a perfect world, yes, and a few NixOS people (myself included) have looked into packaging OpenJFX but it is a serious piece of work with many subtly version-sensitive dependencies which will be tricky to get a reproducible build of.
comment:7 by , 7 years ago
| Milestone: | → 17.09 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:10 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
It doesn't look like this patch got applied properly. The hunk for build.xml was *supposed* to append
<exclude name="org/openstreetmap/josm/io/audio/JavaFxMediaPlayer.java" if:set="noJavaFX"/>
to the innards of the compile <javac ...> task, but instead got applied to the compile-jmapviewer task, where it makes no sense as no such file exists there.
What is your OS?