Feature request Tag2Link: ref:bag

[de_vries]

Disclaimer: If this is not the right place for feature requests for plug-ins, please point me to the right place.

In the Netherlands all buildings and addresses are imported from a official database (BAG). All buildings have their BAG-ID in the tag "ref:bag". I would like to have Tag2Link to provide a link, based on the "ref:bag" tag, to that object in the BagViewer. This is a website were you can view the official BAG database: ​https://bagviewer.kadaster.nl/

To achieve this I added the following code to the "tag2link_sources.xml" file:

    <!-- BAG - Buildings in The Neterlands --> 
     
    <src name="BAG">
       <rule>
            <condition k="ref:bag" />
            <link name="Open in BAG Viewer" href="https://bagviewer.kadaster.nl/lvbag/bag-viewer/index.html#?searchQuery=0%v%" />
        </rule>
    </src>

This code adds a "0" in font of the BAG-ID. Here is why:

• All BAG-ID's consist of 16 numbers
• Most BAG-ID's start with a 0
• Those leading zero's are striped from the BAG-ID when imported to OSM.
• The BagViewer doesn't work if you leave out the leading zero.

So my code works in most cases, but when there was no leading zero in the original BAG-ID, it doesn't work.

I have two questions:

• How to fix this code to ad just enough leading zero's to make the BAG-ID exactly 16 numbers long?
• Can this be added to the plugin?

Additional details:
ref:bag is used 10.000.000 times: ​https://taginfo.openstreetmap.org/keys/ref%3Abag
Example of a building without a leading zero in the BAG-ID:

• OSM: ​https://www.openstreetmap.org/way/297923406
• BAG: ​https://bagviewer.kadaster.nl/lvbag/bag-viewer/index.html#?searchQuery=1740100000017978

Example of a building with a leading zero in the BAG-ID:

• OSM: ​https://www.openstreetmap.org/way/265267429
• BAG: ​https://bagviewer.kadaster.nl/lvbag/bag-viewer/index.html#?searchQuery=0175100000003816

[Don-vip]

It is the right place :) I will look into it.

[Don-vip]

Fixed in [o34854:34856].

[stoecker]

Hmm, did you looks at the mentioned formating issue?

[Don-vip]

Seems not

[Klumbumbus]

@de_vries: valid ref:bag values in the osm database have either exact 15 or 16 digits, not more or less right?

[Klumbumbus]

I checked the database with overpass turbo (ways only), e.g.

[out:csv(::count)][timeout:295];
(
  way["ref:bag"~"^[0-9]{14}$"];
);
out count;

which gives the following results. (15 gives no result probably due to the large number.)

18 0
17 0
16 1.641.392
15 ? (should be around 7.777.117)
14 757.516
13 28.597
12 0
11 0
10 0
9 0
8 0
7 0
6 0
5 5
4 2
3 10
2 8
1 9

So, 13-16 digits seems valid?

[Klumbumbus]

The 28000 13 digit objects are here: attachment:15158_13_digit.PNG​ and valid, e.g.:

• ​https://www.openstreetmap.org/way/495434264
• ​https://bagviewer.kadaster.nl/lvbag/bag-viewer/index.html#?searchQuery=0007100000012561&geometry.x=273377.5089&geometry.y=564804.1417&zoomlevel=6&objectId=0007100000012561&detailsObjectId=0007100000012561

[de_vries]

@Klumbumbus 13-16 digits seems right. Anyway, your analysis seems more thorough than my knowledge.

[Klumbumbus]

fixed in [o35043:35044]

[de_vries]

@Klumbumbus Thanks for fixing this, I really appreciate it!

[Klumbumbus]

You're welcome :)

[de_vries]

With the merging of Tag2Link into the core and the switch to obtaining the rules from wikidata the ref:bag feature broke. It was somewhat fixable by editing wikidata and the data entry of the ref:bag osm wiki page.

But the formatting issue with the leading zeros that I mentioned above still remains.

[simon04]

Sorry for the regression. I see two ways to tackle this problem:

1. Find a way on Wikidata / OSM Wiki Wikibase to deal with leading zeros for the formatter URL – maybe @nyurik can help here?
2. Hard-code ref:bag in the Java source Tag2Link.java

[simon04]

I started a discussion on OSM wiki: ​Special:Diff/1958215

[simon04]

In 15881/josm:

fix #15158 - Tag2Link: leading zeros for ref:bag