Validator should flag ferry routes which are not connected to a highway=* or man_made=pier

[GerdP]

Sometimes ways with ​osmwiki:Tag:route=ferry are not properly connected to a highway. This can cause routing problems.
I know these typical problem cases:
1) the route is split into parts, so that an end node is only connected with other route=ferry ways
2) the connected highway is mapped with a low class, e.g. as hw=service instead of e.g. hw=secondary

I've attached a sample file created from current OSM data in Canada which contains both problems.
Nodes 660826272 and 323308217 are samples for 1), Node 1682319513 is a sample for 2)
If this check requires Java code please let me know and I'll try to code it.

I am not sure how to handle ferry routes which allow vehicles (e.g. bicycle or mofa) if they end at
a man_made=pier (and no other highway).

[naoliv]

Is man_made=pier routable or it needs explicity access=*?
And here I see cases like the examples in ferry-example.osm​:

• a ferry not connected to a highway or
• a ferry that ends in a terminal (and this terminal is not connected to a highway)

[GerdP]

My understanding of the wiki is that the access=* tag is about mooring boats.

[Klumbumbus]

Regarding 1) Routing should work even with splitted ways. It works for highways too. However it is written in the wiki that "The ferry route must not branch in the water", so I think we can add the test.

Regarding 2) I don't see a problem if the last way to the ferry terminal is mapped as highway=service. That shouldn't raise any routing problems.

[GerdP]

Reg. 1) In my example data the way is not only split. Multiple ferry lines end at the same node in the sea. Routing is not as on highways since it is not possible to change the ferry at such a node, and also this point in the sea is probably not really
fixed. So I think the wiki is right.

Reg. 2) OK, this might be a special problem that exists in Garmin GPS units, so I agree that this test is not useful in JOSM.

[Klumbumbus]

In 12572/josm:

• fix #15097 - warn if ferry route way is not properly connected
• don't warn about bridge and tunnel on ferry routes
• see #14807 - don't warn about unknown noref=yes
• fix #15035 - warn for objects at null island (except the weather buoy)

[Klumbumbus]

The file I used for testing:

attachment:ferry-validation-tests.osm​

[GerdP]

Thanks, seems to work fine for my test data, but doesn't find the ferry problems in ferry-example.osm. No idea why.

[Klumbumbus]

Replying to GerdP:

doesn't find the ferry problems in ferry-example.osm. No idea why.

Thats because in this file there is no downloaded area. This test is (like some others too) only executed within the downloaded area to avoid false positives if the ferry way is downloaded an ends out of the downloaded area where the connected way is not downloaded.

[GerdP]

OK, that is good. Esp. ferry lines tend to end outside of the downloaded area.