Modify ↓
#14891 closed defect (fixed)
Error: Incorrect roundabout (highway:primary instead of unclassified)
| Reported by: | ninjamask | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 17.06 |
| Component: | Core validator | Version: | |
| Keywords: | roundabout highway | Cc: |
Description (last modified by )
JOSM validator will autofix the roundabout (w10068083) wrongly from primary to unclassified
Attachments (0)
Change History (6)
comment:1 by , 7 years ago
| Keywords: | highway added; validator removed |
|---|---|
| Milestone: | → 17.06 |
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 7 years ago
comment:5 by , 6 years ago
| Summary: | Error: Incorrect roundabout (highway:primary instead of unclassified) → [Patch RFC] Error: Incorrect roundabout (highway:primary instead of unclassified) |
|---|
Please review:
See also comment:8, I think with v3 I've got the angle calculations right. I've now implemented that a _link road that is connected to a motorway or trunk must have the class of the higher way. Maybe this should depend on country (territories)?
I've also changed the unit test because I think the example in
josm\core\test\data\regress\14891\14891.osm.bz2 should not produce two warnings about wrong highway links.
comment:6 by , 6 years ago
| Summary: | [Patch RFC] Error: Incorrect roundabout (highway:primary instead of unclassified) → Error: Incorrect roundabout (highway:primary instead of unclassified) |
|---|
Sorry, changed the wrong ticket :(
Note:
See TracTickets
for help on using tickets.
Not easy to spot, but the error is in the data. w28508494 and w28508493 should be tagged with
highway=primaryinstead ofhighway=primary_link. We should add another test to detect invalid links.