#14701 closed enhancement (fixed)
[Patch] Copying relations needs Yes/No confirmation
Reported by: | mboeringa | Owned by: | simon04 |
---|---|---|---|
Priority: | normal | Milestone: | 20.06 |
Component: | Core | Version: | |
Keywords: | relation duplicate confirmation | Cc: |
Description
This is an enhancement request based on my own and others experience and also documented in Jochen Topf's issue tracker concerning the multipolygon fixing effort (see https://github.com/osmlab/fixing-polygons-in-osm/issues/29).
The problem is that it is to easy to accidentally copy relations, and this happens especially with multipolygon relations where novice JOSM users attempt to add new members. As a consequence, multiple stacked multipolygons are created, with sometimes more than a dozen copies having different counts of member ways. This is undesirable and difficult to clean up.
What likely happens is that instead of choosing "Modify relation", users accidentally click "Copy relation". This buttons sits right next to the button for modifying a relation. This means that if people accidentally hit it while intending to modify an existing relation, they may create a new relation without even knowing it, as it will have all the members and properties of the original and thus appear as the original to be modified. When they subsequently upload the changes, they will have created a copy instead of having modified the original.
It would be good if JOSM somehow warned for this type of (accidental) misusage in the interface.
I therefor propose an absolute minimal change to JOSM that is likely to minimize to chance of this happening accidentally: add a blocking modal dialog with the question
"Are you sure you want to copy an existing relation? Yes/No".
to the "Copy relation" button before opening the relation editor. This will make novice users aware of the fact they are copying an existing relation instead of modifying it.
Attachments (2)
Change History (17)
comment:1 by , 8 years ago
Milestone: | → 17.05 |
---|
comment:2 by , 8 years ago
Milestone: | 17.05 → 17.06 |
---|
comment:3 by , 7 years ago
Milestone: | 17.06 → 17.07 |
---|
comment:4 by , 7 years ago
Milestone: | 17.07 |
---|
by , 6 years ago
Attachment: | 2019-01-12-180907_459x217_scrot.png added |
---|
by , 6 years ago
Attachment: | 14701.patch added |
---|
follow-up: 13 comment:5 by , 6 years ago
Milestone: | → 19.01 |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Summary: | Copying relations needs Yes/No confirmation → [Patch] Copying relations needs Yes/No confirmation |
comment:6 by , 6 years ago
Keywords: | relation duplicate confirmation added |
---|
comment:7 by , 6 years ago
Milestone: | 19.01 → 19.02 |
---|
Discussion needed, new i18n strings involved → 19.02
comment:8 by , 6 years ago
Milestone: | 19.02 → 19.03 |
---|
comment:10 by , 6 years ago
Milestone: | 19.03 → 19.04 |
---|
comment:11 by , 6 years ago
Milestone: | 19.04 → 19.05 |
---|
comment:12 by , 6 years ago
Milestone: | 19.05 |
---|
comment:13 by , 5 years ago
Replying to simon04:
Maybe restrict to
type=multipolygon
?
As user I would simply disable this warning. Do not see any reason why this is not needed for other types as the fault is the same, duplicating instead of adding members. Anyway, there is a validator warning about relations with the same members.
comment:15 by , 5 years ago
Milestone: | → 20.06 |
---|
Maybe restrict to
type=multipolygon
?