Modify ↓
#14410 closed defect (fixed)
[PATCH] AddPrimitivesCommand undo remove existing data
| Reported by: | Tyndare | Owned by: | team |
|---|---|---|---|
| Priority: | major | Milestone: | 17.02 |
| Component: | Core | Version: | |
| Keywords: | AddPrimitivesCommand undo existing conflation | Cc: |
Description
The AddPrimitivesCommand is supposed to ignore existing data (there is a test for that: testAddIgnoresExisting())
But if we undo the command, the data that was already existing will be removed and not ignored, leaving an incoherent state.
This is causing major exception when we use "undo" with the Conflation plugin which rely on this command.
The attached patch save the state of pre existing data, and in case of undo restore their state instead of removing them from the DataSet.
I also took the liberty to try to simplify the code that handle selection (toSelect), feel free to ignore this part.
Attachments (1)
Change History (4)
by , 8 years ago
| Attachment: | AddPrimitivesCommand-undo-existing.patch added |
|---|
comment:1 by , 8 years ago
| Milestone: | → 17.02 |
|---|
Note:
See TracTickets
for help on using tickets.
PATCH