HistoryBrowserModel removes listener twice or does not register it

[anonymous]

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-06 20:18:38 +0100 (Sun, 06 Nov 2016)
Build-Date:2016-11-06 21:45:03
Revision:11223
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11223 en) Windows 10 64-Bit
Memory Usage: 247 MB / 247 MB (32 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\Downloads\josm.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=1641, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
+ alignways (32921)
+ imagery-xml-bounds (32699)
+ reverter (32796)

Tagging presets:
+ %UserProfile%\Box Sync\Dropbox\Townland Lists  and Acreages 1840 - 1914\irishboundariesVAR.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Communication_Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Irishboundaries&zip=1
+ %UserProfile%\Box Sync\Dropbox\Public\Townland Lists  and Acreages 1840 - 1914 (itsmuck@gmail.com)\irishboundariesVAR.xml

Map paint styles:
+ http://maps.openstreetmap.ie/josm/townland.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1

Last errors/warnings:
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@ca0092
- W: Too many errors. Dropping ReportedException [thread=Thread[AWT-EventQueue-2,6,javawsApplicationThreadGroup], exception=java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@ca0092, methodWarningFrom=BugReportExceptionHandler#handleException]
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@44280d
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@1ffe314
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@1b444b9
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@16f3389
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@9dc1a7
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@143f0fd
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@1b444b9
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@1ffe314


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (72) of javawsApplicationThreadGroup
java.lang.IllegalArgumentException: Attempted to remove listener that was not in list: org.openstreetmap.josm.gui.history.HistoryBrowserModel@16f3389
	at org.openstreetmap.josm.gui.layer.MainLayerManager.removeActiveLayerChangeListener(MainLayerManager.java:180)
	at org.openstreetmap.josm.gui.history.HistoryBrowserModel.unlinkAsListener(HistoryBrowserModel.java:683)
	at org.openstreetmap.josm.gui.history.HistoryBrowserDialog$CloseAction.run(HistoryBrowserDialog.java:161)
	at org.openstreetmap.josm.gui.history.HistoryBrowserDialog$WindowClosingAdapter.windowClosing(HistoryBrowserDialog.java:190)
	at java.awt.Window.processWindowEvent(Unknown Source)
	at javax.swing.JDialog.processWindowEvent(Unknown Source)
	at java.awt.Window.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Don-vip]

In 11646/josm:

see #14175 - refactor HistoryBrowserModel

[Don-vip]

In 11647/josm:

see #14175 - refactor HistoryBrowserModel

[Don-vip]

In 11659/josm:

fix #14175 - HistoryBrowserModel removes listener twice