Add icons to value drop down in adding tag dialog

[mdk]

Since more and more icons for common tag=value combinations are defined and used for preset and specially for the recently used tag list in the add tag dialogue, I realised, that I tend to identity recently used tags by the icons instead of reading the text (especially after changeing the list size from 5 to 20).
When I want to add a tag which is not in the list of recently used tags. I start typing key, hit TAB if I found the wanted value start typing the key and press ENTER when I reach the wanted value.
Sometimes key and especially values have similar names (like natural=scree and natural=scrub). When typing, the shown values depends on

• are the value is used in a preset?
• is the value used in the currently downloaded area?
• did I used the key in the current session recently?

So I can't rely on the characters I typed, but I must always check the current result by reading the text.
Example:
w TAB r ENTER normally results in waterway=river. But when I added a riverbank before the same key sequence results in waterway=riverbank. And when I add water=pond before the same key sequence results in water=reservoir.
Therefore I would find it very helpful to see icons in the drop-down lists either when typing or when selecting from the list. The icons would help me verifying the correct value and to get hints for the most common values. Values without icons are normally uncommon or typos.

[simon04]

What about changing the icon (and label?) of the Okay button?

[Klumbumbus]

That would make the width of that button changing while typing!? That sounds a bit strange to me. And what about long values, e.g. ​old_name=Philippine College of Science and Technology - Tayug Campus or longer?

[simon04]

In 15835/josm:

fix #14088 - Add tags dialog: use okay button icon from matching preset/style

[gaben]

The height of the button is changing with the icon as well. Try it out with building or addr:*. Also the width with eg. description.

[simon04]

I don't see an easy (and performant) way this fix this issue: The icons have different aspect rations (typically 16:16, description.svg has 11:16, housenumber.svg has 16:12).

I'm not going to invest time in harmonizing the displayed icon size (for now). If we cannot live with the current behaviour, I'm going to revert r15835.

[mdk]

Why not put a "container" around the icon with a fixed (min-)size of 16x16?

[simon04]

In 15889/josm:

fix #14088 - Add tags dialog: use padded preset/style icons for okay button

[Don-vip]

It causes two test errors: https://josm.openstreetmap.de/jenkins/job/JOSM/6058/jdk=JDK8/testReport/org.openstreetmap.josm.gui.dialogs.relation/

[simon04]

In 15895/josm:

see #14088 - Fix SelectionTableCellRendererTest, MemberTableMemberCellRendererTest

[simon04]

In 15896/josm:

see #14088 - Optimize ImageProvider.getPadded for untagged primitives

[simon04]

In 15897/josm:

see #14088 - Add ImageProviderTest.testGetPadded

[simon04]

In 15920/josm:

fix #18764, see #14088 - NPE in findIcon when adding a tag (patch by taylor.smock, extended)

[simon04]

In 15921/josm:

see #18764, see #14088 - Add non-regression test (patch by taylor.smock)

[simon04]

In 15927/josm:

see #18764, see #14088 - Add non-regression test (fix for headless)

[simon04]

In 15946/josm:

fix #18798, see #14088 - Crash when adding junction=roundabout to a node (patch by taylor.smock)

[simon04]

In 15947/josm:

see #18798, see #14088 - TagEditHelperTest: share code

[simon04]

In 15948/josm:

see #18798, see #14088 - Add robustness for TagEditHelper.AbstractTagsDialog.findIcon