Imagery offset bookmarks aren't locale independent

[naoliv]

Add some imagery offset bookmarks in any language, then start JOSM with LC_ALL=C exported.
See how there are no offset bookmarks available.
Using Bing, for example, it will happens if your language's translation for Bing aerial imagery differs from the English phrase.

Example:

First two entries where included with pt_BR. When starting JOSM with LC_ALL=C I just can't see them in the Imagery → Imagery offset menu.

JOSM should store the entries using some key that will make it available in any language, and not use the current locale translation.

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-06 20:18:38 +0100 (Sun, 06 Nov 2016)
Build-Date:2016-11-06 21:45:03
Revision:11223
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11223 pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 483 MB / 10206 MB (72 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u111-b14-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

[Klumbumbus]

Replying to naoliv:

JOSM should store the entries using some key that will make it available in any language, and not use the current locale translation.

The <id></id> tag would be available. Maps

[stoecker]

Don't forget that ID is not always available (but nearly always).

[Don-vip]

Replying to stoecker:

Don't forget that ID is not always available (but nearly always).

I've seen that (good javadoc :))

[stoecker]

Replying to Don-vip:

Replying to stoecker:

Don't forget that ID is not always available (but nearly always).

I've seen that (good javadoc :))

Never trust a documentation. :-)

OTOH: Never trust somebody who tells you something you can check yourself ;-)

[Don-vip]

In 13797/josm:

fix #13937 - save imagery offset bookmarks by locale-insensitive id (when available)

[Don-vip]

In 13798/josm:

see #13937 - code cleanup

[Don-vip]

@naoliv: it won't work in all cases for old bookmarks, you will have to fix some of them manually. But there should not be any problems with new bookmarks.

[naoliv]

Sure. Thank you!