[Patch] Exceptions handled via BugReport are no longer written to the console

[simon04]

For instance, the exception from #13828 is handled via the BugReport queue, but is not written to the console. This prevents from easily inspecting the stack trace when running JOSM from an IDE.

What about the fix:

src/org/openstreetmap/josm/tools/bugreport/BugReportExceptionHandler.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.tools.bugreport;
 
+import org.openstreetmap.josm.Main;
+
 /**
  * An exception handler that asks the user to send a bug report.
  *
@@ -19 +21 @@
      * @param e the exception
      */
     public static synchronized void handleException(final Throwable e) {
+        Main.error(e);
         BugReport.intercept(e).warn();
     }
 

[bastiK]

+1, the stack trace should be dumped to the command line.

[michael2402]

+1

You can use Logging.logWithStackTrace(Logging.LEVEL_ERROR, "Handled by bug report queue", e); to add a message and a stack trace (which is not possible with the Main methods).

I would suggest to move this call to the BugReportQueue#submit() method. There are log statements for the skipped errors - we could add stack traces to those, too. We can even add the stack traces in a more verbose level only, like:

Logging.info("User requested to skip error {0}", report);
Logging.logWithStackTrace(Logging.LEVEL_DEBUG, e);

[simon04]

In 11180/josm:

fix #13850 - Exceptions handled via BugReport are no longer written to the console

[simon04]

In 11211/josm:

see #13850 - BugReportQueue output original exception to console

Make it consistent with report sent to Trac.