relation editor: missing repaint of connectivity info after downloading incomplete members

[skyper]

What steps will reproduce the problem?

1. Have a multipolygon relation with at least one unclosed, incomplete member
2. Open relation editor and download all incomplete members

What is the expected result?

The connectivity info is updated and I see only closed rings

What happens instead?

The info is not updated and I still see unclosed ways

Please provide any additional information below. Attach a screenshot if possible.

After a click into the relation editor you get the repaint/recalculation.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-08 01:17:53 +0200 (Thu, 08 Sep 2016)
Build-Date:2016-09-08 01:35:41
Revision:10976
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10976 en) Linux Debian GNU/Linux 8.5 (jessie)
Memory Usage: 85 MB / 485 MB (26 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-1~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-8-jre:amd64-8u102-b14.1-1~bpo8+1
Java ATK Wrapper package: libatk-wrapper-java:all-0.30.5-1
VM arguments: [-Djosm.home=<josm.pref>]
Program arguments: [--language=en]

Plugins:
+ OpeningHoursEditor (32699)
+ imagery_offset_db (32796)
+ reverter (32796)
+ tag2link (32941)
+ terracer (32699)
+ undelete (32699)
+ utilsplugin2 (32815)
+ wikipedia (32884)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ http://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Simple_Indoor_Tagging&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

[GerdP]

I would only expect this when the order of the members is sorted so that the members form closed rings. Was that the case?

[skyper]

Replying to Gerd Petermann <gpetermann_muenchen@…>:

I would only expect this when the order of the members is sorted so that the members form closed rings. Was that the case?

Yes, this was a simple, complete and ordered multipolygon. Two outer and two inner ways and one outer way was incomplete. After downloading I clicked on the member list and the hint was updated. Gonna try to make an example file.

[skyper]

example file

[skyper]

first screenshot

[skyper]

second screenshot

[skyper]

third screenshot

[skyper]

Replying to skyper:

Gonna try to make an example file.

See josm_13592_example.osm​

Starting situation:

After download:

After clicks on both outer members:

[GerdP]

Yes, can reproduce it with your example. It works fine when you open a new layer, download one way of the MP and then download the incomplete others. Sorry, no idea where this has to be fixed :-(

[Don-vip]

In 15378/josm:

fix #13592 - refresh relation member table connectivity after a change of member ways nodes

[GerdP]

see ticket:21825#comment:35 reg. performance problems with r15378. What was the reason for the loop?