#13415 closed enhancement (fixed)
[Patch draft] Introduce ILatLon and make Node implement it.
| Reported by: | michael2402 | Owned by: | michael2402 |
|---|---|---|---|
| Priority: | normal | Milestone: | 17.05 |
| Component: | Core | Version: | |
| Keywords: | gsoc-core | Cc: | Don-vip, bastiK, stoecker |
Description
I tested if it makes the code more readable if we use a common interface for all objects that have a lat/lon.
Those are the results:
- The drawing code already uses
Node#getEastNorth(). It does not really change much - Most Node.getCoor() calls use some method of the LatLon object later (e.g. to compute distances).
So all in all, it will help clean up the code a bit but it won't help much. If you have suggestions on how to unify this, feel free to propose them.
Attachments (1)
Change History (17)
by , 8 years ago
| Attachment: | patch-latlon-generic.patch added |
|---|
comment:1 by , 8 years ago
| Milestone: | → 17.01 |
|---|
comment:2 by , 8 years ago
comment:3 by , 8 years ago
| Milestone: | 17.01 → 17.02 |
|---|
comment:4 by , 8 years ago
| Milestone: | 17.02 → 17.03 |
|---|
comment:5 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
comment:6 by , 8 years ago
Should be OK for 17.3. I'll be doing some more drawing code cleanup the next weeks (using utility classes, text/icon placement code, unifying opacity handling, testing, ...)
comment:7 by , 8 years ago
| Milestone: | 17.03 → 17.04 |
|---|
Moving this to 17.4. Primary goal is to make 17.3 stable.
comment:8 by , 8 years ago
| Milestone: | 17.04 → 17.05 |
|---|
comment:12 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | needinfo → closed |
The interface is implemented and used in several places, to unify Node, CachedLatLon and WayPoint code
comment:13 by , 7 years ago
Hi those changes broke some plugins. Can you fix them. See my new bug : #15157
comment:14 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:15 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Please don't reopen core tickets for plugin impacts!
Can you please update the patch?