Modify ↓
Opened 9 years ago
Closed 9 years ago
#12959 closed enhancement (fixed)
Move state changes to MapViewState class
| Reported by: | michael2402 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.06 |
| Component: | Core mappaint | Version: | |
| Keywords: | gsoc-core | Cc: | Don-vip, bastiK, stoecker |
Description
The MapViewState class handles state changes for now.
The updateLocationState() method is called too often and coordinate conversion for painting is creating one more intermediate object. I'll optimize this later when working on the map view painting.
Attachments (2)
Change History (10)
by , 9 years ago
| Attachment: | patch-mapview-add-state-getter.patch added |
|---|
comment:1 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 9 years ago
| Milestone: | → 16.06 |
|---|
comment:4 by , 9 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:5 by , 9 years ago
I didn't notice the unit test now relies on constructing a JFrame: that's not possible, all unit tests must run in headless mode. You'll have to find another solution.
comment:6 by , 9 years ago
| Summary: | [Patch] Move state changes to MapViewState class → Move state changes to MapViewState class |
|---|
by , 9 years ago
| Attachment: | patch-fix-12959-tests.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
In 10375/josm: