Modify

Opened 9 years ago

Closed 9 years ago

#12883 closed defect (duplicate)

Upload blocked by unhandled exception in validator: SH causes error in validation.tests.OpeningHourTest

Reported by: josm@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: template_report validator_error unexpected_exception unable_to_upload Cc:

Description

What steps will reproduce the problem?

  1. Enter "SH" text (two letters only or as a part of bigger expression) to value of "service_times" or "opening_hours" tag in any object/way.
  2. Perform upload or validation (even on this single object).

What is the expected result?

Upload dialog window opens, or validation results displayed.

What happens instead?

Upload window do not open, upload not possible, error logged in console.
Or after clicking on "Validation" button "Unexpected Exception" window appears, validation is not performed, error logged in console.

Please provide any additional information below. Attach a screenshot if possible.

"SH" is correct syntax for tag "service_times" and "opening_hours", meaning scholar holiday. For example: "Mo-Fr 08:00-09:00,14:00-15:00; SH off".
Evaluation of tag value containing word "SH" gives exception, silent on upload, with error window on manual validation.
To upload my changes to OSM, I have had to manually add advanced preference "validator.skipBeforeUpload"="org.openstreetmap.josm.data.validation.tests.OpeningHourTest". Then I was able to upload without problem but I had skipped validator helpful syntax analysis of this complex tag.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-05-02 10:23:17 +0200 (Mon, 02 May 2016)
Build-Date:2016-05-03 01:31:45
Revision:10168
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10168 en_GB) Windows 8.1 64-Bit
Memory Usage: 302 MB / 989 MB (66 MB allocated, but free)
Java version: 1.8.0_25-b18, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugins:
- BuildingGeneralization (UNKNOWN)
- CADTools (1005)
- ColorPlugin (1414145445)
- DxfImport (1006)
- FastDraw (32158)
- HouseNumberTaggingTool (31926)
- ImageWayPoint (32158)
- ImportImagePlugin (32158)
- ImproveWay (1452443304)
- OSMRecPlugin (32158)
- PicLayer (32158)
- ShapeTools (1000)
- SimplifyArea (32158)
- TombPlugin (46)
- Tracer2 (32158)
- alignways (32161)
- apache-commons (32158)
- apache-http (32158)
- areaselector (271)
- buildings_tools (32158)
- contourmerge (1014)
- dataimport (31926)
- download_along (32158)
- editgpx (32158)
- ejml (32158)
- geotools (31895)
- gpsblam (32158)
- gpxfilter (31923)
- graphview (32158)
- gson (32158)
- imagery-xml-bounds (32158)
- imagery_offset_db (32158)
- imageryadjust (32158)
- importvec (32158)
- jogl (1.0.46)
- jts (31906)
- junctionchecking (32158)
- kendzi3d (1.0.190.1)
- kendzi3d-resources (0.0.1)
- lakewalker (32158)
- log4j (32158)
- mapdust (31923)
- measurement (32158)
- merge-overlap (32158)
- namemanager (32158)
- opendata (32158)
- openvisible (31772)
- osmarender (31772)
- pdfimport (32158)
- photo_geotagging (32158)
- print (32172)
- rasterfilters (32158)
- reltoolbox (32158)
- reverter (32158)
- rex (1884)
- routing (32158)
- splinex (32158)
- tag2link (31923)
- tageditor (32158)
- terracer (32158)
- todo (29154)
- tofix (203)
- undelete (32158)
- utilsplugin2 (32158)
- wikipedia (32158)
- wms-turbo-challenge2 (32158)

Tagging presets:
- http://osm.michis-pla.net/presets/observatory.xml
- http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
- https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/CommonKeyboardShortcuts&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Communication_Towers&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Emergency_access&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
- https://raw.github.com/molysgaard/OAM-JOSM/master/oam-presets.xml
- https://raw.github.com/przemas75/OSM-permissions-preset/master/Presets_access_PL-preset.xml
- https://raw.github<user.name>content.com/species/josm-preset-transformap/master/transformap.xml
- https://raw.github<user.name>content.com/yopaseopor/traffic_signs_preset_JOSM/master/Presets_Traffic_signs.zip

Map paint styles:
- http://kolesar.turistautak.hu/osm/opencellid/api/styles/measurements.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PowerMapping&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- E: Failed to locate image 'https://raw.github<user.name>content.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_F101b_FOOT.png'
- W:  End of Road reserved for pedestrians (segregated): Could not get presets icon https://raw.github<user.name>content.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_F101b_FOOT.png
- E: Failed to locate image 'https://raw.github<user.name>content.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_F101b_FOOT_BICYCLE_HORSE.png'
- W:  End of Road reserved for horses,pedestrians and bicycles (segregated): Could not get presets icon https://raw.github<user.name>content.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_F101b_FOOT_BICYCLE_HORSE.png
- E: java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.scripts.JO12 to jdk.nashorn.internal.scripts.JO16

java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.scripts.JO12 to jdk.nashorn.internal.scripts.JO16
	at java.lang.invoke.MethodHandleImpl.newClassCastException(Unknown Source)
	at java.lang.invoke.MethodHandleImpl.castReference(Unknown Source)
	at jdk.nashorn.internal.scripts.Script$\^eval\_$14.L:15$L:21$L:21-1$parseHoliday$L:22-1$L:22(<eval>:22)
	at jdk.nashorn.internal.scripts.Script$\^eval\_$16.L:15$L:21$L:21-1$L:23(<eval>:23)
	at jdk.nashorn.internal.scripts.Script$\^eval\_$16.L:15$L:21$L:21-1$L:23-12$L:23(<eval>:23)
	at jdk.nashorn.internal.scripts.Script$\^eval\_$15.L:15$L:21$L:21-1$L:23-12(<eval>:23)
	at jdk.nashorn.internal.scripts.Script$\^eval\_$16.L:15$L:21$L:21-1$L:23-6(<eval>:23)
	at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:535)
	at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:209)
	at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:378)
	at jdk.nashorn.api.scripting.ScriptObjectMirror.callMember(ScriptObjectMirror.java:185)
	at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:505)
	at jdk.nashorn.api.scripting.NashornScriptEngine.invokeMethod(NashornScriptEngine.java:236)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.checkOpeningHourSyntax(OpeningHourTest.java:215)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.checkOpeningHourSyntax(OpeningHourTest.java:184)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.check(OpeningHourTest.java:259)
	at org.openstreetmap.josm.data.validation.tests.OpeningHourTest.check(OpeningHourTest.java:268)
	at org.openstreetmap.josm.data.validation.Test$TagTest.visit(Test.java:128)
	at org.openstreetmap.josm.data.osm.Way.accept(Way.java:211)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:211)
	at org.openstreetmap.josm.actions.ValidateAction$ValidationTask.realRun(ValidateAction.java:169)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:161)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Attachments (0)

Change History (1)

comment:1 by Don-vip, 9 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #10423.
Java bug fixed last year, please update your version of Java. Current version is 8u91, you're running 8u25.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.