Opened 9 years ago
Closed 9 years ago
#12867 closed enhancement (fixed)
Take into account building=transformer_tower when validating power lines supports
Reported by: | Penegal | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 16.06 |
Component: | Core validator | Version: | tested |
Keywords: | power transformer_tower support | Cc: |
Description
Hello, there (again).
Currently, when the validator processes power lines, it complains when a node on the power line is not tagged as a pole, tower… The problem is that this list of required tags does not include building=transformer_tower
, either as a node or as a way.
Well, typically, when a line gets into a transformer tower, it enters it through glass insulators embedded in the building wall. In this case, the validator should stop complaining about an abnormal or missing support on the line; an additional test should be made: if the node is a building=transformer_tower
, or a node on its way, this node must be an end of the power line; I'm not sure this test is useful, though, but it could be, depending on the circumstances, and as a line is not supposed to go through a transformer tower, but end in it.
Regards.
Attachments (1)
Change History (6)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
@Klumbumbus: Have a look at PowerLines.java (top part where the constants are defined). If you feel daring, you can try to make a source code change. If not, let us know. ;-)
comment:3 by , 9 years ago
I'm not able to fix it. The constants are only values of key power
, however we need building
. So I don't know how to define the key. Also I don't know how to define that it should be a node with building=transformer_tower
or a node as part of a way with building=transformer_tower
.
by , 9 years ago
Attachment: | power.diff added |
---|
comment:5 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Accidentially did checkin this in r10363. Hope it was correct :-)
I agree. @team: this is not a mapcss but a java test :)