Modify

Opened 9 years ago

Closed 9 years ago

#12867 closed enhancement (fixed)

Take into account building=transformer_tower when validating power lines supports

Reported by: Penegal Owned by: team
Priority: normal Milestone: 16.06
Component: Core validator Version: tested
Keywords: power transformer_tower support Cc:

Description

Hello, there (again).

Currently, when the validator processes power lines, it complains when a node on the power line is not tagged as a pole, tower… The problem is that this list of required tags does not include building=transformer_tower, either as a node or as a way.

Well, typically, when a line gets into a transformer tower, it enters it through glass insulators embedded in the building wall. In this case, the validator should stop complaining about an abnormal or missing support on the line; an additional test should be made: if the node is a building=transformer_tower, or a node on its way, this node must be an end of the power line; I'm not sure this test is useful, though, but it could be, depending on the circumstances, and as a line is not supposed to go through a transformer tower, but end in it.

Regards.

Attachments (1)

power.diff (2.4 KB ) - added by stoecker 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Klumbumbus, 9 years ago

I agree. @team: this is not a mapcss but a java test :)

comment:2 by bastiK, 9 years ago

@Klumbumbus: Have a look at PowerLines.java (top part where the constants are defined). If you feel daring, you can try to make a source code change. If not, let us know. ;-)

comment:3 by Klumbumbus, 9 years ago

I'm not able to fix it. The constants are only values of key power, however we need building. So I don't know how to define the key. Also I don't know how to define that it should be a node with building=transformer_tower or a node as part of a way with building=transformer_tower.

by stoecker, 9 years ago

Attachment: power.diff added

comment:4 by stoecker, 9 years ago

Milestone: 16.06

Would that fix the issue?

comment:5 by stoecker, 9 years ago

Resolution: fixed
Status: newclosed

Accidentially did checkin this in r10363. Hope it was correct :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.