Add an option to completely prevent upload of a layer : e.g. "never" to upload=true/false

[jaakkoh]

The most typical need for this extension might be training totally new people to the world of OSM, specifically using JOSM. There is commonly e.g. an example.osm file used to illustrate elements in OSM and how they show up & are manipulated in JOSM. The issue has been discussed at ​https://github.com/hotosm/learnosm/issues/335 . And the (currently last) comment from June 1, 2015.

Currently the most that can be done is to

• use the upload=false and
• then tell those that are trained not to upload their edited data -- and definitely not to "bypass" the prompt that warns not to upload the data (if someone does try to upload. And finally to
• check the area where the example data is placed to see if anyone has ended uploading regardless of the above.

Experienced users and especially those that are more computer savvy than some might think that having upload=false is sufficient. But it's not. And the answer is not to put more emphasis to stressing the need to not upload when the upload tells not to.

So, simply said, there really should be an upload=never option, or something alike.

[jaakkoh]

(comment moved to the ticket itself)

[althio]

That would be an interesting feature for our use case at LearnOSM ​https://github.com/hotosm/learnosm/issues/335

[stoecker]

Why not simply use a wrong username/password?

[bastiK]

Attached patch implements the upload='never' flag. There is deliberately no GUI to toggle the flag, you need to edit the file in an editor to set or unset.

[Don-vip]

Replying to bastiK:

Attached patch implements the upload='never' flag.

xml_flag should be final (immutable enum)

Otherwise it's great !

[bastiK]

In 11709/josm:

fixed #12731 - Add an option to completely prevent upload of a layer : e.g. "never" to upload=true/false

to set this option, add XML attribute upload='never' to .osm file

[bastiK]

In 11710/josm:

see #12731 - make enum field final + fix compiler warning

[Don-vip]

In 11712/josm:

see #12731 - checkstyle/sonar

[althio]

Thank you very much bastiK and Don-vip.
This works as intended on our side, we are very grateful for the implementation.

[openstreetmap.org-user-d1g]

Thanks for implementing that!