Group similar tests

[naoliv]

I am seeing a lot of similar tests giving ungrouped results.
For example:

What I could quickly see that are needing some grouping are:

In errors:

• wrong collection_times
• wrong opening_hours

In warnings:

• 'email': E-mail address contains an invalid username
• 'contact:email': E-mail address contains an invalid username
• website: URL contains an invalid authority | URL contains an invalid path
• lot of opening_hours tests
• service_times tests
• shop=something inside shop=something
• leisure=something inside leisure=something
• tourism=something inside tourism=something
• amenity=something inside amenity=something

Basically everything that is using key and/or name in the warning message should be grouped, if possible (like it happened for the "Long segments" test)

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-02-25 01:51:43 +0100 (Thu, 25 Feb 2016)
Build-Date:2016-02-26 02:34:44
Revision:9881
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9881 en) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 4065 MB / 9102 MB (1021 MB allocated, but free)
Java version: 1.8.0_72-internal-b05, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

[simon04]

In 9886/josm:

see #12570 - Group opening hours tests

[simon04]

Has to wait till 16.03 due to added I18n strings.

[Don-vip]

didn't see the ticket until now, good patch :)

[simon04]

In 9921/josm:

see #12570 - Group internet tags validator warnings

[Don-vip]

it does not compile.

[simon04]

In 9922/josm:

see #12570 - Group internet tags validator warnings

Fix build due to r9921.

[Don-vip]

is this fixed?

[simon04]

To be done in MapCSS validator:

• shop=something inside shop=something
• leisure=something inside leisure=something
• tourism=something inside tourism=something
• amenity=something inside amenity=something

[Don-vip]

Milestone renamed

[simon04]

In 10710/josm:

fix #12570 - Group MapCSS tag checker tests

[Klumbumbus]

If there is only one error then the group text is written at the end of the error text again. Is this the wanted behavior? It sounds a bit "doppelt gemoppelt" to me :)
amenity=driving_school innerhalb von amenity=driving_school - amenity innerhalb von amenity

[simon04]

This behaviour was not intended specifically, but it is the default behaviour when specifying a "message" and "description".

[Klumbumbus]

See #13798 for a regression of this feature and the fix.