add support for shop=tobacco

[dieterdreist]

the tag is currently used 4444 times and it is documented in the wiki.

[dieterdreist]

if needed I can provide an icon.

[Klumbumbus]

Replying to dieterdreist:

if needed I can provide an icon.

Yes, please in svg.

[Don-vip]

black & white icons are not great for JOSM because of our black background. zermes, any idea? :)

[dieterdreist]

yes, I didn't mean this literally, I drew the shape template so you can change the colour to any colour that integrates well with the other shop icons. If you tell me the colour code I can do it if you prefer this. There is no white in the icon, just one colour. Or if a border is desired. You can also point me to a link to another svg shop icon so I can copy these things from there.

[Klumbumbus]

There is no color code for shop icons. Just make sure that the icon is visible atleast on black, white and grey background.
We cannot use cc-by icons, because cc-by is not compatible with GPL.

more icon guidlines: https://josm.openstreetmap.de/wiki/DevelopersGuide/DefaultPresets#NewIcons

[dieterdreist]

tobacco pipe to be used for shop=tobacco. License cc0, created by Martin Koppenhoefer

[dieterdreist]

thank you for the hints, I have now replaced the icon with a (hopefully correctly formated) updated version and changed the license to cc0.

[Klumbumbus]

Thanks. I'm unsure in which group this belongs: "For the body" or "Other"?
...or "Food" ;)

[dieterdreist]

yes, "For the body" seems a good fit, maybe you should also move the funeral directors from "other" to this category ;-)

[dieterdreist]

btw.: I'm unsure if I have used the correct width and height, I made this now 100% and the viewBox as suggested 0 0 16 16, if it doesn't work like this it must be 16 width and height.

[Klumbumbus]

In 9420/josm:

fix #12337 - add shop=tobacco to preset and mappaint style, icon (by Martin Koppenhoefer) see [o31978]