Modify ↓
Opened 9 years ago
Closed 9 years ago
#12278 closed enhancement (fixed)
[Patch] Fix checkstyle file names
| Reported by: | michael2402 | Owned by: | team |
|---|---|---|---|
| Priority: | trivial | Milestone: | 16.01 |
| Component: | Core | Version: | |
| Keywords: | checkstyle | Cc: |
Description
suppressions -> files needs to be a regexp.
No real problem...
Checkstyle was also complaining about that config file not having a new line at the end.
Attachments (1)
Change History (5)
by , 9 years ago
| Attachment: | patch-fix-checkstyle-filename.patch added |
|---|
comment:1 by , 9 years ago
comment:2 by , 9 years ago
I run checkstyle using "ant checkstyle". And Eclipse runs it on every source file I edit.
The problem here is simply that people don't see that the file names are a regexp that just needs to be contained in the file path. So if anyone ever adds a class like "OsmEntities", that class is also excluded from checkstyle.
This might be intentional but we should at least make it clear that we are using regexp matching here by escaping the .
comment:3 by , 9 years ago
| Keywords: | checkstyle added |
|---|---|
| Milestone: | → 16.01 |
Note:
See TracTickets
for help on using tickets.
How do you run checkstyle? I got no problem with Eclipse, Ant or Jenkins, I don't understand why it's a problem for your setup.