#12232 closed enhancement (fixed)
New preset icons in svg - railway and ways - and a new tag railway=traverser
Reported by: | zermes | Owned by: | Klumbumbus |
---|---|---|---|
Priority: | normal | Milestone: | 16.01 |
Component: | Internal preset | Version: | |
Keywords: | icon svg preset railway abandoned rail buffer stop bus guideway crossing disused level crossing light rail millestone monorail narrow gauge preserved signal subway switch tram turntable traverser transfer table way combined foot cycleway cycle lane track dedicated bridleway footway path segregated steps track | Cc: | Klumbumbus, Nakaner |
Description
A few more to add. One of them doesn't exist in JOSM presets. It's the railway=traverser taginfo or transfer_table taginfo. wikipedia Can we add it to JOSM? Since JOSM have turntable I think it should have this one too. It is more used today than the roundtable that was used more in the steam locomotive era, I think.
I took off the line in the middle of "Combined Foot and Cycleway" sign because that line doesn't make sense, at the same time, keeps the sign recognizable and is more easy to distinguish it from the segregated sign in the tool bar menu without the text.
In the steps icon I've made another approach, removed the blue background from the official sign since it can be used in all steps, most of them don't have that sign. The other blue signs, most of the time, must have those signs in the field if we want to tag something with those tags (although unfortunately they are not blue in every country).
All released in CC0 and/or public domain. Some of them were based in openclipart.org and wikimedia.org signs (I was careful, took only the ones in public domain, some signs in wikimedia are not in public domain like CC-BY-SA and others).
Attachments (7)
Change History (35)
by , 9 years ago
Attachment: | JOSM_icons_railway_and_ways.png added |
---|
by , 9 years ago
Attachment: | JOSM_svg_icons_railway_and ways.7z added |
---|
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Cc: | added |
---|
comment:3 by , 9 years ago
Component: | Core → Internal preset |
---|
by , 9 years ago
Attachment: | JOSM_svg_icons_railway_and ways_viewBox_Fixed.7z added |
---|
follow-up: 6 comment:5 by , 9 years ago
If the missing tag railway=traverser is added to JOSM use the help page created a few moments ago https://wiki.openstreetmap.org/wiki/Tag:railway%3Dtraverser
comment:6 by , 9 years ago
Replying to zermes:
If the missing tag railway=traverser is added to JOSM use the help page created a few moments ago https://wiki.openstreetmap.org/wiki/Tag:railway%3Dtraverser
I see a very low usage of this tag yet (115 is generally not enough to be included in JOSM default presets). Does it mean that most of traversers are currently tagged as turntables?
comment:7 by , 9 years ago
Probably no one use the tag roundtable in a transverser since they have very different layouts (circle vs rectangle). The first time I saw one I used the tag "name=Transfer table" (of course is not the correct tag, It was a long time ago, I was learning) and "wikipedia=en:Transfer table".
I just thought if JOSM has roundtable it should have traverser, because they are a little similar. But I understand if we add a lot of tags to JOSM (railway has a lot not documented), it becomes a mess. Anyway we can add it latter if is used more. A least now it has the wiki page to help people find the correct tag.
Now the other icons are good in JOSM :-) Thanks.
comment:8 by , 9 years ago
Milestone: | → 16.01 |
---|
comment:9 by , 9 years ago
Please don't put these icons in JOSM now. I will make some changes to them. They must work in dark or grey themes as we can see in https://josm.openstreetmap.de/ticket/12259#comment:6
by , 9 years ago
Attachment: | JOSM_icons_railway_and_ways_v2.png added |
---|
by , 9 years ago
Attachment: | JOSM_svg_icons_railway_and ways_v2.7z added |
---|
comment:11 by , 9 years ago
Keywords: | railway abandoned rail buffer stop bus guideway crossing disused level crossing light rail millestone monorail narrow gauge preserved signal subway switch tram turntable traverser transfer table way combined foot cycleway cycle lane track dedicated bridleway footway path segregated steps track added |
---|
comment:12 by , 9 years ago
I would add the new icons now, but keep the old ones for now, to not break external presets. In next milestone we can remove the old icons and adjust external presets. Any concerns?
comment:13 by , 9 years ago
OK to add new icons now, sounds good. Have you checked the presets for the pharmacy icons ? There was failures yesterday.
follow-up: 18 comment:14 by , 9 years ago
Yes I fixed them. However there is still one error, but I don't know where it comes from. There is no preset with "KO" in the list. All have "OK". https://josm.openstreetmap.de/jenkins/job/JOSM/585/jdk=JDK8/testReport/junit/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTest/testValidityOfAvailablePresets/
comment:15 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:18 by , 9 years ago
Replying to Klumbumbus:
Yes I fixed them. However there is still one error, but I don't know where it comes from. There is no preset with "KO" in the list. All have "OK".
That's very strange. When I run the test on my machine I got the erroneous test:
http://michreichert.de/osm/wochenaufgabe/wa0607-apotheken/apotheken.xml INFO: GET http://michreichert.de/osm/wochenaufgabe/wa0607-apotheken/apotheken.xml -> 200 (3.38 kB) ERROR: Failed to locate image 'styles/standard/health/pharmacy.png' WARNING: [NODE, CLOSEDWAY] Pharmacy: Could not get presets icon styles/standard/health/pharmacy.png => KO
Does anyone know Michael Reichert to let him know he must update the icon?
comment:19 by , 9 years ago
Cc: | added |
---|
Michael,can you please update your preset. Or can we delete it, since the internal pharmacy preset was enhanced meanwhile?
follow-up: 21 comment:20 by , 9 years ago
@Klumbumbus You can delete the preset. It was just used during a Wochenaufgabe in 2015.
comment:21 by , 9 years ago
Replying to Nakaner:
You can delete the preset. It was just used during a Wochenaufgabe in 2015.
Done. Thank you! :)
follow-ups: 23 27 comment:22 by , 9 years ago
The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)
Location: https://www.openstreetmap.org/#map=19/50.83503/12.92419
by , 9 years ago
Attachment: | crossings.png added |
---|
by , 9 years ago
Attachment: | crossings2.png added |
---|
comment:23 by , 9 years ago
Replying to Klumbumbus:
The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)
Semi-OT: If a footway crosses a tram track, railway=* is right and highway=* is wrong. People argue if railway=crossing or railway=level_crossing is better.
comment:24 by , 9 years ago
I prefer the old icons over the new ones. If want to get away from the German saltire, you might have a look at the crossing icons of OpenRailwayMap. https://github.com/rurseekatze/OpenRailwayMap/blob/master/styles/icons/crossing.svg https://github.com/rurseekatze/OpenRailwayMap/blob/master/styles/icons/level-crossing.svg
These icons were designed and committed by myself and I hereby allow the JOSM developers to distribute them under any license (i.e. CC-0).
follow-up: 28 comment:27 by , 9 years ago
Replying to Klumbumbus:
The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)
I didn't forgot this. I will try other icons but won't be easy (if it was I would have already done it). In fact these obtrusive icons weren't easy too, believe me, before these I tried others that I don't have courage to show here, they were very very terrible.
Replying to Nakaner:
I prefer the old icons over the new ones. If want to get away from the German saltire(...)
I don't have nothing against "German saltire" per se, it's just too much abstract. If a 10 year old kid can figure out what a icons means, I think it's one proof the icon works, and I think that it's not the case in the previous icons.
comment:28 by , 9 years ago
Replying to zermes:
If a 10 year old kid can figure out what a icons means, I think it's one proof the icon works, and I think that it's not the case in the previous icons.
To me it was not so clear what the black and brown parts in your crossing icons mean. The context with the rail icon helped me to understand. However to understand what such an icon means is less important in this case because you will understand very fast any icon. And then it is more important that the icon is not obtrusive.
I checked the levelcrossing wikipedia pages and wikimedia commons and it seems, that a red cross (in different variations) is used in most countries. So I replaced the icons with two new svg icons, which a very similar to the old ones. See [o32032].
Here is a preview: