[Patch] Dialog for "Search menu items"

[simon04]

I really love the "Search menu items" from #10882. Sometimes the usability is a bit unintuitive (e.g., clicking in the text field already containing a search text does now show the results).

• I would like to use the dialog from the preset search [F3] for the menu item search
• I think we can remove preset items from the search results (since they have a separate search)

[Don-vip]

I fear a lot of trouble on focus management, it was pretty tough to make it work... Let's look at this in next milestone :)

[simon04]

Focus management? The focus of the text field for the search should be as easy as for the preset search dialog ([F3]).

[Don-vip]

I didn't look at the patch yet, sorry. I'll try it soon to make smart feedback :)

[Don-vip]

Not tested yet sorry, but soon, I promise :)

[Don-vip]

OK I have tested and I like it :)

[Don-vip]

a keyboard shortcut should be nice however. Alt-F1 maybe?

[simon04]

The patch proposes KeyEvent.VK_SPACE, Shortcut.CTRL (inspired by something I do not remember) …

[Don-vip]

OK then. But why is it not displayed?

[simon04]

I finally found the crucial difference:

(a) MainMenu.java vs. (b) -

@@ -801 +801 @@
             }
         });
 
-        helpMenu.add(new MenuItemSearchDialog.Action());
+        add(helpMenu, new MenuItemSearchDialog.Action());
         helpMenu.addSeparator();
         helpMenu.add(statusreport);
         helpMenu.add(reportbug);

[Don-vip]

Replying to simon04:

I finally found the crucial difference:

ah, subtle :D

[simon04]

In 9347/josm:

fix #12224 - Dialog for "Search menu items"

This places the "Search menu items" functionality in the help menu
instead of placing a text field at the very right of the main menu.

[Klumbumbus]

With long imagery names there is a scrollbar at the bottom and the select and cancel buttons are not in the middle.

When you type something and the long entries disappear, the scrollbar stays. when you try to move it it disappears. After you have done this once and delete your text, the scrollbar is above the buttons, so they are always in the middle. (Then also the scollbar disappears directly when typing something.)

build from jenkins

Build-Date:2016-01-10 13:11:45
Revision:9384
Is-Local-Build:true

Identification: JOSM/1.5 (9384 SVN en) Windows 7 32-Bit
Memory Usage: 194 MB / 247 MB (25 MB allocated, but free)
Java version: 1.8.0_66-b18, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

[simon04]

In 9389/josm:

see #12224 - Search menu-items/presets: use vertical scrollbar in list

[simon04]

In 9390/josm:

see #12224 - Search menu-items/presets: allow to select exacly 1 item

[simon04]

In 9410/josm:

see #12224 - Search menu items: do not overwrite toolbar action dialogs/search

[simon04]

In 11031/josm:

see #12224 - Search menu item: make shortcut work when MOTD is focused