Popular tags not in internal presets

[Don-vip]

I have built the list of popular tags (as defined by taginfo), unknown from JOSM presets, for which we do not have a MapCSS deprecation warning.

We should decide which tags should be added to presets, which ones should be deprecated and which ones should be ignored by the tag/key not in presets validator test. The decision that a tag is ignored is not forever and can of course be reconsidered later.

Tag (wiki)	Count (taginfo)	Decision
​abandoned=yes	​19932	Ignored. Lifecycle
​amenity=swimming_pool	​46883	Ignored. Duplicate of leisure=swimming_pool. However not declared as deprecated in the wiki.
​bicycle=dismount	​37307	Ignored for now, see #9158
​bin=yes	​22245
​building=cabin	​89126	Added
​building=civic	​53949
​building=hotel	​21776
​building=houseboat	​11520
​building=kindergarten	​13125
​building=manufacture	​94507
​building=public	​39377
​building=service	​95527
​building=stable	​10477	Added
​building=static_caravan	​26023
​building=train_station	​13938
​construction=yes	​48871	Ignored. Lifecycle
​crop=corn	​13629	Added
​crop=grass	​14186	Added
​crop=rice	​15795	Added
​cuisine=coffee_shop	​16997
​entrance=staircase	​66237
​footway=crossing	​135476
​footway=sidewalk	​217915
​golf=bunker	​64675
​golf=fairway	​24191
​heritage=2	​16686	Ignored like admin_level
​heritage=4	​14589	Ignored like admin_level
​highway=proposed	​51018	Ignored for now, see #11139
​historic=building	​11875
​historic=yes	​34631	Ignored. Lifecycle
​landuse=conservation	​24867
​landuse=farm	​572939	Deprecated in favour of landuse=farmland
​leisure=recreation_ground	​27747
​living_street=yes	​193832	Ignored. Used only in Russia. unclear situation in relation to highway=living_street.
​locality=townland	​48104
​maintenance=gritting	​15556	Ignored. Empty wiki page and local usage, see taginfo map
​man_made=mast	​23646	............ see #10759
​man_made=petroleum_well	​32326	Ignored. Unclear definition in relation to man_made=pumping_rig
​man_made=silo	​41194
​military=bunker	​23317	Added
​mooring=yes	​18504	Added
​oneway=-1	​122298	Deprecated We already have a validator warning.
​oneway=1	​10250	Deprecated We already have a validator warning.
​pipeline=marker	​12322	Added
​place=allotments	​12582
​placement=right_of:1	​17516	Added
​placement=transition	​12958	Added
​railway=signal	​40435
​railway=stop	​11325
​residential=rural	​125887	Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
​residential=urban	​15335	Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
​route=foot	​26924	............ see #10991
​ruins=yes	​33287
​seamark=buoy	​10212
​service=crossover	​16733	Added.
​service=emergency_access	​11623	Added
​smoking=outside	​14449	Added
​surface=earth	​24377	Ignored. Duplicate of ground and dirt (which are used much more) However not declared as deprecated in the wiki.
​takeaway=yes	​17507	Added
​tidal=yes	​16590	Added
​traffic_sign=maxspeed	​19063	Added
​trolley_wire=yes	​34577
​wall=dry_stone	​43074	Added
​wall=no	​10747377	Ignored. Used in French cadastre import
​water=intermittent	​269254	Deprecated. Validator Rule added.
​waterway=rapids	​44573	Keep the situation as is for now. Difficult case. Was removed from mappaint in r8135 and r8767. The tag is clearly garbage, however there is no replacement, so a deprecation warning is not possible.

[Don-vip]

In 9014/josm:

see #12102 - add crop=corn,grass,rice,wheat,hop to landuse=farmland preset

[Don-vip]

In 9015/josm:

see #12102 - add building=cabin,stable to Building preset

[Klumbumbus]

There are some tags, which are neither deprecated, nor are they appropriate to use in a preset imho. Possible reasons are:

• the definition is unclear
• they are mainly used only in one country (and are maybe a result of an import), e.g. wall=no, living_street=yes
• we previously decided to not add them (however we could rethink the dicision), e.g. highway=proposed
• there is a similar tag, tagging scheme is undecided by community, e.g. amenity=swimming_pool, ice cream

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

[Don-vip]

Replying to Klumbumbus:

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

Agreed. Let's update the table with these information for the unclear/ambiguous tags, and I'll code the list.

[Don-vip]

In 9023/josm:

see #12102 - cleanup TagChecker

• code refactor/cleanup/simplification
• clean list of ignored tags by removing tags that have been added to internal presets during past years
• add unit test to detect these tags if we add new tags to internal presets that are currently being ignored

[Don-vip]

In 9024/josm:

see #12102 - ignore Lifecycle tags

[Klumbumbus]

In 9026/josm:

see #12102 - add placement to major road preset

[Klumbumbus]

In 9027/josm:

see #12102 - add takeaway to meal presets

[Klumbumbus]

In 9028/josm:

see #12102 - add tidal to water presets

[Klumbumbus]

In 9029/josm:

see #12102 - add floating and mooring to pier preset

[Klumbumbus]

In 9030/josm:

see #12102 - add some tags to ignore list

[Klumbumbus]

In 9031/josm:

see #12102 - add service=crossover to railway presets and deprecate water=intermittent

[Don-vip]

In 9033/josm:

see #12102 - add wall=dry_stone,noise_barrier to barrier=wall preset

[Don-vip]

In 9034/josm:

see #12102 - add traffic_sign=maxspeed preset

[Don-vip]

In 9035/josm:

see #12102 - add smoking=outside

[Don-vip]

In 9036/josm:

see #12102 - add service=emergency_access to highway=service preset

[Don-vip]

In 9037/josm:

see #12102 - add pipeline=marker preset + deprecate type for pipelines and pipeline markers (replaced by substance), see #10907

[Don-vip]

In 9039/josm:

see #12102 - add military=airfield,barracks,bunker,range presets

[Don-vip]

In 9040/josm:

see #12102 - deprecate landuse=farm in favour of landuse=farmland

[Don-vip]

In 9041/josm:

see #12102 - ignore heritage, like admin_level

[Don-vip]

In 9042/josm:

see #12102 - ignore wall=no

[Don-vip]

In 9043/josm:

see #12102 - remove tags recently added to internal presets from ignored list

[Klumbumbus]

In 9045/josm:

see #12102 - add military translation context, improve traffic sign display values, improve farm validator warning

[Klumbumbus]

While the most areas with landuse=farm are indeed farmland there are also a lot which are farmyard. This misunderstanding was once the reason to invent farmland. So I changed the validator check.

[Klumbumbus]

In 9046/josm:

see #12102 - adjust pipeline presets, add marker icon, see #10907

[Klumbumbus]

pipeline marker icon [o31776]

[Don-vip]

In 9047/josm:

see #12102 - ignore ref:*, CLC:*, local_authority:*

[Don-vip]

I have started a patch for golf but I'm not sure to have time to finish it.
Presets/Golf_Course contains very nice SVG icons we could maybe reuse.

data/defaultpresets.xml

@@ -4994 +4994 @@
   </group>  <!-- Facilities -->
   <group name="Sports" icon="styles/standard/sport/soccer.png">
     <group name="Sport Facilities" icon="presets/stadium.png">
+        <group name="Golf" icon="styles/standard/sport/golf.svg">
+                <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
+                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                          fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                          pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                    <space />
+                    <key key="leisure" value="golf_course" />
+                    <reference ref="name_oh_wheelchair" />
+                </item> <!-- Golf Course -->
+                <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
+                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
+                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
+                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
+                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
+                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
+                          ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
+                    <space />
+                    <key key="leisure" value="miniature_golf" />
+                    <reference ref="name_oh_wheelchair" />
+                </item> <!-- Miniature Golf -->
+            <separator/>
+            <item name="Teeing Ground" type="node,closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="tee" />
+            </item> <!-- Teeing Ground -->
+            <item name="Hole" name_context="golf" type="way,closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="hole" />
+                <text key="ref" text="Reference" />
+                <text key="par" text="Par" />
+                <optional>
+                    <text key="name" text="Name" />
+                </optional>
+            </item> <!-- Hole -->
+            <item name="Pin" name_context="golf" type="node" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="pin" />
+                <text key="ref" text="Reference" />
+            </item> <!-- Pin -->
+            <item name="Green" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="green" />
+            </item> <!-- Green -->
+            <item name="Bunker" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=bunker" />
+                <space />
+                <key key="golf" value="bunker" />
+            </item> <!-- Bunker -->
+            <item name="Fairway" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=fairway" />
+                <space />
+                <key key="golf" value="fairway" match="keyvalue!" />
+                <key key="surface" value="grass" />
+            </item> <!-- Fairway -->
+        </group> <!-- Golf -->
         <item name="Stadium" icon="styles/standard/sport/stadium.png" type="node,closedway" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=stadium"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=stadium"
@@ -5053 +5140 @@
             <text key="name" text="Name" />
             <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,skating" values_context="sport" />
         </item> <!-- Racetrack -->
-        <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
-                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
-                  es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
-                  fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
-                  ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
-                  pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
-                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
-            <space />
-            <key key="leisure" value="golf_course" />
-            <reference ref="name_oh_wheelchair" />
-        </item> <!-- Golf Course -->
-        <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
-                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
-                  es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
-                  ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
-                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
-                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
-            <space />
-            <key key="leisure" value="miniature_golf" />
-            <reference ref="name_oh_wheelchair" />
-        </item> <!-- Miniature Golf -->
     </group> <!-- Sport Facilities -->
     <group name="Sport" icon="presets/rowing.png">
         <item name="Multi" icon="styles/standard/sport/multi.png" type="node,closedway" preset_name_label="true">

[Don-vip]

Replying to Klumbumbus:

While the most areas with landuse=farm are indeed farmland there are also a lot which are farmyard. This misunderstanding was once the reason to invent farmland. So I changed the validator check.

ok thanks :)

[Klumbumbus]

In 9048/josm:

see #12102 - adjust military=barracks preset, add mappaint icon for pipeline=marker (fix #10907), fix mappaint icon for military=airfield

[Klumbumbus]

In 9050/josm:

see #12102 - ignore man_made=petroleum_well, add validator warning for unusual value of admin_level

[Klumbumbus]

In 9051/josm:

see #12102 - make validator text universal (prepared for later addition of e.g. heritage without new required i18n string)

[Klumbumbus]

Replying to Don-vip:

I have started a patch for golf but I'm not sure to have time to finish it.
Presets/Golf_Course contains very nice SVG icons we could maybe reuse.

We can do this one and the rest of the list in the next milestone. I think we should stop adding new i18n strings today because of #12115.