#12041 closed defect (fixed)
Wrong message in relation member deletion confirmation
| Reported by: | Don-vip | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.11 |
| Component: | Core | Version: | |
| Keywords: | template_report i18n | Cc: |
Description
- Select several members of a given relation
- Delete them
- See erroneous message:
Revision: 8970 Is-Local-Build: true Build-Date: 2015-10-31 18:48:30 Identification: JOSM/1.5 (8970 SVN en) Windows 7 64-Bit Memory Usage: 1460 MB / 2708 MB (434 MB allocated, but free) Java version: 1.8.0_66, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM VM arguments: [-Dfile.encoding=UTF-8] Dataset consistency test: No problems found Plugins: - apache-commons (31718) - geotools (31603) - imagery-xml-bounds (31694) - jts (31603) - opendata (31695) - utilsplugin2 (31694)
Attachments (1)
Change History (10)
by , 9 years ago
follow-up: 5 comment:1 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 9 years ago
Are you sure this will work? Is there always the same number of objects then there is the number of relations? If not, you should probably use the "title1 + ' ' + title2" schema. That also isn't perfect, but at least better.
comment:3 by , 9 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The current Please confirm to remove {0} objects from {1} relations, lines 118-119 in core/src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java, doesn't work. Both objects and relations would need to translated for plural. That is not possible for languages that have multiple plural forms. That would be 9 combinations for a language with three plurals, but only three combinations can be entered. The only way to handle such a case is to split it into two sentences that are translated independently.
E.g. like this:
"<html>" +
trn("Please confirm to remove <strong>{0} object</strong>.",
"Please confirm to remove <strong>{0} objects</strong>.",
numObjectsToDelete, numObjectsToDelete)
+ " " +
trn("{0} relation is affected.",
"{0} relations are affected.",
numParentRelations, numParentRelations)
+ "</html>";
follow-up: 7 comment:5 by , 9 years ago
comment:6 by , 9 years ago
| Keywords: | i18n added |
|---|
comment:7 by , 9 years ago
Replying to Don-vip:
How exactly is
QuirkyPluralStringbeing used? Is it only a hint for developers, or is it now part of the i18n job?
This is only a marker to easier identify those kind strings (in case one came up with a universal solution). No behaviour is associated with this annotation.
comment:9 by , 9 years ago
Thanks. Also for keeping the quirkyPluralString in place as such hardcoded concatenation is not 100% I18n-correct. But it's better now until a universal solution is found (as you write in comment 7).
In 8975/josm: