taginfo-extract also external presets

[simon04]

Follow-up of #10512.

[Don-vip]

I'm going to launch a new build, you can commit this change in the current milestone if you want, as it does not have any impact on the software :)

[simon04]

In 8681/josm:

see #11795 - taginfo-extract also external presets

[simon04]

Would someone please set up a cron job on the server? Afterwards we can file a pull-request for the inclusion: ​https://github.com/joto/taginfo-projects

Unfortunately, the script outputs a lot of icon loading warnings/errors. Without changing a lot of code, I wasn't able to get rid of them …

[Don-vip]

I tried to add the cron job but it fails:

Caught: groovy.lang.MissingPropertyException: Exception evaluating property '' for org.openstreetmap.josm.gui.tagging.TaggingPresetReader$HashSetWithLast, Reason: groovy.lang.MissingPropertyException: No such property:  for class: org.openstreetmap.josm.gui.tagging.TaggingPresetMenu
Possible solutions: keys, icon, name, type, class, rawName
groovy.lang.MissingPropertyException: Exception evaluating property '' for org.openstreetmap.josm.gui.tagging.TaggingPresetReader$HashSetWithLast, Reason: groovy.lang.MissingPropertyException: No such property:  for class: org.openstreetmap.josm.gui.tagging.TaggingPresetMenu
Possible solutions: keys, icon, name, type, class, rawName
        at taginfoextract.run_presets(taginfoextract.groovy:240)
        at taginfoextract$run_presets.call(Unknown Source)
        at taginfoextract.main(taginfoextract.groovy:188)
make: *** [taginfo_nodep] Error 1

[Don-vip]

In 8687/josm:

see #11795 - add taginfo target to Ant build

[Don-vip]

In 8690/josm:

see #11795 - fix error

[Don-vip]

In 8692/josm:

see #11795 - fix HeadlessException with Jenkins

[Don-vip]

PR created here: ​https://github.com/joto/taginfo-projects/pull/18

[simon04]

Thanks for the fixes, esp. the typo fixed in r8690, Don-vip!

[Don-vip]

you're welcome :) now we could investigate all these warnings/errors and see if we can fix some of them...

[simon04]

In 8710/josm:

see #11795 - taginfoextract: avoid "Could not get presets icon" by not loading icons

[simon04]

Now, the only preset with errors is Presets/Nepal since it specifies empty types (type="").

[Klumbumbus]

Replying to simon04:

Now, the only preset with errors is Presets/Nepal since it specifies empty types (type="").

I think we should simply remove them from this preset. This preset is basically unmodified since its creation 2 years ago. It is not expacted that someone adds the types in the (near) future.

[simon04]

In 8717/josm:

see #11795 - taginfoextract: clean pref* directories after processing

[simon04]

Are there any usage statistics on Presets/Nepal? I wouldn't object removing this preset. Any thoughts?

[simon04]

Presets/Nepal deleted. Here's the archive, attachment:Presets_Nepal-preset.xml​​

[Klumbumbus]

Icons are not yet working.

​http://taginfo.openstreetmap.org/tags/memorial%3Atype=stolperstein#projects
https://josm.openstreetmap.de/wiki/Presets/StolpersteineLight

[simon04]

"As designed" ;-). Icons were never expected to work. While processing, they should just not trigger warnings on the commandline. One could investigate the effort to include them (as data URLs), though …

[Klumbumbus]

OK, I thought it is a bug, because icons of the internal preset are included. We can close this ticket again, except someone is willing to add this functionality.

[simon04]

I don't ;-) – at least not now and unless there is a certain demand for this feature