#11687 closed enhancement (fixed)
[patch] Please implement {epsg} in WMS request template
Reported by: | A_Pirard | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core imagery | Version: | tested |
Keywords: | ArcGis wms projection epgs | Cc: |
Description
Please implement {epsg} (or equivalent name) in http: request template
That's the same as {projection}, but without "EPSG:".
That will help building an ArcGis request.
ex: &imageSR={epsg} giving &imageSR=3857
TIA!!!
Attachments (1)
Change History (17)
comment:1 by , 10 years ago
comment:2 by , 9 years ago
Keywords: | wms projection epgs added; request helper removed |
---|---|
Summary: | Please implement {epsg} in http: request template → Please implement {epsg} in WMS request template |
comment:4 by , 9 years ago
Component: | Core → Core imagery |
---|
comment:5 by , 9 years ago
Summary: | Please implement {epsg} in WMS request template → [patch] Please implement {epsg} in WMS request template |
---|
Patch not tested. Please review.
follow-up: 8 comment:7 by , 9 years ago
@slodki: thanks for you contribution.
I changed the name of the parameter to {wkid} as bastiK proposed.
follow-up: 9 comment:8 by , 9 years ago
@wiktorn: it's bad idea to fallback to myProjCode - wkid is number and myProjCode can be "CRS:84" etc. Final result for JOSM user should be similar (http error), but empty string is better for undefined value then some strange string.
I've compared epsg database dump with Esri wkid list - it seems all wkid numbers <53000 have similar epsg numbers registered (i haven't compared proj definitions):
- 7407 numbers only in epsg database
- 3848 numbers in both epsg & ersi
- 1037 numbers only on wkid list
My code returns:
- *epsg* number = wkid for some projections
- *epsg* number even if it's not registered as wkid by Ersi (unknown wkid)
- empty string (nothing) for projections not identified by epsg code
Your code returns:
- *wkid* = epsg for some projections
- epsg, *not wkid*, for some projections not registered as wkid by Ersi
- string, *not wkid*, for projections not identified by epsg code
So {wkid} parameter name could be misleading - JOSM knows nothing about Ersi wkid list so far, except some similarities to epsg ids.
comment:9 by , 9 years ago
Replying to slodki:
So {wkid} parameter name could be misleading - JOSM knows nothing about Ersi wkid list so far, except some similarities to epsg ids.
Nevertheless, this is specifically for compatibility with Esri software. We can add more details and workarounds as needed. We can even ship the complete list, should it be necessary.
follow-up: 11 comment:10 by , 9 years ago
"CRS:84" is correct value for {wkid}? Can it be mapped to ArcGIS ID?
How many projections (as returned by myProjCode) without "epsg:" prefix do we use in JOSM?
comment:11 by , 9 years ago
Replying to slodki:
"CRS:84" is correct value for {wkid}? Can it be mapped to ArcGIS ID?
You can ignore "CRS:84", it is only relevant for WMS version 1.3.0. The equivalent EPSG code is EPSG:4326.
How many projections (as returned by myProjCode) without "epsg:" prefix do we use in JOSM?
This is the only one at the moment.
follow-up: 13 comment:12 by , 9 years ago
In my mind, {epsg} is the EPSG number taken out of what I call the screen projection (to make it newbie understandable).
It is not an Arcgis feature properly, but it's useful to hack its request better than by hardcoding that projection.
When can I start testing and how?
Shouldn't this bug be reopened and closed as a gignal?
follow-up: 14 comment:13 by , 9 years ago
Replying to anonymous:
In my mind, {epsg} is the EPSG number taken out of what I call the screen projection (to make it newbie understandable).
It is not an Arcgis feature properly, but it's useful to hack its request better than by hardcoding that projection.
Sure, one could do that. Or, as this hack would be useful for nothing else, go one step further and treat it as a feature for Arcgis compatibility. At the moment, it is practically the same, just the name is different.
When can I start testing and how?
Now, by downloading the latest version of JOSM.
Shouldn't this bug be reopened and closed as a gignal?
Closed as what?
follow-up: 15 comment:14 by , 9 years ago
I wish this site really remembered me.
Replying to bastiK:
Replying to anonymous:
When can I start testing and how?
Now, by downloading the latest version of JOSM.
That's "when". What about "how": epsg or wkid. not clear.
Shouldn't this bug be reopened and closed as a gignal?
Closed as what?
closed and reopened as a signal.
comment:15 by , 9 years ago
comment:16 by , 9 years ago
I changed 3857 to {wkid} in a layer definition and it seems alright to me.
Just as great JOSM as ever!!! Many thanks!
Esri keeps a separate list of projection ids and calls it well-known ID. It is mostly identical with EPSG, but the reason they forked it, is probably to allow changes and additions.
We should name the prarameter
{wkid}
, see here for a description of theimageSR
parameter.