Context Navigation

Modify ↓

#11136 closed defect (fixed)

[Patch] IllegalStateException: "Missing merge target for relation" trying to revert changeset after object history loads

Reported by:	Travis.G.Mount@…	Owned by:	Upliner
Priority:	normal	Milestone:
Component:	Plugin reverter	Version:	tested
Keywords:	template_report	Cc:

Description

What steps will reproduce the problem?

Download data for Seoul on this server: http://travisgmount.doesntexist.com/api (can provide login if needed)
Data->Revert changes, changeset 38
As soon as object history finishes downloading, I get this error.

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision: 7995
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-01-31 15:17:59 +0100 (Sat, 31 Jan 2015)
Build-Date: 2015-02-01 02:33:54
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7995

Identification: JOSM/1.5 (7995 en) Windows 7 64-Bit
Memory Usage: 178 MB / 247 MB (55 MB allocated, but free)
Java version: 1.8.0_31, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugins:
- reverter (30990)

Last errors/warnings:
- W: Failed to load Mappaint styles from 'https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportation&style'. Exception was: java.io.IOException: No file found for: https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportation&style
- E: java.io.IOException: No file found for: https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportation&style
- E: java.lang.IllegalStateException: Missing merge target for relation with id 17

java.lang.IllegalStateException: Missing merge target for relation with id 17
	at reverter.ChangesetReverter.getCommands(ChangesetReverter.java:380)
	at reverter.RevertChangesetTask.realRun(RevertChangesetTask.java:104)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:161)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Attachments (1)

11136.patch (915 bytes ) - added by GerdP 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by skyper, 8 years ago

Similar #12829

problem with deleted nodes see #13981

comment:2 by Don-vip, 6 years ago

Summary:	Error trying to revert changeset after object history loads → IllegalStateException: "Missing merge target for relation" trying to revert changeset after object history loads

comment:3 by Don-vip, 6 years ago

Ticket #12829 has been marked as a duplicate of this ticket.

by GerdP, 5 years ago

Attachment:	11136.patch added

comment:4 by GerdP, 5 years ago

Summary:	IllegalStateException: "Missing merge target for relation" trying to revert changeset after object history loads → [Patch] IllegalStateException: "Missing merge target for relation" trying to revert changeset after object history loads

See ticket:13981#comment:25
CS 36536612 contains some objects multiple times, e.g node 3942364677 is first created, then used in a new way and later deleted.
The attached patch adds a check so that reverter doesn't search for versions which only exist within in the CS.

comment:5 by skyper, 5 years ago

Just ran into this trying to revert CS 89526202.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-09-15 22:02:10 +0200 (Tue, 15 Sep 2020)
Revision:17031
Build-Date:2020-09-16 01:30:50
URL:https://josm.openstreetmap.de/svn/trunk

Dataset consistency test: No problems found

Plugins:
+ reverter (35499)

Last errors/warnings:
- 00599.248 W: java.net.SocketTimeoutException: Read timed out
- 00599.249 E: java.net.SocketTimeoutException: Read timed out
- 00599.250 E: java.util.concurrent.ExecutionException: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: Read timed out
- 00605.914 E: Handled by bug report queue: java.lang.IllegalStateException: Changeset 89526202: Missing merge target for relation 11513720
- 00643.265 W: Warning - <html>JOSM could not find information about the following plugins:<ul><li>reverter</li>The plugins are not going to be loaded.</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.IllegalStateException: Changeset 89526202: Missing merge target for relation 11513720
	at reverter.ChangesetReverter.getCommands(ChangesetReverter.java:428)
	at reverter.RevertChangesetTask.revertChangeset(RevertChangesetTask.java:167)
	at reverter.RevertChangesetTask.realRun(RevertChangesetTask.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

follow-up: 7 comment:6 by GerdP, 5 years ago

java.net.SocketTimeoutException: Read timed out

Seems your internet connection is not good and a corresponding check in JOSM or the reverter plugin is missing. The original report doesn't contain such a warning.

in reply to: 6 comment:7 by skyper, 5 years ago

Replying to GerdP:

java.net.SocketTimeoutException: Read timed out

Seems your internet connection is not good and a corresponding check in JOSM or the reverter plugin is missing. The original report doesn't contain such a warning.

Yes, you are right. It did work now. Another case where the communication timeout is not reported properly.

comment:8 by GerdP, 4 years ago

Resolution:	→ fixed
Status:	new → closed

Should be fixed with [35638/osm].

comment:9 by skyper, 4 years ago

Is there an option to set a longer period to wait for an answer. With a slow internet connection, the revert of big changesets with some big relations involved does not work for me most of the time.

Three days ago, I was working on a long route relation and I got a conflict on upload and everything I tried just timed out (sync dataset, sync object, update data/modified/selection). Only download does usually not timeout.

comment:10 by GerdP, 4 years ago

You can try to increase socket.timeout.read (default is 30 s)
My understanding is that this is not related to the speed of the internet connection. I assume the server reuires more time to process your update.

comment:11 by skyper, 2 years ago

#22520 is similar.

Modify Ticket

Change Properties

Summary:
Type:		Priority:
Milestone:		Component:
Version:		Keywords:
Cc:	Set your email in Preferences

Action

leave as closed The owner will remain Upliner.

change resolution as The resolution will be set.

reopen The resolution will be deleted. Next status will be 'reopened'.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: