[patch] notes popup can not be opened or closed via the mapview if there is only the notes layer

[Klumbumbus]

What steps will reproduce the problem?

1. download notes with new core notes feature
2. click on a note in the notes dialog
3. a popup with the text appears in the mapview
4. click on an empty space in the mapview

What is the expected result?

the popup closed

What happens instead?

the popup stys open and there is no possibility to close it.

Please provide any additional information below. Attach a screenshot if possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-16 02:34:51
Last Changed Author: bastiK
Revision: 7805
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-15 20:44:26 +0100 (Mon, 15 Dec 2014)
Last Changed Rev: 7805

Identification: JOSM/1.5 (7805 de) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (105 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=58965, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30737)
- HouseNumberTaggingTool (30762)
- OpeningHoursEditor (30737)
- PicLayer (30762)
- Tracer2 (30695)
- buildings_tools (30762)
- download_along (30762)
- editgpx (30737)
- imagery_offset_db (30808)
- measurement (30737)
- mirrored_download (30762)
- notes (v0.9.5)
- public_transport (30762)
- reltoolbox (30841)
- reverter (30737)
- tag2link (30719)
- terracer (30737)
- turnrestrictions (30762)
- undelete (30762)
- utilsplugin2 (30762)
- wikipedia (30780)

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'error_small.png'
- W: Mappaint style "standard" (FIXME Highlight Warnings) icon "error_small.png" not found.

[aseerel4c26]

Additional observations (with Version 7819):

1. This does not happen if there is also a data or a gpx layer (downloaded in the same step).
2. In fact, if I only have a notes layer I also cannot open the note by clicking on it in the mapview. I guess that is related.

[Klumbumbus]

Hm. I don't know how this bug happend to me with 7805, but I'm not able to reproduce the problem anymore, except (as aseerel4c26 mentioned) I download only notes (which wasn't possible in 7805).

[ToeBee]

Hehe I wondered how long it would be before someone noticed this one. Quicker than I managed to get a fix in place, it seems :)

I'm not quite sure what's going wrong here. It seems like without a data layer of some kind open in addition to notes, the map frame isn't getting click events from the mouse. Or maybe the main map frame is but isn't passing them along to the note layer.

[ToeBee]

I was trying to register the note layer as a mouse listener at the wrong time. If the note layer was the first layer to be created, it was trying to register itself while Main.map was null. To fix, I discovered and used the Layer.hookUpMapView method which is called after Main.map has been created.

[bastiK]

In 7820/josm:

fixed #10857 - notes popup can not be opened or closed via the mapview if there is only the notes layer (patch by ToeBee)

[stoecker]

BTW: Should we deprecate notes plugin in JOSM core? Then it is automatically deinstalled and no longer listed in plugin list?

[Klumbumbus]

Replying to stoecker:

BTW: Should we deprecate notes plugin in JOSM core? Then it is automatically deinstalled and no longer listed in plugin list?

Not as long as the core notes feature is disabled by default.

[ToeBee]

I'm thinking maybe for the January release. There are a few more things I'd like to tweak and I'm not sure how much time I will have in the next two weeks since I will be traveling for christmas.

[aseerel4c26]

Tested: works as expected now (with Version 7829).