Opened 10 years ago
Closed 10 years ago
#10701 closed enhancement (fixed)
Initial support changeset discussions (comments) in changeset dialog
Reported by: | Don-vip | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 14.11 |
Component: | Core | Version: | |
Keywords: | api changeset comment discussion | Cc: | bastiK, stoecker, akks, Klumbumbus |
Description
There's a new feature on OSM website which allows mappers to comment changesets:
osmwiki:API_v0.6#Changeset_discussion
We should see how to support this new API.
Attachments (0)
Change History (12)
comment:1 by , 10 years ago
Milestone: | → 14.11 |
---|
comment:2 by , 10 years ago
follow-up: 6 comment:4 by , 10 years ago
This does not work for me. I added a comment here, but the discussion tab in the changeset dialog of JOSM is empty.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2014-11-04 02:34:11 Last Changed Author: Don-vip Revision: 7704 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Relative URL: ^/trunk URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2014-11-04 02:33:20 +0100 (Tue, 04 Nov 2014) Last Changed Rev: 7704 Identification: JOSM/1.5 (7704 de) Windows 7 32-Bit Memory Usage: 247 MB / 742 MB (164 MB allocated, but free) Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=50084, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==] Dataset consistency test: No problems found Plugins: - DirectUpload (30737) - HouseNumberTaggingTool (30762) - OpeningHoursEditor (30737) - PicLayer (30762) - Tracer2 (30695) - buildings_tools (30762) - download_along (30762) - editgpx (30737) - imagery_offset_db (30762) - measurement (30737) - mirrored_download (30762) - notes (v0.9.4) - public_transport (30762) - reltoolbox (30762) - reverter (30737) - tag2link (30719) - terracer (30737) - turnrestrictions (30762) - undelete (30762) - utilsplugin2 (30762) - wikipedia (30780) Last errors/warnings: - W: Mappaint style "standard" (JOSM default (XML; old version)) icon "josm_small.png" not found. - E: Fehler beim Laden des Bildes 'icon.svg' - W: Mappaint style "standard" (ZeigeID) icon "icon.svg" not found. - E: Fehler beim Laden des Bildes 'error_small.png' - W: Mappaint style "standard" (FIXME Highlight Warnings) icon "error_small.png" not found.
comment:6 by , 10 years ago
comment:8 by , 10 years ago
Cc: | added |
---|
@team: do you think it would be useful/wanted to have a way to display changeset comments in history dialog? I think it would be nice, but I'm not sure about how displaying them...
follow-up: 10 comment:9 by , 10 years ago
Actually I never use the changeset manager dialog, but only the history dialog. So it would be nice if the history dialog displays if there is a discussion to this changeset.
I suggest to display a link in the history dialog "Display discussion to this changeset" if there is at least one discussion comment. And the link opens the changeset manager dialog and displays directly the discussion.
follow-up: 11 comment:10 by , 10 years ago
Replying to Klumbumbus:
Actually I never use the changeset manager dialog, but only the history dialog. So it would be nice if the history dialog displays if there is a discussion to this changeset.
I suggest to display a link in the history dialog "Display discussion to this changeset" if there is at least one discussion comment. And the link opens the changeset manager dialog and displays directly the discussion.
+1
Think changeset manager dialog is one of the least used dialogs.
comment:11 by , 10 years ago
Replying to skyper:
Think changeset manager dialog is one of the least used dialogs.
Maybe because the changeset link in the history dialog opens the changeset on osm.org in the browser and not the changeset manager dialog of JOSM.
comment:12 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Summary: | Support changeset discussions (comments) → Initial support changeset discussions (comments) in changeset dialog |
That's all for this month, let's continue the discussion on #10789.
In 7700/josm: