#10630 closed defect (fixed)
broken match in access preset
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.10 |
| Component: | Internal preset | Version: | latest |
| Keywords: | access match | Cc: |
Description (last modified by )
The is a wrong value for match which prevents the general access preset from showing up in the tag/membership toggle dialog
Please, find attached patch which fixes the problem.
Attachments (1)
Change History (8)
by , 10 years ago
| Attachment: | access_match_preset.diff added |
|---|
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
Oh, I forgot: Think it was intentional to prevent the mismatch with the other values from emergency as main tag. Though, this does not work as we do not have an option for "keyvalue and neutral otherwise".
follow-up: 4 comment:3 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
I'm not sure to understand the problem. What kind of object/tags cause your problem?
comment:4 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | needinfo → new |
Replying to Don-vip:
I'm not sure to understand the problem. What kind of object/tags cause your problem?
My problem is that without emergency=yes,official,designated,destination,permissive,private,no the "general access preset" will never match due to `match="tagvalue". This was introduced to fix #8995 though.
comment:5 by , 10 years ago
| Milestone: | → 14.10 |
|---|---|
| Summary: | [patch] broken match in access preset → broken match in access preset |
Ok thanks. I'll add the missing match mode instead of reverting this change.
patch