Modify

Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#10591 closed defect (duplicate)

Using the Command Line plugin breaks keyboard shortcuts.

Reported by: Stereo Owned by: Stereo
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

On Mac OS X, with the latest JOSM and command line plugin, entering a command in the plugin breaks (at least) the S/A keyboard shortcuts.

What steps will reproduce the problem?

  1. Install the command line plugin with the scripts.
  2. Download an area, make sure the S/A keys activate the selection and draw modes.
  3. Enter an arbitrary command, like Circle with any centre, radius and number of sides.
  4. Press the S and A keys again.

What is the expected result?

Toggle between selection and drawing mode.

What happens instead?

Modes don't change with the keyboard shortcuts. Clicking on the toolbar works for all three.

Please provide any additional information below. Attach a screenshot if
possible.

Switching between rectangle and lasso selection works. The return key doesn't activate the command line plugin anymore. This worked fine in the previous Tested version of JOSM.

Relaunching JOSM makes the S/A shortcuts work again.

No messages in the console.

Revision: 7588
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2014-09-29 23:52:43 +0200 (Mon, 29 Sep 2014)
Build-Date: 2014-09-29 22:12:08
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7588

Identification: JOSM/1.5 (7588 en_GB) Mac OS X 10.9.5
Memory Usage: 531 MB / 3641 MB (276 MB allocated, but free)
Java version: 1.8.0_20, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=/Users/stereo/Library, -DDocumentsDirectory=/Users/stereo/Documents, -DApplicationSupportDirectory=/Users/stereo/Library/Application Support, -DCachesDirectory=/Users/stereo/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.hwaccel=false]

Plugins:
- AddrInterpolation (30416)
- CommandLine (30678)
- DirectDownload (30697)
- DirectUpload (30697)
- FixAddresses (30416)
- HouseNumberTaggingTool (30416)
- OpeningHoursEditor (30609)
- PicLayer (30436)
- RoadSigns (30495)
- alignways (30631)
- areaselector (1411072924)
- buildings_tools (30485)
- cadastre-fr (30703)
- conflation (0.1.7)
- contourmerge (1010)
- dataimport (30416)
- download_along (30416)
- geotools (30569)
- imagery_offset_db (30534)
- importvec (30416)
- jts (30416)
- livegps (30506)
- mapdust (30502)
- merge-overlap (30416)
- mirrored_download (30664)
- namemanager (30416)
- notes (v0.9.4)
- opendata (30607)
- pdfimport (30416)
- public_transport (30664)
- reverter (30521)
- scripting (30700)
- surveyor (30646)
- tageditor (30703)
- terracer (30643)
- turnlanes (30416)
- turnrestrictions (30651)
- undelete (30416)
- utilsplugin2 (30460)

Last errors/warnings:
- E: Failed to locate image ''
- E: Failed to locate image ''
- W: Could not get presets icon 
- E: Failed to locate image ''
- W: Could not get presets icon

Attachments (0)

Change History (5)

in reply to:  description comment:1 by Don-vip, 10 years ago

Replying to Stereo:

The return key doesn't activate the command line plugin anymore.

I think this part of the bug is due to javabug:8058193.

comment:2 by Don-vip, 10 years ago

Owner: changed from team to Stereo
Status: newneedinfo

Maybe the whole bug is due to this Java bug in fact. Can you please try with JDK 7u67 ?

comment:3 by Stereo, 10 years ago

Hi Don-vip. I can reproduce the bug with 7u67. I've tried older JOSM versions from https://josm.openstreetmap.de/download/ too; the bug doesn't exist in 7499 with 7u67, but exists in 7505.

JOSM Version Java version Bug
7499 7u67 No
7505 7u67 Yes
7588 7u67 Yes
7588 8u20 Yes

In https://josm.openstreetmap.de/changeset?reponame=josm&new=7505&old=7499 I see changes and overrides in JosmTextField. Tell me if you'd like me to test a build without these changes?

comment:4 by OceanVortex, 10 years ago

I just got bitten by this too (Windows 7 Pro 64-bit, Java 7u67) when I updated JOSM to 7588. All single-letter commands stop working (e.g. X for extrude mode, B for buildings, Q for quadralateralize). Unfortunately this makes CommandLine unusable.

comment:5 by Don-vip, 10 years ago

Resolution: duplicate
Status: needinfoclosed

Closed as duplicate of #10633.
regression of r7539, fixed through #10633.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Stereo.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.