#10491 closed enhancement (fixed)
Add note icons
| Reported by: | ToeBee | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.09 |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description
I will have more note related patches soon. But in the mean time, I might as well get the icons added in. SVN patches don't do binary files so you will have to download and add these files yourself. In the plugin I'm using 16 and 22 pixel images. Most icons in core seem to be 16 and/or 24 pixels so I went with that. They can be seen here:
https://github.com/ToeBee/myjosm/tree/notes-download-task/images/notes
Attachments (0)
Change History (11)
comment:1 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 10 years ago
What is the license of these icons? You can try if it looks okay to shrink the 22x22 px ones at runtime (to minimize the size of the binary). SVG is also supported (partially).
comment:3 by , 10 years ago
| Milestone: | → 14.09 |
|---|
follow-up: 6 comment:4 by , 10 years ago
I got the original files off of the wiki where it says they are CC-BY-SA 2.0. The same icon design is also in use in the OSM rails port (also GPL).
comment:6 by , 10 years ago
Replying to ToeBee:
I got the original files off of the wiki where it says they are CC-BY-SA 2.0. The same icon design is also in use in the OSM rails port (also GPL).
Then we should contact the author and ask for permission to use under GPL or find replacement with suitable license.
On openclipart.org I can find this:
(link)
(link)
comment:7 by , 10 years ago
I asked in #osm-dev. Turns out, the wiki is wrong! Who would have guessed? Anyway, the icons are part of the rails port and as such are under GPLv2.
comment:8 by , 10 years ago
Hm, GPLv2 is not good, we need version 3 of the GPL. (The Apache 2.0 code we are using can be re-licensed to GPLv3, but not to GPLv2.)
comment:9 by , 10 years ago
I sent an email to Leo (the author of the commit that added these icons to the rails port) asking if he would be willing to allow GPLv3. We can certainly use a generic marker icon like the one above but I would prefer to use the same one that people see on osm.org if possible.
comment:10 by , 10 years ago
I got a response saying he is fine with GPLv3. Is this good enough or do I need to have him post that somewhere public or something?
In 7513/josm: