Modify

Opened 10 years ago

Closed 10 years ago

#10481 closed defect (irreproducible)

Preset not respecting XML comments

Reported by: Aun Johnsen <lists@…> Owned by: Aun Johnsen <lists@…>
Priority: normal Milestone:
Component: External preset Version: latest
Keywords: preset XML Cc:

Description

Preset doesn't respect xml comments with <!-- and -->

For debugging I commented out with <!-- and --> a menu item I suspected was not correct, in my editor the entire item showed up as commented out, but reloading JOSM the menu item still appeared on the menu.

I checked that the file was loaded from local disc, this is the third or fourth session of JOSM after I commented out that item.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-08-31 21:55:55
Last Changed Author: Don-vip
Revision: 7480
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-08-31 23:51:24 +0200 (Sun, 31 Aug 2014)
Last Changed Rev: 7480

Identification: JOSM/1.5 (7480 en) Mac OS X 10.9.4
Memory Usage: 343 MB / 910 MB (136 MB allocated, but free)
Java version: 1.7.0_67, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=/Users/skippern/Library, -DDocumentsDirectory=/Users/skippern/Documents, -DApplicationSupportDirectory=/Users/skippern/Library/Application Support, -DCachesDirectory=/Users/skippern/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
- PicLayer (30436)
- SeaMapEditor (30475)
- continuosDownload (28565)
- dataimport (30416)
- geotools (30569)
- jts (30416)
- mirrored_download (30495)
- notes (v0.9.4)
- opendata (30607)
- reverter (30521)
- turnlanes (30416)
- turnrestrictions (30454)
- utilsplugin2 (30460)

Last errors/warnings:
- W: Could not get presets icon road.png
- E: Failed to locate image 'ES_s22.png'
- W: Could not get presets icon ES_s22.png
- E: java.net.SocketException: Network is unreachable
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketException: Network is unreachable

Attachments (0)

Change History (8)

comment:1 by bastiK, 10 years ago

Please add your preset as attachment, preferably reduced to a single rule.

comment:2 by Don-vip, 10 years ago

Owner: changed from team to Aun Johnsen <lists@…>
Status: newneedinfo

comment:3 by Aun Johnsen <lists@…>, 10 years ago

This item still showed up after restarting JOSM several times, it have now been deleted from the preset and is finally gone:

<!--            <item name="Em Obras Implantação" icon="presets/way_tertiary.png" type="way,closedway,relation">
                        <label text="DNIT class highway under implementation"
                                pt.text="DNIT classe rodovia em implantação" />
                        <key key="highway" value="tertiary" match="none"/>
                        <key key="surface" value="unpaved" match="none"/>
                        <text key="name" text="Name"/>
                        <text key="ref" text="Reference"/>
                        <reference ref="rodovia"/>
                        <reference ref="road_attributes"/>
                </item>     -->

No type of warning or messages was observed.

comment:4 by Don-vip, 10 years ago

Owner: changed from Aun Johnsen <lists@…> to team
Status: needinfonew

comment:5 by Don-vip, 10 years ago

Owner: changed from team to Aun Johnsen <lists@…>
Status: newneedinfo

Cannot reproduce. How did you add your preset in JOSM? A simple cache issue may likely be the cause.

comment:6 by Aun Johnsen <lists@…>, 10 years ago

It was loaded from local disc, so I supposed no caching, does JOSM cache local files?

comment:7 by Don-vip, 10 years ago

It should not. Could you please attach your entire file this time? Maybe a strange OS X issue, I'm not sure.

comment:8 by Don-vip, 10 years ago

Resolution: irreproducible
Status: needinfoclosed

Sorry, I really can't reproduce. Please reopen if you get this error again with latest JOSM.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Aun Johnsen <lists@…>.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.